Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp482779ybl; Tue, 28 Jan 2020 06:39:17 -0800 (PST) X-Google-Smtp-Source: APXvYqz3caAKI6v5cZzlOIlkQ8P3Fhr0ccTFAmoY350r0Zsbj4QkdmCE31JdmrcE400E0aaY4Xui X-Received: by 2002:a9d:760e:: with SMTP id k14mr15862483otl.344.1580222357269; Tue, 28 Jan 2020 06:39:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580222357; cv=none; d=google.com; s=arc-20160816; b=Ou5wOct1JPwlLwFTsrgplN9Zwpkycui4mxm7RHXKGp7M2dE8FQ24iNxsxKadgFjR/a v3VAL3pP0skdW9tnlDqh+W5MKI2f3kKz3M97qcHE35NXZ/4mTTqkDR47Z2SRcsZ607r8 +73RQUfqSpwFVSTP84I9ct5yQi6hmDjMR0C07db5dT/BALw/7E2+nXq/ixAXV3Wrez3i kBFx+4Q8tr8fp4AG5kYWyH+BMUjiDoig3TFB6Gbu4WF0peqbwBb4uyE0dmfQA0iXo3Ml UQt7x1c2pT0b/oiSD4YA9Ixsp4xvlLk4lDil09YasVUhGJX/ExyMjrhOe2TVoyTW2tdz 8FFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=s5WPYg9Wh42FFNEOMrPHYsdYpKpeI/S01qjXcBQ2KPk=; b=rrbaLMfHCijB1y99Q0VJ7t+n65b0K0CGmw1kWszKGpwigd1DTm3QRvlLiBfpkfevgo EWIZBWbN0hLSfw0GQVL6MLwRdQPpbPrnmP3OIsqdlv9e4Z0RuOO7GXuc/aB/9dxCl2Sb EPepTm3xbqiJ69GiROQAAyHLn6pzLborP46vWlC2fmFsBuQS9BLQ7A8YSmJhJLlaEeta 8oYLUeOPMWcirrp9jokFGryXKJ2lux15PVv5kCa4smz1VwBs6uzuaq5wuKmXlxHOeFCW tJSrrMPRup4IPynQHcEVOmBYVPv4DGZipHKPnYR+fzAzSGMQM2A91DHNW50dxM4FQSUp 8DSw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2neZGfPA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w2si8775429otk.126.2020.01.28.06.39.03; Tue, 28 Jan 2020 06:39:17 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2neZGfPA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731098AbgA1OUd (ORCPT + 99 others); Tue, 28 Jan 2020 09:20:33 -0500 Received: from mail.kernel.org ([198.145.29.99]:45392 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730368AbgA1OU3 (ORCPT ); Tue, 28 Jan 2020 09:20:29 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2730E24688; Tue, 28 Jan 2020 14:20:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580221228; bh=kPyiXJbADDCV7SwEt+sLGPO1DG8hKF3YTf0rZi6pHr8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2neZGfPAnSIkQey2/8gH6pBUwZIP05zX7i3VzQY+lOhGSmYUwoiI93gjDUwFqZ5TG XOg1cRiwbyMPN9JjLkPOMvJ+Op0xsrGe9gaTVceqOYOYi8chehO6vCAPjodbYGlVPH iNOh3X/kDDb1xNYMhdcCYNo7LqPh2ZvNL0djSW1g= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Bichao Zheng , Martin Blumenstingl , Neil Armstrong , Thierry Reding , Sasha Levin Subject: [PATCH 4.9 139/271] pwm: meson: Dont disable PWM when setting duty repeatedly Date: Tue, 28 Jan 2020 15:04:48 +0100 Message-Id: <20200128135902.926407943@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200128135852.449088278@linuxfoundation.org> References: <20200128135852.449088278@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bichao Zheng [ Upstream commit a279345807e1e0ae79567a52cfdd9d30c9174a3c ] There is an abnormally low about 20ms,when setting duty repeatedly. Because setting the duty will disable PWM and then enable. Delete this operation now. Fixes: 211ed630753d2f ("pwm: Add support for Meson PWM Controller") Signed-off-by: Bichao Zheng [ Dropped code instead of hiding it behind a comment ] Signed-off-by: Martin Blumenstingl Reviewed-by: Neil Armstrong Signed-off-by: Thierry Reding Signed-off-by: Sasha Levin --- drivers/pwm/pwm-meson.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/pwm/pwm-meson.c b/drivers/pwm/pwm-meson.c index f58a4867b5194..a196439ee14c7 100644 --- a/drivers/pwm/pwm-meson.c +++ b/drivers/pwm/pwm-meson.c @@ -320,11 +320,6 @@ static int meson_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, if (state->period != channel->state.period || state->duty_cycle != channel->state.duty_cycle || state->polarity != channel->state.polarity) { - if (channel->state.enabled) { - meson_pwm_disable(meson, pwm->hwpwm); - channel->state.enabled = false; - } - if (state->polarity != channel->state.polarity) { if (state->polarity == PWM_POLARITY_NORMAL) meson->inverter_mask |= BIT(pwm->hwpwm); -- 2.20.1