Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp488598ybl; Tue, 28 Jan 2020 06:44:56 -0800 (PST) X-Google-Smtp-Source: APXvYqwNbCuKMfewUxQdfaiSuQUJQSisF9kMHBmjxLCUdaIpspg0Jq2Z1OZRujqbbZD7eK7Zdimb X-Received: by 2002:a05:6808:3b2:: with SMTP id n18mr2889055oie.146.1580222696314; Tue, 28 Jan 2020 06:44:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580222696; cv=none; d=google.com; s=arc-20160816; b=CkHRr8768w7v1e0AjAKQkV7Kk/h0AuDVLTV8JuFX93HbK8ljfWZq6TFwmqySSj219o MVEWW3Oko2rYSMe+JwnENdkrDeEQxZjED1b42pi4PREJaz/ckJp35S7Jd6WNKSX557ke FTv9IEm0X6wlo3Hx5cViu67nYnlRdcUUKNqcucARnFgL0EvQh8mYTDvmGy/hhxXnI2Pg SYNUgKY3LiOyBIZ7O2z1Uc9Qazx4Qgnkxcil87s2A0OMeS3mJEpGmVnTEVURgX/r6PRC JWkKQyMoJRv1fCAUkGkLGagvgwilgXO9gHucPvr42roEZjTcyUtAd/Bt9Im7IwpwqeOi NJTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ol0NYeURbSntEEKDflR45Flo45xmS+UCiynFJhUbBm0=; b=vmGD2rBQ4uszlFLMIhrYzBzMF0RJvWGx5XPpyrVf2/rC6Qdd86xPjNVKIhtudC8EZs fVNTC5hIbQ/yhm46ev8Zl6C4FtIQBHRKPMl7Vf+c0t3gbDpdxhRv71zhEnpxTHwMWKip O2I3RC1N8iz5214CXTGR5FvohVJP54s2jk89/tHlLu3YAm3spy4TARYyhS0y/5oKTTjo vYpNq1aowPB7yqqhmkd+3eYp4VaP8EVVoz4bKarxd5Lp7B0/j/Z5Kg/4CXIlV98W1yNh CP8+APad2L1biaql+OzlKmePTpsw1bI2IcL4Cg+NWsbHw+jXK0BpyNo7USokR/v7YDtZ rGpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=gKJzqix7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f17si8434428oto.85.2020.01.28.06.44.43; Tue, 28 Jan 2020 06:44:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=gKJzqix7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730462AbgA1OmO (ORCPT + 99 others); Tue, 28 Jan 2020 09:42:14 -0500 Received: from mail.kernel.org ([198.145.29.99]:35002 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729673AbgA1ONY (ORCPT ); Tue, 28 Jan 2020 09:13:24 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4B5142468A; Tue, 28 Jan 2020 14:13:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580220803; bh=jWX4yRT6wWNhtg/Qm5ktJS7s58vdqoc6Q3ETV5KR6dA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gKJzqix7B+nPWm6iTDG3mKY8xCml1kjG02Q+SBMRb69KnE4Kl0O206EUle25QScIJ qdawomnn2xyW/JDMNQhwTMQRz1/M5Fv9Io9MN3jLKAzb+Pbkv2xiyEkQTQYPVHCO3H W8gqH2DyiZOOD0+ckJFFQK29TTzxcUV+zy56EPpE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Steve French , Ronnie Sahlberg , "Eric W. Biederman" , Sasha Levin Subject: [PATCH 4.4 117/183] cifs: fix rmmod regression in cifs.ko caused by force_sig changes Date: Tue, 28 Jan 2020 15:05:36 +0100 Message-Id: <20200128135841.627295546@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200128135829.486060649@linuxfoundation.org> References: <20200128135829.486060649@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Steve French [ Upstream commit 247bc9470b1eeefc7b58cdf2c39f2866ba651509 ] Fixes: 72abe3bcf091 ("signal/cifs: Fix cifs_put_tcp_session to call send_sig instead of force_sig") The global change from force_sig caused module unloading of cifs.ko to fail (since the cifsd process could not be killed, "rmmod cifs" now would always fail) Signed-off-by: Steve French Reviewed-by: Ronnie Sahlberg CC: Eric W. Biederman Signed-off-by: Sasha Levin --- fs/cifs/connect.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index b608ce741444f..f44281a5eb9ff 100644 --- a/fs/cifs/connect.c +++ b/fs/cifs/connect.c @@ -939,6 +939,7 @@ cifs_demultiplex_thread(void *p) mempool_resize(cifs_req_poolp, length + cifs_min_rcv); set_freezable(); + allow_signal(SIGKILL); while (server->tcpStatus != CifsExiting) { if (try_to_freeze()) continue; -- 2.20.1