Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp491254ybl; Tue, 28 Jan 2020 06:47:41 -0800 (PST) X-Google-Smtp-Source: APXvYqyB9F0+VulvXD52Hc6hpMg60NA4cZAISWVdwnPwbwdkGoWE819wSpyX/h0++ceUp0jH1VHV X-Received: by 2002:a9d:518b:: with SMTP id y11mr15832644otg.349.1580222860952; Tue, 28 Jan 2020 06:47:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580222860; cv=none; d=google.com; s=arc-20160816; b=vSZ8tq+sAMI5meuJrLP3OZZPcjfLUlgJymduHhD5GpFc+phbQpOTrokBQVYaKJ5WMY 7315qosHx/WfOIPxR9SWtQgGWSpxm/+lMWAj4+NXeuv8Ttd4qtupC+FCmt8WbK/v3HG2 I8wIT8EBx8fmNLm2tmh2SVXyNCPPwJdaZco2YC4RxTfQtV9XZLyhKX+EM61dAqepDn2G dfAdmTaQzqH7O/tqat0T/MimpL8wePfxRXGFOyLT/ZNXeOh/SUsxzr2ULCEVLAzfnKCN So7LGmtE3xIen5IW+CAtVBsJ+h6tyySNkGg15VkHS6HDtfajT3uHvzFewV4+JYgSY3eD 0bTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=xRh8Inmb1xEVp6MASNVZDgK9AbERnIrym+MIa+6WAKw=; b=p4UIWermb2CuWYA9sEuXoytg3LpJzfuTj+SMBFqNaMME/S+wYDuJn69guPQE96p5Al iuKMM/HzUQ5xQhbTyb/dkTKqnjvnqmJ+9IA4XrzUAUqNCHB9sgZ6Gr2yG7Uz6eNR0gYY X9mOFLtnUuFRXTcYNyfZSCN1qM+OLaRt0o6z5RfKGL6nNLgtVbrdNtX68007lS3yMXlE qM4PvQ+ck1z0kTXLuT8OJYAp9+F1XtnMpLygnziWcFPHdBwHc0Ily0bjY50wcgB4bAMh xbUs+yqJHYR6Fwu0KnQPwCC/CXBA/9IMxaCoYZ4rLDQfpx+tmmbu2E0eUzP0cIaRny0N uFTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ncotS0nr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a7si4219004otp.11.2020.01.28.06.47.29; Tue, 28 Jan 2020 06:47:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ncotS0nr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727941AbgA1OJr (ORCPT + 99 others); Tue, 28 Jan 2020 09:09:47 -0500 Received: from mail.kernel.org ([198.145.29.99]:58132 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729021AbgA1OJj (ORCPT ); Tue, 28 Jan 2020 09:09:39 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C9D4824681; Tue, 28 Jan 2020 14:09:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580220579; bh=/s9ACbFT8qMDpDRwayydE1Jt32U6UwpIRX67EL52aKs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ncotS0nrHrKJqTJLjIxgZk1NTVNDW+C2sPvgamTYnV0u92thxHa4PMkY4Ni+qoYzF P440QeOQFNicH78Nt6H8YptVfX4QY+clDjrKIPsIbyQleLKYEVEGNePsEb8wO6Rqsf 8V2OfC5smQT2sXiMDfZ/Fr5mgzj+hcmtE9w6FM7k= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 4.4 062/183] media: cx18: update *pos correctly in cx18_read_pos() Date: Tue, 28 Jan 2020 15:04:41 +0100 Message-Id: <20200128135836.178903262@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200128135829.486060649@linuxfoundation.org> References: <20200128135829.486060649@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter [ Upstream commit 7afb0df554292dca7568446f619965fb8153085d ] We should be updating *pos. The current code is a no-op. Fixes: 1c1e45d17b66 ("V4L/DVB (7786): cx18: new driver for the Conexant CX23418 MPEG encoder chip") Signed-off-by: Dan Carpenter Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/pci/cx18/cx18-fileops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/cx18/cx18-fileops.c b/drivers/media/pci/cx18/cx18-fileops.c index df837408efd59..0171dc5b8809e 100644 --- a/drivers/media/pci/cx18/cx18-fileops.c +++ b/drivers/media/pci/cx18/cx18-fileops.c @@ -490,7 +490,7 @@ static ssize_t cx18_read_pos(struct cx18_stream *s, char __user *ubuf, CX18_DEBUG_HI_FILE("read %zd from %s, got %zd\n", count, s->name, rc); if (rc > 0) - pos += rc; + *pos += rc; return rc; } -- 2.20.1