Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp495465ybl; Tue, 28 Jan 2020 06:51:33 -0800 (PST) X-Google-Smtp-Source: APXvYqwcVhv7cQ9FvovHJQ9wYzUiEpQyeEiVlKJAtV4DIYXu2C4UF2IyGouvSMfdsn3Q7i/L3zOT X-Received: by 2002:a9d:3cf:: with SMTP id f73mr16826207otf.11.1580223093248; Tue, 28 Jan 2020 06:51:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580223093; cv=none; d=google.com; s=arc-20160816; b=e3kswMKSRfBIOPIG4wX+2YbsdM7N2m20UQsX2WOwYcyMjWmv8qDAkzHZtpeAqzNZXf u58OZ73DbEmipFA/XfpDktehrX2Y3O8u+uIkSZD4HuCRGsI52JbBjoS5Zwp5nAJw7V57 rx0aSGA2Hefv8OKKRRzeI7vt3HPfl5FGduJTyO2g0UuGQcCaICXy/7GSeBTbwZX6TkwI cy1kAtVRkGqj1KsIKODtZgYb2l/c8wwymjDN9VufegMqt+iFH+SD/a68kUQaZI4Jp6ZE eWQ+QP9Dphj/yXtBo7tvNZ/aP2e9sMNAlqbRC0pdbxYoAQLW53QBVv5faZYQbGh0qY7T gZTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=xA2CT9YcP3aVohCQgp89r7gIV+64gcKDH7hNft0SlDc=; b=ChBccgVlPb0tgACYewPf0byzvcYse+sueKIriHmK8vsaq+KSulBVY4ExoRcRsbsL4S T57iEMQW4Apz7DStLXdFpV0CphMPmskvr/ZSahPQbZrWTZlNAzolA6urbMpoBTSdEZ6t yzUw7cunKiQWvWWSFB3YnkjX4lombtv948ZbFyRDYrA814/LRJlrPa/BrOKLd4M4t5LO RLndxiFo/yD44AMUnr4rGcBZ5LCho5I1SOId9FdVR+2evbSds+IvsX0dl+PnTLE5ByQx Gq9G9egUvCvK4LHS7m++Mrr2FpI1pqK0r/BEbnIqFRi5sa341faUzBDYFKuOlJq3TUWs dIVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=0zg391c7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g26si9030227otn.180.2020.01.28.06.51.21; Tue, 28 Jan 2020 06:51:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=0zg391c7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727327AbgA1Os6 (ORCPT + 99 others); Tue, 28 Jan 2020 09:48:58 -0500 Received: from mail.kernel.org ([198.145.29.99]:48026 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727210AbgA1OBw (ORCPT ); Tue, 28 Jan 2020 09:01:52 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7234E24685; Tue, 28 Jan 2020 14:01:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580220111; bh=intayEvlwG5iSgRRqpJXqWohS2b+wWvz59B9dftJtAE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=0zg391c7GFC62/t3Y80OajSf5lrzWlONcZfwC03dZbBso2BA6j9xQfIqc2rIHGK50 6BByKj3yy0Tj/4jI5dBJ6S6XH6tdjYXrDB1PJUUO4H+zwePWnLBvuDRi38sdt6Jknl sjNnuBjgnqUYhUj2ez10/Ia/s/T90AqXCfUIqc00= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dmitry Vyukov , Kristian Evensen , "David S. Miller" Subject: [PATCH 5.4 022/104] fou: Fix IPv6 netlink policy Date: Tue, 28 Jan 2020 14:59:43 +0100 Message-Id: <20200128135820.333512491@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200128135817.238524998@linuxfoundation.org> References: <20200128135817.238524998@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kristian Evensen [ Upstream commit bb48eb9b12a95db9d679025927269d4adda6dbd1 ] When submitting v2 of "fou: Support binding FoU socket" (1713cb37bf67), I accidentally sent the wrong version of the patch and one fix was missing. In the initial version of the patch, as well as the version 2 that I submitted, I incorrectly used ".type" for the two V6-attributes. The correct is to use ".len". Reported-by: Dmitry Vyukov Fixes: 1713cb37bf67 ("fou: Support binding FoU socket") Signed-off-by: Kristian Evensen Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/ipv4/fou.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/net/ipv4/fou.c +++ b/net/ipv4/fou.c @@ -662,8 +662,8 @@ static const struct nla_policy fou_nl_po [FOU_ATTR_REMCSUM_NOPARTIAL] = { .type = NLA_FLAG, }, [FOU_ATTR_LOCAL_V4] = { .type = NLA_U32, }, [FOU_ATTR_PEER_V4] = { .type = NLA_U32, }, - [FOU_ATTR_LOCAL_V6] = { .type = sizeof(struct in6_addr), }, - [FOU_ATTR_PEER_V6] = { .type = sizeof(struct in6_addr), }, + [FOU_ATTR_LOCAL_V6] = { .len = sizeof(struct in6_addr), }, + [FOU_ATTR_PEER_V6] = { .len = sizeof(struct in6_addr), }, [FOU_ATTR_PEER_PORT] = { .type = NLA_U16, }, [FOU_ATTR_IFINDEX] = { .type = NLA_S32, }, };