Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] kbuild: Include external modules compile flags
To:     Masahiro Yamada <masahiroy@kernel.org>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        dev@openvswitch.org, dsahern@gmail.com
References: <1580161806-8037-1-git-send-email-gvrose8192@gmail.com>
 <CAK7LNAQyh9CFgKd1DtAPFW8DuHNp1gn8YABuP8-LsF=hHK2DFw@mail.gmail.com>
From:   Gregory Rose <gvrose8192@gmail.com>
Message-ID: <f6ffa0d0-8214-8fc0-4fe9-4b70a1581d3e@gmail.com>
Date:   Tue, 28 Jan 2020 07:37:58 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.2
MIME-Version: 1.0
In-Reply-To: <CAK7LNAQyh9CFgKd1DtAPFW8DuHNp1gn8YABuP8-LsF=hHK2DFw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 1/27/2020 7:35 PM, Masahiro Yamada wrote:
> On Tue, Jan 28, 2020 at 6:50 AM Greg Rose <gvrose8192@gmail.com> wrote:
>> Since this commit:
>> 'commit 9b9a3f20cbe0 ("kbuild: split final module linking out into Makefile.modfinal")'
>> at least one out-of-tree external kernel module build fails
>> during the modfinal make phase because Makefile.modfinal does
>> not include the ccflags-y variable from the exernal module's Kbuild.
> ccflags-y is passed only for compiling C files in that directory.
>
> It is not used for compiling *.mod.c
> This is true for both in-kernel and external modules.
>
> So, ccflags-y is not a good choice
> for passing such flags that should be globally effective.
>
>
> Maybe, KCFLAGS should work.
>
>
> module:
>         $(MAKE) KCFLAGS=...  M=$(PWD) -C /lib/modules/$(uname -r)/build modules
>

Thanks,

I'll see if I can get that to work.

- Greg


>
>> Make sure to include the external kernel module's Kbuild so that the
>> necessary command line flags from the external module are set.
>>
>> Reported-by: David Ahern <dsahern@gmail.com>
>> CC: Masahiro Yamada <yamada.masahiro@socionext.com>
>> Signed-off-by: Greg Rose <gvrose8192@gmail.com>
>> ---
>>   scripts/Makefile.modfinal | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/scripts/Makefile.modfinal b/scripts/Makefile.modfinal
>> index 411c1e60..a645ba6 100644
>> --- a/scripts/Makefile.modfinal
>> +++ b/scripts/Makefile.modfinal
>> @@ -21,6 +21,10 @@ __modfinal: $(modules)
>>   modname = $(notdir $(@:.mod.o=))
>>   part-of-module = y
>>
>> +# Include the module's Makefile to find KBUILD_EXTRA_SYMBOLS
>> +include $(if $(wildcard $(KBUILD_EXTMOD)/Kbuild), \
>> +             $(KBUILD_EXTMOD)/Kbuild)
>> +
>>   quiet_cmd_cc_o_c = CC [M]  $@
>>         cmd_cc_o_c = $(CC) $(c_flags) -c -o $@ $<
>>
>> --
>> 1.8.3.1
>>
>