Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: hNv10iBD2veD9e759UD4yjagpQPOv0m0KnF6N1HHbgtxPLEGM7nSN8xlf6fpqw7qoLwEwIvvCy
 lmwhefhCVHJA==
From:   <sjpark@amazon.com>
To:     Randy Dunlap <rdunlap@infradead.org>
CC:     <sjpark@amazon.com>, <akpm@linux-foundation.org>,
        SeongJae Park <sjpark@amazon.de>, <sj38.park@gmail.com>,
        <acme@kernel.org>, <amit@kernel.org>, <brendan.d.gregg@gmail.com>,
        <corbet@lwn.net>, <dwmw@amazon.com>, <mgorman@suse.de>,
        <rostedt@goodmis.org>, <kirill@shutemov.name>,
        <brendanhiggins@google.com>, <colin.king@canonical.com>,
        <minchan@kernel.org>, <vdavydov.dev@gmail.com>,
        <vdavydov@parallels.com>, <linux-mm@kvack.org>,
        <linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: Re: [PATCH v2 1/9] mm: Introduce Data Access MONitor (DAMON)
Date:   Tue, 28 Jan 2020 17:09:15 +0100
Message-ID: <20200128160915.25653-1-sjpark@amazon.com>
In-Reply-To: <95f6d1e3-7052-252e-1c29-f320e84df302@infradead.org> (raw)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 28 Jan 2020 08:06:38 -0800 Randy Dunlap <rdunlap@infradead.org> wrote:

> On 1/28/20 12:57 AM, sjpark@amazon.com wrote:
> > diff --git a/mm/Kconfig b/mm/Kconfig
> > index ab80933be65f..144fb916aa8b 100644
> > --- a/mm/Kconfig
> > +++ b/mm/Kconfig
> > @@ -739,4 +739,16 @@ config ARCH_HAS_HUGEPD
> >  config MAPPING_DIRTY_HELPERS
> >          bool
> >  
> > +config DAMON
> > +	tristate "Data Access Monitor"
> > +	depends on MMU
> > +	default y
> 
> Might be lightweight but still should not default to 'y'.

Good point, will default to 'n' in next spin.


Thanks,
SeongJae Park

> 
> > +	help
> > +	  Provides data access monitoring.
> > +
> > +	  DAMON is a kernel module that allows users to monitor the actual
> > +	  memory access pattern of specific user-space processes.  It aims to
> > +	  be 1) accurate enough to be useful for performance-centric domains,
> > +	  and 2) sufficiently light-weight so that it can be applied online.
> > +
> >  endmenu
> 
> thanks.
> -- 
> ~Randy
>