Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 28 Jan 2020 19:45:55 +0100
From:   Andreas Kemnade <andreas@kemnade.info>
To:     lee.jones@linaro.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: rn5t618: cleanup i2c_device_id
Message-ID: <20200128194555.324cff21@kemnade.info>
In-Reply-To: <20191211215731.19350-1-andreas@kemnade.info>
References: <20191211215731.19350-1-andreas@kemnade.info>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 boundary="Sig_/OBoX2dOW+n5S9UzDv+26TUn"; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--Sig_/OBoX2dOW+n5S9UzDv+26TUn
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi,

just re-checking the patch again. Seems that I have added it on top of my R=
TC
series. It breaks because of...

On Wed, 11 Dec 2019 22:57:31 +0100
Andreas Kemnade <andreas@kemnade.info> wrote:

> That list was just empty, so it can be removed if .probe_new
> instead of .probe is used
>=20
> Suggested-by: Lee Jones <lee.jones@linaro.org>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
>  drivers/mfd/rn5t618.c | 11 ++---------
>  1 file changed, 2 insertions(+), 9 deletions(-)
>=20
> diff --git a/drivers/mfd/rn5t618.c b/drivers/mfd/rn5t618.c
> index 18d56a732b20..70d52b46ee8a 100644
> --- a/drivers/mfd/rn5t618.c
> +++ b/drivers/mfd/rn5t618.c
> @@ -150,8 +150,7 @@ static const struct of_device_id rn5t618_of_match[] =
=3D {
>  };
>  MODULE_DEVICE_TABLE(of, rn5t618_of_match);
> =20
> -static int rn5t618_i2c_probe(struct i2c_client *i2c,
> -			     const struct i2c_device_id *id)
> +static int rn5t618_i2c_probe(struct i2c_client *i2c)
>  {
>  	const struct of_device_id *of_id;
>  	struct rn5t618 *priv;
> @@ -251,11 +250,6 @@ static int __maybe_unused rn5t618_i2c_resume(struct =
device *dev)
>  	return 0;
>  }
> =20
I added the pm stuff above ...


> -static const struct i2c_device_id rn5t618_i2c_id[] =3D {
> -	{ }
> -};
> -MODULE_DEVICE_TABLE(i2c, rn5t618_i2c_id);
> -

and below it in my RTC series.

>  static SIMPLE_DEV_PM_OPS(rn5t618_i2c_dev_pm_ops,
>  			rn5t618_i2c_suspend,
>  			rn5t618_i2c_resume);

Do you want to have it rebased so it can be applied first?
Sorry for the confusion here.

Regards,
Andreas

--Sig_/OBoX2dOW+n5S9UzDv+26TUn
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEPIWxmAFyOaBcwCpFl4jFM1s/ye8FAl4wgWQACgkQl4jFM1s/
ye9MeQ//QCP2dZEiG99itkv3sMCQiOL2zcduv7o9pHpP+ha+glSy6ueXj1XYOwFj
zhaU+cIOmVJXbyHXRyUY2V/Agr5CMrp0bS6+x99BLkBNkjCOBjdgQoLpDNQKbgr1
MIC53iPOIcil4wrUzP9X0egI/jrH3lPbHi5yXLj0DsoUPzfQGRMBWeyRDmmNiW3e
PkRuQZgVkCvVOHmIDD5pSwDk3WlPBzPLHAPolKCfvDkHQSCl/WIvCts8PPC5lYgQ
MGNAnYRP48F7QZxV4vemhbN5t6rIy0nW/YKx3Fkszmkp+oh9wDLb5x7NJ8tWWUcb
JeeJ0D5TnfhkC6srmlXe15RDeFtKfX2xoTqZBrUs3hs88iqA7Zs1+rDV+dorkL3V
YlLlDXGM21rVzF9LExzC8zrp2888c9FpF0LLKbJQIinNzxmHZyLipmK9Z7laTAvo
IFEJaIdiJ8CJFW33m6j8vdBnIYNWQCOhuI2toGnLbVXjw3A/kMpeLqCj/roqDeZ+
Y6peKO+JSZ4SWYUkMOTCriOzwUOyBWcVGKw6pBBP1yqIquFXAl5ti3FIsxOTzo7N
fLSfFi3SSfTN3/Eopupi/M93m0myrXrh7Ezt50rfCNl9EsxTR0yeWuC6LP9+88cU
mbG5qDtC8eZ9ZNEdnqRFc6xa7RV8EO8M5HNCVKaRJx/LF0GeKnI=
=EFa8
-----END PGP SIGNATURE-----

--Sig_/OBoX2dOW+n5S9UzDv+26TUn--