Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751066AbWBCQo1 (ORCPT ); Fri, 3 Feb 2006 11:44:27 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751210AbWBCQo1 (ORCPT ); Fri, 3 Feb 2006 11:44:27 -0500 Received: from uproxy.gmail.com ([66.249.92.192]:40975 "EHLO uproxy.gmail.com") by vger.kernel.org with ESMTP id S1751066AbWBCQo0 convert rfc822-to-8bit (ORCPT ); Fri, 3 Feb 2006 11:44:26 -0500 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=gM6OznYzN9KWR1tAj3ssjnEsOjT3wRrzNYZ6Qwl0uxKPPKTLuv/+OE5Gpt4a8FBvHFn0XTgLgFBCdLL2uMG/mo3pgAT4timSMKuDw2gEwiqpokvCw3Fq8Cr1V0HfzgEKAEKSj7qsDwk2dFPR8Rs7D8P7KQdHKB43CDGkWClq/Qs= Message-ID: <58cb370e0602030844v6af78df8w5716a5beae97ac0f@mail.gmail.com> Date: Fri, 3 Feb 2006 17:44:24 +0100 From: Bartlomiej Zolnierkiewicz To: "Randy.Dunlap" Subject: Re: [ 00/10] [Suspend2] Modules support. Cc: Matthew Garrett , Andrew Morton , Lee Revell , nigel@suspend2.net, torvalds@osdl.org, linux-kernel@vger.kernel.org, Pavel Machek , Shaohua Li In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Content-Disposition: inline References: <20060201113710.6320.68289.stgit@localhost.localdomain> <1138916079.15691.130.camel@mindpipe> <20060202142323.088a585c.akpm@osdl.org> <20060203105100.GD2830@elf.ucw.cz> <58cb370e0602030322u4c2c9f9bm21a38be6d35d2ea6@mail.gmail.com> <20060203113543.GA3056@elf.ucw.cz> <58cb370e0602030546q2ea4b70bq1dc66306d5ef1b12@mail.gmail.com> <58cb370e0602030632p2168fbeaga2a1089b1eea8dfc@mail.gmail.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2424 Lines: 53 On 2/3/06, Randy.Dunlap wrote: > On Fri, 3 Feb 2006, Bartlomiej Zolnierkiewicz wrote: > > > On 2/3/06, Matthew Garrett wrote: > > > Bartlomiej Zolnierkiewicz wrote: > > > > > > > This is untrue as Linux has support for setting IDE controller > > > > and drives. It was added by Benjamin Herrenschmidt in late > > > > 2.5.x or early 2.6.x (I don't remember exact kernel version). > > > > > > In generic_ide_resume, rqpm.pm_step gets set to > > > ide_pm_state_start_resume and ide_do_drive_cmd gets called. This ends up > > > being passed through to start_request. start_request waits for the BSY > > > bit to go away. On the affected hardware I've seen, this never happens > > > unless the ACPI calls are made. As far as I can tell, there's nothing in > > > the current driver code that does anything to make sure that the bus is > > > in a state to accept commands at this point - the pci drivers don't (for > > > the most part) seem to have any resume methods. Calling the ACPI _STM > > > method before attempting to do this magically makes everything work. > > > > I don't see anything that prevents addition of ->suspend and ->resume > > for IDE PCI host drivers (not IDE core issue) if some special sequence > > is needed. > > > > I see that we may be doing PIO/DMA setup too late (IDE core issue) > > for some controllers. > > > > Could you fill a bug at kernel bugzilla with data as much data about > > affected hardware as possible (dmesg, kernel config, lspci -vvv -xxx > > before susped and if possible PCI configuration dumped from kernel > > after suspend)? > > > > What is the current state of IDE ACPI patches? > > Were the issues raised on linux-ide addressed? > > I haven't seen any updates to the drivers/ide/ patch from > Shaohua Li . I'm beginning to work on > PATA ACPI object support that is similar to the current SATA ACPI > patches -- all for libata. Is this the right or wrong thing > to do? Working on patches is always right thing to do... 8) Just one remark: please try to make ACPI part as libata/SCSI independent as possible. Thanks, Bartlomiej - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/