Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp174318ybl; Tue, 28 Jan 2020 21:18:53 -0800 (PST) X-Google-Smtp-Source: APXvYqxEbCUIcfXJtu07GarHaw0wIbn+zolLWytQwu+Jy26NW4roQB68H/OEzFnVay8QwgMD03uT X-Received: by 2002:a9d:6e8f:: with SMTP id a15mr8673910otr.178.1580275133489; Tue, 28 Jan 2020 21:18:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580275133; cv=none; d=google.com; s=arc-20160816; b=UKzIi6G0aCmIy/f7dFY4Nk9dGvE1+ONjaKc0bl51z1U1F7Irmx/XVXsax2ykIFmGB2 4qCEAtNWDIoXLvfJQp/opT57wtXTP8X2gIYTtj1TkPYh8VW/B9eAyZ4o9aiKEl69p+Ru J5kYIVADHRg+iHdAxlceiVQdC2e68iYep9KaIeJnmOxGXWbfUX5bRSSK/dP6Br3777lD +fpgK5B4i7ydKb8bb79E2gUQ2RS3y92C79bS0PXT9qpKUqYbJoGYeqbNaRjBZRWokKa1 6qvFYD7CAJzco75h4ewUay5kaeBoH0hhc+si4mK+jOVPyIIDku80P3we6G4XOuHin+t7 OF6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:subject:cc:from:to :in-reply-to; bh=zxT6LIrZfmKKh9Zh/h2/r2IfW4KSoKxdyTHIaIVje18=; b=GxFzkhALZWMpMCdx3gJs096DLeQY9e6EuJG35xJZmmUXEDEgKnK2zwEfJp3H2NSTYe CPN7ZPVtiDZTWe1hZ0u3MJK4oMizgcbkt+pkMY9ouyITs6I/Ce4sznrtHYuKGIroTrQt ScTMP3z2xOF+sIJK5lE4UZnxuwKagYwki4eJYdTpQFhh51Cx5efxeNzuyGxB0twny393 lm4MHSHTbVcG+WFrHyrC05FhL8EJvbhnf7FCNEDEcWtGULf9gfr9aLJHzdW5tCHTxhPe kQJDkFnZUhQewRgX4AbyTJTUMgttBUXt6Mw2VsXkA0w0DBEjT0cUT9whX/UObE/iKoej GszQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d199si584597oib.135.2020.01.28.21.18.41; Tue, 28 Jan 2020 21:18:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726715AbgA2FRl (ORCPT + 99 others); Wed, 29 Jan 2020 00:17:41 -0500 Received: from ozlabs.org ([203.11.71.1]:59577 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726272AbgA2FRi (ORCPT ); Wed, 29 Jan 2020 00:17:38 -0500 Received: by ozlabs.org (Postfix, from userid 1034) id 486sDw3HcXz9sRR; Wed, 29 Jan 2020 16:17:36 +1100 (AEDT) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: d80ae83f1f932ab7af47b54d0d3bef4f4dba489f In-Reply-To: <0d894839fdbb19070f0e1e4140363be4f2bb62fc.1578989540.git.christophe.leroy@c-s.fr> To: Christophe Leroy , Benjamin Herrenschmidt , Paul Mackerras From: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] powerpc/ptdump: fix W+X verification Message-Id: <486sDw3HcXz9sRR@ozlabs.org> Date: Wed, 29 Jan 2020 16:17:36 +1100 (AEDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2020-01-14 at 08:13:09 UTC, Christophe Leroy wrote: > Verification cannot rely on simple bit checking because on some > platforms PAGE_RW is 0, checking that a page is not W means > checking that PAGE_RO is set instead of checking that PAGE_RW > is not set. > > Use pte helpers instead of checking bits. > > Signed-off-by: Christophe Leroy > Fixes: 453d87f6a8ae ("powerpc/mm: Warn if W+X pages found on boot") Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/d80ae83f1f932ab7af47b54d0d3bef4f4dba489f cheers