Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [Patch V3 12/18] usb: gadget: tegra-xudc: support multiple device
 modes
To:     Thierry Reding <thierry.reding@gmail.com>
CC:     <balbi@kernel.org>, <gregkh@linuxfoundation.org>,
        <jonathanh@nvidia.com>, <mark.rutland@arm.com>,
        <robh+dt@kernel.org>, <kishon@ti.com>,
        <devicetree@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
        <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <1577704195-2535-1-git-send-email-nkristam@nvidia.com>
 <1577704195-2535-13-git-send-email-nkristam@nvidia.com>
 <20200128181020.GJ2293590@ulmo>
From:   Nagarjuna Kristam <nkristam@nvidia.com>
Message-ID: <7478f53a-c236-5442-8abb-7531edb89b29@nvidia.com>
Date:   Wed, 29 Jan 2020 12:20:09 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.2
MIME-Version: 1.0
In-Reply-To: <20200128181020.GJ2293590@ulmo>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 28-01-2020 23:40, Thierry Reding wrote:
>>   	struct tegra_xudc_save_regs saved_regs;
>>   	bool suspended;
>>   	bool powergated;
>>   
>> -	struct usb_phy *usbphy;
>> +	struct usb_phy **usbphy;
>> +	int current_phy_index;
> Can be unsigned int. It's also very long. It might be better to choose a
> shorter name so that when you use it, the lines don't get excessively
> long. Alternatively you could keep this field name and instead declare
> local variables to reference the current PHY to make lines shorter.
> 
> Actually, looking at this a bit more, I don't see current_phy_index ever
> used by itself (other than the assignment and one check to see if a PHY
> has been selected). So why not just store a pointer to the current PHY
> and avoid all the dereferencing?
> 
> Thierry

current_phy_index main purpose is to quickly get which index for USB 2 
and 3 phy's to be used. This is used at mulitple functions. Based on 
your comment above, I believe its good to use 2 pointers for UTMI and 
USB 3 phy's, which are points to current phy index. This ensures to keep 
line length as less as possible.

Thanks,
Nagarjuna