Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Felipe Balbi <balbi@kernel.org>
To:     Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
        John Stultz <john.stultz@linaro.org>,
        lkml <linux-kernel@vger.kernel.org>
Cc:     Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com>,
        Yang Fei <fei.yang@intel.com>,
        Tejas Joglekar <Tejas.Joglekar@synopsys.com>,
        Andrzej Pietrasiewicz <andrzej.p@collabora.com>,
        Jack Pham <jackp@codeaurora.org>, Todd Kjos <tkjos@google.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        Linux USB List <linux-usb@vger.kernel.org>,
        stable <stable@vger.kernel.org>
Subject: Re: [PATCH v2] usb: dwc3: gadget: Check for IOC/LST bit in TRB->ctrl fields
In-Reply-To: <dfb83e3d-7e78-9568-6bed-f4ee67f90c69@synopsys.com>
References: <20200127193046.110258-1-john.stultz@linaro.org> <87sgjz90lt.fsf@kernel.org> <dfb83e3d-7e78-9568-6bed-f4ee67f90c69@synopsys.com>
Date:   Wed, 29 Jan 2020 09:16:19 +0200
Message-ID: <87pnf291h8.fsf@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha256; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Hi,

Thinh Nguyen <Thinh.Nguyen@synopsys.com> writes:
>> John Stultz <john.stultz@linaro.org> writes:
>>
>>> From: Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com>
>>>
>>> The current code in dwc3_gadget_ep_reclaim_completed_trb() will
>>> check for IOC/LST bit in the event->status and returns if
>>> IOC/LST bit is set. This logic doesn't work if multiple TRBs
>>> are queued per request and the IOC/LST bit is set on the last
>>> TRB of that request.
>>>
>>> Consider an example where a queued request has multiple queued
>>> TRBs and IOC/LST bit is set only for the last TRB. In this case,
>>> the core generates XferComplete/XferInProgress events only for
>>> the last TRB (since IOC/LST are set only for the last TRB). As
>>> per the logic in dwc3_gadget_ep_reclaim_completed_trb()
>>> event->status is checked for IOC/LST bit and returns on the
>>> first TRB. This leaves the remaining TRBs left unhandled.
>>>
>>> Similarly, if the gadget function enqueues an unaligned request
>>> with sglist already in it, it should fail the same way, since we
>>> will append another TRB to something that already uses more than
>>> one TRB.
>>>
>>> To aviod this, this patch changes the code to check for IOC/LST
>>> bits in TRB->ctrl instead.
>>>
>>> At a practical level, this patch resolves USB transfer stalls seen
>>> with adb on dwc3 based HiKey960 after functionfs gadget added
>>> scatter-gather support around v4.20.
>>>
>>> Cc: Felipe Balbi <balbi@kernel.org>
>>> Cc: Yang Fei <fei.yang@intel.com>
>>> Cc: Thinh Nguyen <thinhn@synopsys.com>
>>> Cc: Tejas Joglekar <tejas.joglekar@synopsys.com>
>>> Cc: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
>>> Cc: Jack Pham <jackp@codeaurora.org>
>>> Cc: Todd Kjos <tkjos@google.com>
>>> Cc: Greg KH <gregkh@linuxfoundation.org>
>>> Cc: Linux USB List <linux-usb@vger.kernel.org>
>>> Cc: stable <stable@vger.kernel.org>
>>> Tested-by: Tejas Joglekar <tejas.joglekar@synopsys.com>
>>> Reviewed-by: Thinh Nguyen <thinhn@synopsys.com>
>>> Signed-off-by: Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com>
>>> [jstultz: forward ported to mainline, reworded commit log, reworked
>>>   to only check trb->ctrl as suggested by Felipe]
>>> Signed-off-by: John Stultz <john.stultz@linaro.org>
>>> ---
>>> v2:
>>> * Rework to only check trb->ctrl as suggested by Felipe
>>> * Reword the commit message to include more of Felipe's assessment
>>> ---
>>>   drivers/usb/dwc3/gadget.c | 3 ++-
>>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
>>> index 154f3f3e8cff..9a085eee1ae3 100644
>>> --- a/drivers/usb/dwc3/gadget.c
>>> +++ b/drivers/usb/dwc3/gadget.c
>>> @@ -2420,7 +2420,8 @@ static int dwc3_gadget_ep_reclaim_completed_trb(s=
truct dwc3_ep *dep,
>>>   	if (event->status & DEPEVT_STATUS_SHORT && !chain)
>>>   		return 1;
>>>=20=20=20
>>> -	if (event->status & DEPEVT_STATUS_IOC)
>>> +	if ((trb->ctrl & DWC3_TRB_CTRL_IOC) ||
>>> +	    (trb->ctrl & DWC3_TRB_CTRL_LST))
>> why the LST bit here? It wasn't there before. In fact, we never set LST
>> in dwc3 anymore :-)
>
> Just a note: right now, it may be fine for non-stream endpoints to not=20
> set the LST bit in the TRBs. For streams, we need to set this bit so the=
=20
> controller know to allocate resource for different transfers of=20
> different streams. It may be fine now if you think that it should be=20
> added later when more fixes for streams are added, but I think it=20
> doesn't hurt checking it now either.

Indeed. Let's keep this version as is if we will need LST for Streams
anyway. Sorry for the noise.

=2D-=20
balbi

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAl4xMUMACgkQzL64meEa
mQbhSRAAzi4QoZAoRbTkaS3NxcozlZU32espqxd1R5TzPgRdpf1y6scYYelnAcEh
Atw+YNklKaM0zzska86g3NTeV0XEHJ0hZx1Is4j8Ze7Oad1azuNMjjLUAYBYqT1S
UfwVxTJGcbHGg+TDBDWucop/vzKNLv2gvRLv0f3z9ski0h/QC+/V9aCJt/Ke4N6Y
U719p3Ob7PcrLPU7lyOaG4LcyXrzYlqiFVx5wAAWC+wdZIqSp/XdsfZY59IHUajs
000vjcGg+ps+mCYYfUu/1SiFzO6bLqNuJXCeCjWoet1CV1SdSVDNt8NJW/N3df/N
GGyl0HTjhYB9+4o1cehc5c2PaYKpshavAXWzZeotqtzewFz17ojVHb0/bU55FYi9
fEqXMgB3ft4lsWY/QYeTZINVwRXN8FYJWj/+BhU1Si5ptjVKhLizuWxH0Pi9Xhwt
V23qFHAt69kWPnOBii7svXYFEY2vr8ORmeFIjAzOqPUl1WtArR0NvN49H+z7qgyG
l2s+ixpg+uHmExVPaCwXSJKgbTO4iK4xhTjKxLY+9yZRy6DMoi7CiY1DxjEy3+jW
7xCTjMYDOfVunOI7+8Awi32B/I10I139f5rO2TVdt9ZQHjErOEMVYPjm5OGXIkbp
XUvwGONBRPRDVKpzvvT8iF+kQp9FHp1T//JrgqBqvFKCe7egdNo=
=3kxu
-----END PGP SIGNATURE-----
--=-=-=--