Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp278084ybl; Tue, 28 Jan 2020 23:53:34 -0800 (PST) X-Google-Smtp-Source: APXvYqy2MC4s08nXoqGNCtiml7uG1d3vpxH7/rMEiCIHuw4hjPy0Fz0cWUt5irPT3l9PQyRm3TXC X-Received: by 2002:a9d:7652:: with SMTP id o18mr6213408otl.227.1580284414316; Tue, 28 Jan 2020 23:53:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580284414; cv=none; d=google.com; s=arc-20160816; b=CV/D60Kqqzaj6HXrN8L8V2h54YeU85tz2itBkNgoP2DHzHEwJRXLfjNo+n+IqaFLPW yXQVHk47sZ3C7N4nMBA/vltVt0FplufVWXkTMZjkTqPhEGQn1fwG+fQtT4BgJI7g3j7z P9WlXx57vhTaLpdGH+LXbgZcd66RG8d+RyyRL4wQk1Jzwsxrj09tddgNt2+nqNU6XE/w cOweodpt49A6/3IDxJTwckd2MfkVR3AFaq4N+Ohl/USdhFKaf54Tf7q9pHSPjef3pTSr zQvPuci63l5isa+sytxurWI4/DCuijFknURLSMO0KwiKJQhKuI6lYUPF8WhAJ0LNa/bQ 9USQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=stY7heRBlmOzPekn/8fIQhMjdFAkQiD8FA6E5t+VudY=; b=j6wOpXOUIljE/4OR67t93CTKHYKGqoQKzmGf9j2dCe1yg5aPfU8f1m+TLaqbBCPSe8 8T6pxLOzg91cBuloEjxn7ZkG1ytyAOGHMqgDaNpHzGWWvfUbi/nKgRsleSQqPSh68L0f t5yNbEFM63C+bnJf3MtHoLK5UDAKAZxMWY95M2KdLcmFX7wJjhsg5KbZnN+DZs8IVB0d 7VcAKGzSOjoxZAFwqXl8+PROR700v8pHwQc0NYnUvbBoS7foWnzh/ph6xlk8pozQ5yeV sn5bkOVhYznFyvYlKZ9WyEluT40lMAyBqVylO69ZdWHrZ1Ifpga09CgAnwM8PWvPeCsY Ia0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zpEMqlQP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g9si779636otq.68.2020.01.28.23.53.21; Tue, 28 Jan 2020 23:53:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zpEMqlQP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726171AbgA2Hwa (ORCPT + 99 others); Wed, 29 Jan 2020 02:52:30 -0500 Received: from mail.kernel.org ([198.145.29.99]:48828 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726068AbgA2Hw3 (ORCPT ); Wed, 29 Jan 2020 02:52:29 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0F142206A2; Wed, 29 Jan 2020 07:52:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580284349; bh=E2gB8/IVYfzCG8u8xgT7bImHIwd51ldFMW6eqcDAvb8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zpEMqlQPSjBfOuVeijexexAZ9NASLTff4lkKWYeLMj2eifuhCGX5PwFMaGR4y2CPN aNlRnZ8y5WAxFXJQmoS8HZhO5grNJvzsU56p4fNU+DUnOLNCh9A3WQD/SoO3wpnvp9 VBG3y7lR3zfoDKkVTGQNRu7/EgeGh3GV1ySWfaZs= Date: Wed, 29 Jan 2020 08:52:25 +0100 From: Greg KH To: Stanley Chu Cc: linux-scsi@vger.kernel.org, martin.petersen@oracle.com, avri.altman@wdc.com, alim.akhtar@samsung.com, jejb@linux.ibm.com, beanhuo@micron.com, asutoshd@codeaurora.org, cang@codeaurora.org, matthias.bgg@gmail.com, bvanassche@acm.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kuohong.wang@mediatek.com, peter.wang@mediatek.com, chun-hung.wu@mediatek.com, andy.teng@mediatek.com, stable@vger.kernel.org Subject: Re: [PATCH v3 3/4] scsi: ufs: fix Auto-Hibern8 error detection Message-ID: <20200129075225.GA3774452@kroah.com> References: <20200129073902.5786-1-stanley.chu@mediatek.com> <20200129073902.5786-4-stanley.chu@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200129073902.5786-4-stanley.chu@mediatek.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 29, 2020 at 03:39:01PM +0800, Stanley Chu wrote: > Auto-Hibern8 may be disabled by some vendors or sysfs > in runtime even if Auto-Hibern8 capability is supported > by host. If Auto-Hibern8 capability is supported by host > but not actually enabled, Auto-Hibern8 error shall not happen. > > To fix this, provide a way to detect if Auto-Hibern8 is > actually enabled first, and bypass Auto-Hibern8 disabling > case in ufshcd_is_auto_hibern8_error(). > > Fixes: 8217444 ("scsi: ufs: Add error-handling of Auto-Hibernate") This should be: Fixes: 821744403913 ("scsi: ufs: Add error-handling of Auto-Hibernate")