Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
From:   Qian Cai <cai@lca.pw>
Mime-Version: 1.0 (1.0)
Subject: Re: [PATCH -next] mm/page_counter: mark intentional data races
Date:   Wed, 29 Jan 2020 04:33:03 -0500
Message-Id: <DE8391CD-A9CF-4D16-A41B-F563F2AE8D57@lca.pw>
References: <CANpmjNNaCtL+vqpPKug9_DoFUue=PdoTyQFXLOx5H_BYCyDMzA@mail.gmail.com>
Cc:     Michal Hocko <mhocko@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Linux Memory Management List <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>
In-Reply-To: <CANpmjNNaCtL+vqpPKug9_DoFUue=PdoTyQFXLOx5H_BYCyDMzA@mail.gmail.com>
To:     Marco Elver <elver@google.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> On Jan 29, 2020, at 4:06 AM, Marco Elver <elver@google.com> wrote:
>=20
> Why are the line numbers for the remaining symbols missing?  Doesn't
> scripts/decode_stacktrace.sh give you all line numbers?

I used scripts/faddr2line and never used decode_stacktrace.sh before. I did n=
ot insert other line numbers because it can be easily determined by looking a=
t the function itself through an code browser.

>=20
> [ As an aside: if you want to use what syzbot uses to put line numbers
> on symbols, which is a bit faster:
> https://github.com/google/syzkaller/tree/master/tools/syz-symbolize
> https://github.com/google/syzkaller/blob/master/docs/linux/setup.md
> then 'go build tools/syz-symbolize'. ]

That is good to know.=