Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp493257ybl; Wed, 29 Jan 2020 04:26:59 -0800 (PST) X-Google-Smtp-Source: APXvYqwaEld/NqKqhy5jTkex4J3qppvD21ofVkmD/BytbzVwNrdPUckqGwKiTIBJX4OUJHumy/9D X-Received: by 2002:aca:50cd:: with SMTP id e196mr6158155oib.178.1580300819352; Wed, 29 Jan 2020 04:26:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580300819; cv=none; d=google.com; s=arc-20160816; b=slJzOzTqI6ZQRmS4S/fMHdw/eAHxqDia3I/qMWUxLn4kddWSmgtw+mrpf/nePmkNDn zYKZlGWZt3h2GW1Jc82y70Cjrtrymh7Sv2NFRkUoN+8ksmgJYL5OF43bGkftkN9G5tFj dIJPcd1mlK2iRWCnHTrh/wf4DlO9L4/IXD4q27QgSyT5l+68zv8IHqtqM+g0A7j2I6Eh WDfa8yYcwnJaPDa3yddrBxhsH7bHyv/7rgNgZfQnTUZDBdI5VdWQg/2ljpRMBf+Kyc5o o50iC75Bc8GS2qmtdbuE3bUMARA3SdawzEjFDInAzQL0vZyAvzX29Can3dh5rv8SVWST Gy7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:in-reply-to:cc:references:message-id :date:subject:mime-version:from:content-transfer-encoding :dkim-signature; bh=P5Dt2dH1joRUG7g3rFIqA/IEm4rCryr2l+IoRrIYc+k=; b=wFFNdTdtCoGl1CFWqe6P4ZNAOUtConFdu7F06JcO6siXt50aVQcSV9aMpmooQDX5Jx to7LMWrnhAVxrxQm/wqoGwpZC1E4WJxWBFlnV5PJu9bW6xmaPSJAz+yAajy3zlZm0Hq5 5dBI5fss/emi/hR0sto4a6ymtMdqd1WrGIgOwmFml0tWjVp5L6DtlQmI/lBlJOpQ0/Bn VBrhn+5oWy9O8WyFgus8enld41GGvUPIc437l5FYQB/zqgbxeOIXZDmclcPMKWsKt0Ts JfcUM/KfmRaJsT5GDs+52f9Xnjkz45EGhZs47Mhz5fO22+FMS2B9E/tmv0cBOsc01bCx BNgA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lca.pw header.s=google header.b=fZa691zx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n14si937504otk.179.2020.01.29.04.26.46; Wed, 29 Jan 2020 04:26:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@lca.pw header.s=google header.b=fZa691zx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726620AbgA2MZn (ORCPT + 99 others); Wed, 29 Jan 2020 07:25:43 -0500 Received: from mail-qt1-f194.google.com ([209.85.160.194]:36241 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726385AbgA2MZn (ORCPT ); Wed, 29 Jan 2020 07:25:43 -0500 Received: by mail-qt1-f194.google.com with SMTP id t13so12627472qto.3 for ; Wed, 29 Jan 2020 04:25:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=content-transfer-encoding:from:mime-version:subject:date:message-id :references:cc:in-reply-to:to; bh=P5Dt2dH1joRUG7g3rFIqA/IEm4rCryr2l+IoRrIYc+k=; b=fZa691zxlM8/PJTWvAjVvOyAIwK0md/9eQKUpY4fOIYint3eJHeyBeSS58Qf9ho0yV 4DD5NH38GD8PIaL46eBZMhdoUjPenGjLpIzHQDZfIYIP3b7YgYviRGtUqGJ7xsDUS8OU WdGIYnMT9NDRGVS+VO2AQa/6qHJzdcqSjHZOCeTW1y1Y1Sd1M8patjPq78Xtea/rfJTR RNa8Utyx4i/HcZz0CDl+eV2X049QsTBi7HHh+WTjOO2+++dj1ftGukMOPCfy6q1j/wzf /3cj5skE+bh3gvQZRLRk6z6zaGJqYsbLMfFSUZF6HwpnKAGQft4Rnmx5W4v5eK/mO+Gx p+iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=P5Dt2dH1joRUG7g3rFIqA/IEm4rCryr2l+IoRrIYc+k=; b=iYL0e7fV6xepiHXHdU72dFMvkrR2S/dzZGj5qufgYzItrWa/9Q3hQECM9jKBbHapBG 4Ge826ozKsREKqEpCn53ArfBaawiLZUHhGtxPF/Jf95zPVUgtF6oTbOHkM1Io+KE/zig nO4lFdzbBgbldC9mYy+3qKqbZaU7trX3nNxCVMupcaPHIYUulNqsxvepNhipHnxs56ik 4jn/woIfq9e97Sain6Shvwz+KCjSoeJ9iuehnKCOF2CV1PdiLFTIWkmhmzBfDGQaSk7y G3Dm5X6llGr83V2gpO4YX7oCpRB1GhXcsmkbcau4LQy8ROatvNxdPazmbuyP0ZyJiJP0 WTDQ== X-Gm-Message-State: APjAAAWZAHifvYEYX9CPMl76hEPMsgGPhaako3zr47lWfQoUFNHQ9TR2 S0RPXkFssev8MIauGXC98quHFK5zZGmVlg== X-Received: by 2002:aed:2050:: with SMTP id 74mr26490917qta.217.1580300740519; Wed, 29 Jan 2020 04:25:40 -0800 (PST) Received: from [192.168.1.183] (pool-71-184-117-43.bstnma.fios.verizon.net. [71.184.117.43]) by smtp.gmail.com with ESMTPSA id r185sm875146qke.102.2020.01.29.04.25.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jan 2020 04:25:39 -0800 (PST) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Qian Cai Mime-Version: 1.0 (1.0) Subject: Re: [PATCH] mm/page_counter: fix various data races Date: Wed, 29 Jan 2020 07:25:39 -0500 Message-Id: <2D795DB7-66FE-4F01-872F-F8ACAE9505EF@lca.pw> References: <59f892d0-5fc4-ae32-ce65-5a688d9180c8@I-love.SAKURA.ne.jp> Cc: Dmitry Vyukov , Michal Hocko , akpm@linux-foundation.org, hannes@cmpxchg.org, elver@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org In-Reply-To: <59f892d0-5fc4-ae32-ce65-5a688d9180c8@I-love.SAKURA.ne.jp> To: Tetsuo Handa X-Mailer: iPhone Mail (17C54) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Jan 29, 2020, at 7:13 AM, Tetsuo Handa wrote: >=20 > By the way, can READ_ONCE()/WRITE_ONCE() really solve this warning? > The link above says read/write on the same location ( mm/page_counter.c:12= 9 ). > I don't know how READ_ONCE()/WRITE_ONCE() can solve the race. That looks like a different one where it complains about c->failcnt++. I=E2=80= =99ll send a separate patch for that.=