Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp547277ybl; Wed, 29 Jan 2020 05:27:09 -0800 (PST) X-Google-Smtp-Source: APXvYqyhdY72ZvoYmW67OsMlGxKDXi9HmyLz8eSQYYoDbeJouvczsaXV8Brc2mXL9yDQKl+v0JCO X-Received: by 2002:aca:2312:: with SMTP id e18mr1881093oie.34.1580304429204; Wed, 29 Jan 2020 05:27:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580304429; cv=none; d=google.com; s=arc-20160816; b=hPANgh+Tba6a8TWRG4nJgz/TXahkEcB+H+QEO5IPYQBFLu7p4jb9v4Fmo++iM5Xroz wN12qLpGYdgnu8X0lh0E1zYvWIbKV1iB/B4sBkfCPlWb5rVHPEDYKNkEKhNr5uy9Cymp NWjGToTR2CffHTkuM9KokG4rVr9bmOsLHrJWCo9x7vZycj8hULDgpoV8pxARWzDD8GOn ulFKwkW3b1qYYE8MZ/RgzSPm3pfC5zqmlzBot9BkPuLH3O+7p3Ky9lCo0hegd3kA16SZ rboAMLs9ojt4f5WXvl+os60iIWRRo5A/cdBrdBWtFyBt/9w+HIlxD7JODuQ6TOhtC3c5 /uIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=tmJm9BfPEYluCIDrkzNzLmlYhV6ByPX8X5POs9hOKzA=; b=T2sVoWZuuHtFlwaCdcPpBpa8Rg4ISb0SfnZtR2QYtMfKewQGWWM7iDljURjB5yHN9O 56OObr89tKcprrdjZNMiU4WH5XOG7HvDz3HMTLs1MWbAtgzXI/m2Ente1NeVFMfrczk3 TapCDCCiOCmUq8Vl4XzhGVyHqairRldV7YE8GKwaUe43FOtKAA2X63Ju+zziRtAxX/lb Q7bUWXoDcCbmAjpiF6JhyVp/9iKzEz/b7X0N1jmtzv+w7r6rc4ti6uSPOJ0fnIuozQkj Xb4bAroGYi2SqnxXL4bzDXhRQ1QwtZ/xzevkufadpvpLl/3BT3ZXamfqXEYpEZhYLGGs SfNA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r14si976853oic.12.2020.01.29.05.26.56; Wed, 29 Jan 2020 05:27:09 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726591AbgA2NZt (ORCPT + 99 others); Wed, 29 Jan 2020 08:25:49 -0500 Received: from mx2.suse.de ([195.135.220.15]:53220 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726140AbgA2NZs (ORCPT ); Wed, 29 Jan 2020 08:25:48 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id A5101AC46; Wed, 29 Jan 2020 13:25:46 +0000 (UTC) Date: Wed, 29 Jan 2020 14:25:41 +0100 From: Michal =?iso-8859-1?Q?Koutn=FD?= To: Christian Brauner Cc: linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, Tejun Heo , Oleg Nesterov , Li Zefan , Johannes Weiner , cgroups@vger.kernel.org Subject: Re: [PATCH v5 1/6] cgroup: unify attach permission checking Message-ID: <20200129132540.GA11384@blackbody.suse.cz> References: <20200121154844.411-1-christian.brauner@ubuntu.com> <20200121154844.411-2-christian.brauner@ubuntu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200121154844.411-2-christian.brauner@ubuntu.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 21, 2020 at 04:48:39PM +0100, Christian Brauner wrote: > +static int cgroup_attach_permissions(struct cgroup *src_cgrp, > + struct cgroup *dst_cgrp, > + struct super_block *sb, bool thread) I suggest inverting the logic of the last argument to make it consistent with other functions that use threadgroup argument for similar distinction. Apart from that Acked-by: Michal Koutn?