Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp559695ybl; Wed, 29 Jan 2020 05:40:27 -0800 (PST) X-Google-Smtp-Source: APXvYqx6sU9kK3H9UZcexkxOJrQU6inuRFZUHHXK1CTOA8yQoh3SLexTxFTIQrF6nsCcXJWjcM88 X-Received: by 2002:aca:6542:: with SMTP id j2mr6457382oiw.69.1580305226991; Wed, 29 Jan 2020 05:40:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580305226; cv=none; d=google.com; s=arc-20160816; b=cQB19+rniAqbY/bbeyGTAAzldGYplSXUMMcamJ85hGqj809vHG+RKmIncvfDCSb2ta 0SqD5/xlq6cX60ZmLqgpYTXc1PqPXZMiiU1QUvu0nNnJ6EpK5TG+onFVO23HZq7kpwUy 28Wh2FDeekX2MhzZuCN0v5zv7fluz0uWN6XDyk6h2hpAUKk70kJfpP6zuHX7XV0atoOj +h/V9eSgCr+4dX/jeFaz81MGfasPd7lKW3sAkxui9Mhcg5/wKcVCrOe22HwiLjex6QGv GE9CSBSl43QgWAy4qB/QyQ8eb3edHQ/Z+3ke3fk8svAbDwh+tqYuPK5kKjJRoEaCd/3j 2kbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:dkim-signature; bh=jRw4gHj3o+0fDg3wZL+MId/7a4nIQ2wDAMiYdbQUCIE=; b=UvlSw9pKBBeLY7Fg7A0gD3E6rpnJoc1k3ls+qQuzlOCux3HhZu1rFv5pkZ/HCTMdQ2 aNcWIl+qz2C5Vs/tV/Cz9+EX7X8zCFxjq8m4hx3eJJTGJddRHwqqYH30DjzCQyEbRVpR 5PeewRcpg/K3rFSGVdmvpdlTZtNirTIAnCR8mLQ59I4f451aQ9Ky3jwpPxSpKvHqiVJy FfcQiEbcdQJPUlDpCgPnOoe+cDBu8ppwxNAuwkY+We+VmfnUsWA2dVHBGW7QW3OUlkP2 LtvFsGC9YTDUICg/cm95CyWgMmTFShH1ZuUpbUAYPqf9eyLvxrqsGDXOzAIqzRhnvfA3 Cy6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=MNWayklz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a9si1075764oib.59.2020.01.29.05.40.14; Wed, 29 Jan 2020 05:40:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=MNWayklz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726271AbgA2NjT (ORCPT + 99 others); Wed, 29 Jan 2020 08:39:19 -0500 Received: from mail-pj1-f42.google.com ([209.85.216.42]:37416 "EHLO mail-pj1-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726177AbgA2NjT (ORCPT ); Wed, 29 Jan 2020 08:39:19 -0500 Received: by mail-pj1-f42.google.com with SMTP id m13so2664353pjb.2 for ; Wed, 29 Jan 2020 05:39:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=jRw4gHj3o+0fDg3wZL+MId/7a4nIQ2wDAMiYdbQUCIE=; b=MNWayklz5DOaPLQuHOF6vvFj3L/UpWZ8cJxmLJMaJ2B3hV7J4/9PyCQIcZCUniepHJ BC0JgUyyh2JTo+rYIfijyJo2csqrMSk1NgZBZKNj4JoFSTpCCSnmwXp9hTjd+enGGYYu dqkx50Nhvd9ugjHLtwOvHFXIyfMxuo4IIZXDTX3odQaI4VhjtqQ0KDXjmpOIgQI0s3hr xAA2Ua3U6sFfwiAYFP5TCXJaRWNEfK66QIqkG5sJ8mWFZaC+q0zLWJ9jTDKzIu6P2dQd 3iqpEuVIMD13B9AWJ3jDbkj6Jl8DUhBR49cpjtsK2RCtSD+xdC3tcuaZn6yy6Rmb6xzQ ExQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jRw4gHj3o+0fDg3wZL+MId/7a4nIQ2wDAMiYdbQUCIE=; b=Z+3MQL30YsagA9rIOVtsE8qPY4X3Er6rjj4GPD8ihbwrP89U8hpa7XMwf3tPcBIcTe 87hOBdrk8gil0fgp16DPoyY6Ha+dw+4QxzdoOPpECeCJJebzEqPRj3jDRrahZjJlt3ki Jd0VsCsyrdkRTB8Jxg4QSvIMuVeGCP74jv+XG3YObQWenYH8jNNnAp2lrfbz7duQXyL0 5I5+Se7GZzxuQ6/2vMUUnSSm4Im+F1afCiRZDA9DvbvmEQonzbpH+nKmn5Gi5MZ/2O8w 73UIdaQ+HOJe1f+3L2TZY5Y85P0Nai3PDQQ089LI9M2CsuS8954md/Rm6B6MGKMzo4MZ bKTA== X-Gm-Message-State: APjAAAU2+2Gd7h4aOsLcSKoSf9ZYMzg8Kbr5JS+xc2bHNFUtyG7O6Okk bbnjRqlBbHOzP/pY8lIQXdGriU5Ewv4= X-Received: by 2002:a17:90a:c708:: with SMTP id o8mr11397427pjt.104.1580305157936; Wed, 29 Jan 2020 05:39:17 -0800 (PST) Received: from [192.168.1.188] ([66.219.217.145]) by smtp.gmail.com with ESMTPSA id i68sm2972265pfe.173.2020.01.29.05.39.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jan 2020 05:39:17 -0800 (PST) Subject: Re: [PATCH] io-wq: use put instead of revert creds To: Pavel Begunkov , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org References: From: Jens Axboe Message-ID: <044f452e-76ab-c555-9dce-3c7a711d3c5e@kernel.dk> Date: Wed, 29 Jan 2020 06:39:16 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/29/20 3:10 AM, Pavel Begunkov wrote: > There is no need to publish creds twice in io_wq_switch_creds() (in > revert_creds() and override_creds()). Just do override_creds() and > put_creds() if needed. Thanks, looks good. Applied. -- Jens Axboe