Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
Date:   Wed, 29 Jan 2020 21:37:52 +0530
To:     Michal =?iso-8859-1?Q?Koutn=FD?= <mkoutny@suse.com>
Cc:     madhuparnabhowmik10@gmail.com, tj@kernel.org, lizefan@huawei.com,
        cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
        joel@joelfernandes.org, rcu@vger.kernel.org, frextrite@gmail.com
Subject: Re: [PATCH] cgroup.c: Use built-in RCU list checking
Message-ID: <20200129160752.GA15913@madhuparna-HP-Notebook>
References: <20200118031051.28776-1-madhuparnabhowmik10@gmail.com>
 <20200129142255.GE11384@blackbody.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200129142255.GE11384@blackbody.suse.cz>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Jan 29, 2020 at 03:22:55PM +0100, Michal Koutn? wrote:
> Hello.
> 
> On Sat, Jan 18, 2020 at 08:40:51AM +0530, madhuparnabhowmik10@gmail.com wrote:
> > From: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
> > 
> > list_for_each_entry_rcu has built-in RCU and lock checking.
> > Pass cond argument to list_for_each_entry_rcu() to silence
> > false lockdep warning when  CONFIG_PROVE_RCU_LIST is enabled
> > by default.
> I assume if you've seen the RCU warning, you haven't seen the warning
> from cgroup_assert_mutex_or_rcu_locked() above. 
>
No, I haven't seen any warning from cgroup_assert_mutex_or_rcu_locked(),
I am just doing the conversions to prevent any false lockdep warnings
because of CONFIG_PROVE_RCU_LIST in the future.

> The patch makes sense to me from the consistency POV.
> 
Thank you,
Madhuparna

> Acked-by: Michal Koutn? <mkoutny@suse.com>
> 
> Michal