Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp718454ybl; Wed, 29 Jan 2020 08:30:11 -0800 (PST) X-Google-Smtp-Source: APXvYqxWS/Gk278eEl+7WdZX1MbmwuXOHVZmAZH/XCLYMA1vJx86GwSOozIIbPEaTVgAmW1FiLEi X-Received: by 2002:a05:6830:22ee:: with SMTP id t14mr65891otc.236.1580315411493; Wed, 29 Jan 2020 08:30:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580315411; cv=none; d=google.com; s=arc-20160816; b=XMpT6knmvpkcqo0q3xw+Wpxd4BvGjq30kWDrNbZ4g4FVQcluomVauxtvF1EYAcUUHu JcMiKJ4X5qgDCLcRgF6rb+e7uzL/5mqO9NbZwzHYy42+jzUZBjbMaTTCTBK8Z3uCeKCM 3u7Re2cPnlUZKteFxSlo13U8UlALzvS+Nh8o0yt3SjlGTQEFos8kg1nVFrn23fEiqFIm c4bDfRCYAoUpUoAWA0nkpTxOjokV5e42qe18pHRg0mfwaaRHk4V+1QqqleckWtVeBuY5 DxwJ/0PjunpvuMkkWep5lUQynm0w50COQBhjFXaYpci032Q/IuygEjjoNkm9ODW6O2Kf F3eA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=2w+XND7PBGeesb5X+LaSnTAVC7q/SmsQ7bhG7hGGu3k=; b=TxVPZ7+M3FOTpq1BYRMA89aTrtkRRmfF5TtjkZN1HvcrrGGoKvvIgqAtxQdXfKTOgX LqHIJYjP6vFsYPSR52oAa+wL1STe24PD9KnBBDnz/C72Jq/t1hrB7IP0yO0yJlDLBIQf KO7KO7O4vnUi3x9w9Iqbns+p2h77jMCeKSjEjjOWbYATHIvAOOKcGWL2RPnhwK3SwDgm l+UOaSZq28iG2kvIyg7SgD9ISKGpWL6DA1MfNOktPWbHVx9lhXH0/sRMM7BsoqrI1UMp uWuX2uMDwrHFUlfV9DgrQhSDqqGGVOUkNeHYOOvuLqsRHeG8607Dkmypc2w3H7l5ZeZz KrBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=c7W8xJl3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y12si1298117oti.162.2020.01.29.08.29.59; Wed, 29 Jan 2020 08:30:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=c7W8xJl3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727036AbgA2QJQ (ORCPT + 99 others); Wed, 29 Jan 2020 11:09:16 -0500 Received: from mail-pl1-f194.google.com ([209.85.214.194]:36447 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726564AbgA2QJQ (ORCPT ); Wed, 29 Jan 2020 11:09:16 -0500 Received: by mail-pl1-f194.google.com with SMTP id a6so112742plm.3 for ; Wed, 29 Jan 2020 08:09:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2w+XND7PBGeesb5X+LaSnTAVC7q/SmsQ7bhG7hGGu3k=; b=c7W8xJl31owTz1Yx+RJ0t0lJeWMHmojPOvI9FTa0hToQ9rjk61F9cJpECaP8EbV9jV WRZWrG5hZ7ErbuZZDvb4Z2ar70aqpQH+u6FO0iuWYBi7MWWnFPiRRLuaAnpssV+DyGNN MisbUq3yuk+p3LM/1fKZ+8GjZEWkz7BLcGV8HFs/oPmu3w8rA+kTmif0eg8BeaZU0AuK cEO1sVF3TrYI7hjmzlHWu4qdxcwtEn6XUo4TH+0B33NSGwu2HBe9wer6Pfz1830NTLdq erOkBytkQCIlCU8kECVoDaG7m+JHQrcGcj1Tgu21IsrQnesl0MMlbNHzSs20osvTKgHn Ahqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2w+XND7PBGeesb5X+LaSnTAVC7q/SmsQ7bhG7hGGu3k=; b=B6oWT3x/5lTTjzuHs8PEIBpJCPo/8oiL36K2UsHpjTzg7G6y1eZC5HnQU9nPi+9vww +fqSlDjeCTzr/s65D0sKNoGF6icUFgcPEkjtQCk8yfZBhwcNw3f8cyqY55BmSJlwUtZQ jp8+gEWj8CnyIBOITKXxqNSRhSi4HE2vE7eX1knhue0lA3w3gyJsQn3+sXXB/frV1KDW YHPKjFcu3i5hBhL+SBFLBozdBQVs0M8q6TmxdQl/1JgYUobQIq7HW6BQsHedO/OEQdue Uh7zfDQZkF3kCciA2wL8C/o+J6BtIsYY7vdpRAWwNRWsszHkfH1NnjwiScAWHcuBC+3D qu9A== X-Gm-Message-State: APjAAAUS/9IFmAMh1zh1KFW5CGfPWIIJW5DpDE+S7xpLn0R+qN4TmyKe e6RL7l4aWMNstAERqJtzkRw= X-Received: by 2002:a17:90a:9f04:: with SMTP id n4mr363732pjp.76.1580314155804; Wed, 29 Jan 2020 08:09:15 -0800 (PST) Received: from localhost.localdomain ([146.196.37.139]) by smtp.googlemail.com with ESMTPSA id 73sm3258801pgc.13.2020.01.29.08.09.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jan 2020 08:09:15 -0800 (PST) From: Amol Grover To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim Cc: linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, Joel Fernandes , Madhuparna Bhowmik , "Paul E . McKenney" , Amol Grover Subject: [PATCH 2/2] events: callchain: Use RCU API to access RCU pointer Date: Wed, 29 Jan 2020 21:38:13 +0530 Message-Id: <20200129160813.14263-2-frextrite@gmail.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200129160813.14263-1-frextrite@gmail.com> References: <20200129160813.14263-1-frextrite@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org callchain_cpus_entries is annotated as an RCU pointer. Hence rcu_dereference_protected or similar RCU API is required to dereference the pointer. This fixes the following sparse warning kernel/events/callchain.c:65:17: warning: incorrect type in assignment Signed-off-by: Amol Grover --- kernel/events/callchain.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/events/callchain.c b/kernel/events/callchain.c index f91e1f41d25d..a672d02a1b3a 100644 --- a/kernel/events/callchain.c +++ b/kernel/events/callchain.c @@ -62,7 +62,8 @@ static void release_callchain_buffers(void) { struct callchain_cpus_entries *entries; - entries = callchain_cpus_entries; + entries = rcu_dereference_protected(callchain_cpus_entries, + lockdep_is_held(&callchain_mutex)); RCU_INIT_POINTER(callchain_cpus_entries, NULL); call_rcu(&entries->rcu_head, release_callchain_buffers_rcu); } -- 2.24.1