Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp836968ybl; Wed, 29 Jan 2020 10:29:24 -0800 (PST) X-Google-Smtp-Source: APXvYqwCr/R0DDC6XKIBuYBpbRcnSJvf8+aVc/C8oHuVlINiaxGxiWQj+8dSw18K6b3E6WaQ1Ghb X-Received: by 2002:a05:6830:1116:: with SMTP id w22mr477749otq.63.1580322564469; Wed, 29 Jan 2020 10:29:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580322564; cv=none; d=google.com; s=arc-20160816; b=kRt5YpogF66513T7BM7J6jFAsdbD1CgtAXUsqSo1pMnh6jlEdP26JWRP72RevV5gTf 7+EFTPdOd4NJR+vA2Sb3r66v/hJ0V/ompPi7EwlTtaJshlVI1HxeqXZEbbtW3jsdAdgX jlqXC8YzAebZWHJfRDqjJHxBLepKV8cLuKPrng/iZUdFKoTBbX+p9Bk6oAV6OYrI6gDs NBy6H5MckkEk2toG2XehLZjt5ajtXX0BDbFPuwlGZ2EAA4NwHwL4469tbrPp1er+OaVU R326MFz1HWRAFFU/fe6UN9GboIaXqnWmiOfQMa6F1aw8S+toh/p1O9w2lz0xeflpVN2T Wjmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=mV4tnlJ5Nbgnk7MtEoDSS+2cw1vXnoaSLleGiO8Edao=; b=t4gSnY4TrkPfy4cVv+Ezzf/CFKYF8/Gxwd8g3YH5Jx+3jf+WjeIpFiedxfcfklHkuN FlJhL2Uxo+61hnbL8RlPKrr/aKlgUkoqtCFS3zkZE1QjivXFUUO705uRXv+2C5fc/CgY Li7BBJl4eoekfxzkAdz3+oWRjQxO1jnJkRMdSmUspuJWVRiGBbt3gH9BmDFsinBpSGZr XCTmoVKjDIxGPLM/VyY7g17vNJNcKWcNHNSfFklJQKrCZyQsj2+eogxaf0n4fnVnMTSZ Zah/t+yJ6QVqHwwkBb+rrtbNokWTBd27yXtZt2YYGoPcXfKBb8/Ii7gVypHvACvL9EHE PVSg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j71si1340233oib.213.2020.01.29.10.29.11; Wed, 29 Jan 2020 10:29:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726751AbgA2S0y (ORCPT + 99 others); Wed, 29 Jan 2020 13:26:54 -0500 Received: from mx2.suse.de ([195.135.220.15]:46012 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726328AbgA2S0x (ORCPT ); Wed, 29 Jan 2020 13:26:53 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 71429B1EC; Wed, 29 Jan 2020 18:26:52 +0000 (UTC) From: Davidlohr Bueso To: oneukum@suse.com Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, dave@stgolabs.net, Davidlohr Bueso Subject: [PATCH] usbnet: optimize barrier usage for Rmw atomic bitops Date: Wed, 29 Jan 2020 10:16:46 -0800 Message-Id: <20200129181646.25487-1-dave@stgolabs.net> X-Mailer: git-send-email 2.16.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use smp_mb__before_atomic() instead of smp_mb() and avoid the unnecessary barrier for non LL/SC architectures, such as x86. Signed-off-by: Davidlohr Bueso --- drivers/net/usb/usbnet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c index 5ec97def3513..24c767350e5e 100644 --- a/drivers/net/usb/usbnet.c +++ b/drivers/net/usb/usbnet.c @@ -1912,7 +1912,7 @@ int usbnet_resume (struct usb_interface *intf) } } - smp_mb(); + smp_mb__before_atomic(); clear_bit(EVENT_DEV_ASLEEP, &dev->flags); spin_unlock_irq(&dev->txq.lock); -- 2.16.4