Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp853665ybl; Wed, 29 Jan 2020 10:47:28 -0800 (PST) X-Google-Smtp-Source: APXvYqyqoax+NoDDnBAOHLBNElk+6Mfwtgf0WV6UywhXGuSnsIC15joctEWa7GyLiPHqQ1hWMwHw X-Received: by 2002:a05:6808:b15:: with SMTP id s21mr196660oij.123.1580323648399; Wed, 29 Jan 2020 10:47:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580323648; cv=none; d=google.com; s=arc-20160816; b=aeL2N+s5MKR9EIXieUWHFGy6YQyeANtZU0IIrAuCUEjn5SBnASv/ia75c2429Ob9Fb zz8S7EE1jkN1uGMJkg+DX56QO4bmJkAaMCJa2kv0nT1GHlohAUn8TsibtQiRYKx8UGxj BNp7q8sKb7/uL+z1acAYBVKKoApOquI1Yc27JCv1PM9uZ40HyKnE7K6F4fCbE/sIag1x YYdh5Fwux6pKIxxRfciU4ongM5WJtHOjMFXBXUtpvTFwuD9ZeVzdn1CaNPzpbE+8DjcD zYbLu/zyNrwqNV3AXxdYIpXcTFwQPcz7iLZ/8Whj4C2V3dY0SN3V8x2vKM6exRw165d/ M79g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=Uev2A6prkSsEpuxSQYV88rOpAt/agkkAxfd7iSWDyOU=; b=VD4jHzYvDx8PUTQbfQtg6jYdG3Gd+CtweZ7QOiULmx9Fq2LLPQ+RsbbpABpBQUkGyS VRBUxqNqyiyOnSG6VSQJaQyI6xrRX8C0YBTDoVLQNOcExUgzGjYj598ts+bmc7SU2TEB EhpUvOkITx2x84krRG/QFVNFoTcBRL0f4ar+55aAvlQh/FXmsIAigdgOefqbNEWffiDa Vm4+5GwXoizRg78IRkzsN2PgGfPHtpsroT1lvwT9fAQPAIyqLvgImN9E/80zT0nLCZPV VgTMjuhE45Vc1KFseuaOaKzHyD5sf2tb0IoDjTnXNDN9lZGRVvf0U1b3E2qzZSfqhb0C aRLA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e15si1428680otq.237.2020.01.29.10.47.16; Wed, 29 Jan 2020 10:47:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726945AbgA2SBX (ORCPT + 99 others); Wed, 29 Jan 2020 13:01:23 -0500 Received: from baptiste.telenet-ops.be ([195.130.132.51]:58636 "EHLO baptiste.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726116AbgA2SBW (ORCPT ); Wed, 29 Jan 2020 13:01:22 -0500 Received: from ramsan ([84.195.182.253]) by baptiste.telenet-ops.be with bizsmtp id wJ1J2100R5USYZQ01J1JeL; Wed, 29 Jan 2020 19:01:20 +0100 Received: from rox.of.borg ([192.168.97.57]) by ramsan with esmtp (Exim 4.90_1) (envelope-from ) id 1iwreQ-0005lk-Ft; Wed, 29 Jan 2020 19:01:18 +0100 Received: from geert by rox.of.borg with local (Exim 4.90_1) (envelope-from ) id 1iwreQ-00009c-D9; Wed, 29 Jan 2020 19:01:18 +0100 From: Geert Uytterhoeven To: Paolo Abeni , Florian Westphal , Christoph Paasch , Mat Martineau , Matthieu Baerts , "David S . Miller" , Jakub Kicinski Cc: netdev@vger.kernel.org, mptcp@lists.01.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH] mptcp: Fix incorrect IPV6 dependency check Date: Wed, 29 Jan 2020 19:01:17 +0100 Message-Id: <20200129180117.545-1-geert@linux-m68k.org> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If CONFIG_MPTCP=y, CONFIG_MPTCP_IPV6=n, and CONFIG_IPV6=m: net/mptcp/protocol.o: In function `__mptcp_tcp_fallback': protocol.c:(.text+0x786): undefined reference to `inet6_stream_ops' Fix this by checking for CONFIG_MPTCP_IPV6 instead of CONFIG_IPV6, like is done in all other places in the mptcp code. Fixes: 8ab183deb26a3b79 ("mptcp: cope with later TCP fallback") Signed-off-by: Geert Uytterhoeven --- net/mptcp/protocol.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c index 39fdca79ce90137e..096dfd1074540c8a 100644 --- a/net/mptcp/protocol.c +++ b/net/mptcp/protocol.c @@ -28,7 +28,7 @@ static void __mptcp_close(struct sock *sk, long timeout); static const struct proto_ops *tcp_proto_ops(struct sock *sk) { -#if IS_ENABLED(CONFIG_IPV6) +#if IS_ENABLED(CONFIG_MPTCP_IPV6) if (sk->sk_family == AF_INET6) return &inet6_stream_ops; #endif -- 2.17.1