Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp886256ybl; Wed, 29 Jan 2020 11:21:26 -0800 (PST) X-Google-Smtp-Source: APXvYqxp11JWmLO9UuFcme3fOK6jrKbCswLrwTrgZmKpyixwd18AJRFVY+Wt1kvPA4NFliiBhFzl X-Received: by 2002:a05:6830:20d3:: with SMTP id z19mr590016otq.330.1580325686422; Wed, 29 Jan 2020 11:21:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580325686; cv=none; d=google.com; s=arc-20160816; b=Q/dCBoKVT+EJThAQ0BYFAnPLqfgt+Dv/f6pq3x9tXTVjQ4bcYQIh6yAYDSbRHpkyGU RMCwZyoDFhlBD/Z5dTnCxIebv/Me3eNejUrYRnBg6XyD5ObMo1MPRodeJ7lR6l633sNp X7OqVusWasiPQ7v2HpT89YDgxVF5v2LYU6MzjyJoRiqW6aEiWs0LZNu1W0h/mHCPIFpg Jwv6Upvi9sQBBKR5RjCrsXJ+cBZwiUQDPUhlN/reBdfqtwfq2Bdp5gwcakhVpKUUsRfP SKA3tJsVdei/80kzzrg1R1ngc9p/Oy0gf58+ccpcVaZkOuEo5H9mXuOkI5sk0fLG44Ey KtOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=pC0C76/9mV+NSA1IB3Fzi6RwKXSA9zm82uxlw8G+lLQ=; b=YkMMvD6xbnHW0V9mxK9K5DMUki0G7jg8/+0+27Awpsmm3xjufsHExnoFWPXmuWWRvY deLgvPV+ehBDmff6Ai4qhZGlSTCvZS7E3svMLX98P3hM7wbrKnKT79f2eh8uxwkpdXYT vSD77tK8ZQxVT+3Io4eVboWlYpK9T+J39x+9dKLJGDw7yCKD9BtHqCdZe6XiHMkpsguw 0Z87nYaEmc3lxObClMqIrJOMGqgj9sLNIR7lq+2InXf//AKrbb8fc/YNjtTJYt0z9FtE eNh7ZX/+KVh6nUgf0cqVWNv7KuD/PawR1tsQ8g50byJwNBDomqjaH672REVsTlIzzRvO 7pNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=fPdNw+Uf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y17si1579491otk.81.2020.01.29.11.21.13; Wed, 29 Jan 2020 11:21:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=fPdNw+Uf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727895AbgA2TEG (ORCPT + 99 others); Wed, 29 Jan 2020 14:04:06 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:39775 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727146AbgA2TEF (ORCPT ); Wed, 29 Jan 2020 14:04:05 -0500 Received: by mail-wr1-f66.google.com with SMTP id y11so763149wrt.6; Wed, 29 Jan 2020 11:04:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=pC0C76/9mV+NSA1IB3Fzi6RwKXSA9zm82uxlw8G+lLQ=; b=fPdNw+UfMoeCpNCzvk4CFkQaaV/6it1c037+DWLeqKBrn/H00XJjignKFnBp4qaXN2 XYKOsc0C+SkzgTkyEz7R5XKdgxIv1S8tVGPCuVRIEFqHOk6HX9bNtOmUfA2ORchaz36+ KZjfwXpbm3RyYZtspx1+5WV+/aD7n9C2pezzYyZ1crU8U9SR8F0CRo962CWH+4C+gKtt nIYF83JX/t/twNQJA7QQlhjOK8hknRIFhE6pQVV6i56fBLqbzYat1VGIdy7FFnRWclpv bwfBJ8nUeRIzza56fcfZIisZ3DFOFd3pOFUi/1q7Zr/DDVLGmEW6AU9MrWLdUXK1k62D CDFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=pC0C76/9mV+NSA1IB3Fzi6RwKXSA9zm82uxlw8G+lLQ=; b=MtkrxLn2ndSd6eNdgN/WM5VnZ1MJMlqU4aYqtF8A+u2T0hnNrx7ouY4YdelDRwVJEG 4FC1yDd3PVpoBCQNaA/i5FPNnC4IL1ij+fluFKiIkwR6oD4gzIzESED6j4SLjTMApCPP e1cAsJR91q3NlqYs22MkLpq4Z/Q8wvMIf+zh/NR8dRiSqE5zJfDoTnnESOuMC+TqxpSK P7sgxEwxr4keqVE0chSehQbpCJt9aCBaY3mz3vB1Ev7P7kNFK4zriscOiDeyV/WJ9ZoH gkuUw8lfzFkayH96yG/IeLZCXXMPEcwgp5Jg/6dCleDxbhsFtzrSHkWMI8kqHefpMEMq NQWQ== X-Gm-Message-State: APjAAAUIXVcbSmR5xoKfCnxIvbyoPNRHWPvPL9RLlC/RGMNa6kIHPKw1 K+y61qRd8HoHHS+nsythjU4= X-Received: by 2002:a5d:4752:: with SMTP id o18mr278260wrs.330.1580324643222; Wed, 29 Jan 2020 11:04:03 -0800 (PST) Received: from [192.168.2.145] (79-139-233-37.dynamic.spd-mgts.ru. [79.139.233.37]) by smtp.googlemail.com with ESMTPSA id z10sm3138545wmk.31.2020.01.29.11.04.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jan 2020 11:04:02 -0800 (PST) Subject: Re: [PATCH V3] serial: 8250_tegra: Create Tegra specific 8250 driver To: Jon Hunter , Greg Kroah-Hartman , Jiri Slaby , Thierry Reding Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, Jeff Brasen References: <20200129132817.26343-1-jonathanh@nvidia.com> From: Dmitry Osipenko Message-ID: <45ac5b66-e09a-e328-6ebf-3fbbe97b7873@gmail.com> Date: Wed, 29 Jan 2020 22:04:01 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <20200129132817.26343-1-jonathanh@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 29.01.2020 16:28, Jon Hunter пишет: ... > +#ifdef CONFIG_PM_SLEEP > +static int tegra_uart_suspend(struct device *dev) > +{ Nit: the ifdef'ing in the code could be avoided by using the __maybe_unused attribute.