Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1096413ybl; Wed, 29 Jan 2020 15:18:56 -0800 (PST) X-Google-Smtp-Source: APXvYqw/X69ipFFzXVKHFsQU2E6ObFr8zqvjerU/w4NsrH6cuNk1RpAv1h1eHGmmPAb+lBAIWTi9 X-Received: by 2002:a9d:ec7:: with SMTP id 65mr1368349otj.309.1580339936419; Wed, 29 Jan 2020 15:18:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580339936; cv=none; d=google.com; s=arc-20160816; b=Qaob/jvbBxxKxkVyr6BiLxLEEnhzeA5If5hhfw8HE+iOsLr2BlZIXi+yGSd7cSJp+z NXPmW32gW4n/WNO2H2nYgFgsTP0GkaoMZKp2U+spp3h0zFKyIW+Tzv/Ej1PNTqNEvMis Gnw03SjCnpWT/QzDKk2eadiWDlPzZla6N7e0WfwngMp4ytsrbTR4GRJvVV2Tr+l5tygp Ddhm3TRIo8h0XMBS88aem5yojv+ve9huB8NPKita8ZQMwwMqe4wkK5Tle/mcxkKP9Sb5 kqa+SBnNbJ7D+2L84wZm2bScJgq0+Ftz5XOZUWtMGaKcORzADeAyR6bxxclHFONvimEO alfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from; bh=ApqPB9hpPJcrJv8qvbzX9WMC00PfP4I5lPXWkv/CNbE=; b=lm7vjwMjcwoM5tbooKXBAymmPm/0hnVjw4zEnAZZHxbtAH7MkVtuneAuMVT6B13Vob 3YJgd3zpa1Lb6wHdypVGCHZ4cgtdRsblYRJPMIiFyJdrSZ5i1aWVXRB8usJPM48TC395 CNysRS5ajy/Puz5Hb31+jqqJwTxBqzxPkLW3jU/kDzV9R/qsXRtreCrHSyL9YHdKn11u 79QzJkfOCD3UDMvGB+DgWm789MEtM1v/pZhKOkYi3Zymji3+5+gVSBnuntd8bUCFd87z fA1Hx59H6kBXMwAW5qnuI8pgWJwQwhf5dl0tKWRklUCprQ5gmIlsBK/MqE9BdLZ25qSM ziXA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t130si1774224oib.202.2020.01.29.15.18.44; Wed, 29 Jan 2020 15:18:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726768AbgA2XQm (ORCPT + 99 others); Wed, 29 Jan 2020 18:16:42 -0500 Received: from Galois.linutronix.de ([193.142.43.55]:52018 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726618AbgA2XQm (ORCPT ); Wed, 29 Jan 2020 18:16:42 -0500 Received: from 51.26-246-81.adsl-static.isp.belgacom.be ([81.246.26.51] helo=nanos.tec.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1iwwZV-0007Ms-KU; Thu, 30 Jan 2020 00:16:34 +0100 Received: by nanos.tec.linutronix.de (Postfix, from userid 1000) id 26CA7105CFD; Thu, 30 Jan 2020 00:16:28 +0100 (CET) From: Thomas Gleixner To: Evan Green Cc: Rajat Jain , Bjorn Helgaas , linux-pci , Linux Kernel Mailing List , x86@kernel.org, Marc Zyngier Subject: Re: [PATCH v2] PCI/MSI: Avoid torn updates to MSI pairs In-Reply-To: References: <20200117162444.v2.1.I9c7e72144ef639cc135ea33ef332852a6b33730f@changeid> <87y2tytv5i.fsf@nanos.tec.linutronix.de> <87eevqkpgn.fsf@nanos.tec.linutronix.de> <87d0b82a9o.fsf@nanos.tec.linutronix.de> <878slwmpu9.fsf@nanos.tec.linutronix.de> <87imkv63yf.fsf@nanos.tec.linutronix.de> <87pnf342pr.fsf@nanos.tec.linutronix.de> <877e1a2d11.fsf@nanos.tec.linutronix.de> Date: Thu, 30 Jan 2020 00:16:28 +0100 Message-ID: <874kwd3lbn.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Evan, Evan Green writes: > On Wed, Jan 29, 2020 at 1:01 PM Thomas Gleixner wrote: > >> Could you please add some instrumentation to see how often this stuff >> actually triggers spurious interrupts? > > In about 10 minutes of this script running, I got 142 hits. My script > can toggle the HT cpus on and off about twice per second. > Here's my diff (sorry it's mangled by gmail). If you're looking for > something else, let me know, or I can run a patch. > No, that's good data. Your testing is hiting the critical path and as you did not complain about negative side effects it seems to hold up to the expectations. I'm going to convert this to real patch with a proper changelog tomorrow. Thanks for your help! tglx