Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1315118ybl; Wed, 29 Jan 2020 20:12:23 -0800 (PST) X-Google-Smtp-Source: APXvYqww7hvm9leO6UR2WVX+u0BIEBC0swNHP0decgJ4P5FQSIip64nNsiIbqj0Vpjc3P5rOwdMN X-Received: by 2002:a05:6830:160c:: with SMTP id g12mr2053660otr.82.1580357543695; Wed, 29 Jan 2020 20:12:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580357543; cv=none; d=google.com; s=arc-20160816; b=DK7xa9vY6GCNDbmU8JvsDPoA/IRrWp5QdSHn6YXj7F7rk93iUvo0JGMXyE+jx3U5WO f09ETrYW4IYoWtjJrw298T/fVWVfrDsAkcP8nJb9SNwy7O8kp9x82ljnQrWcyQLxiK/P U9klsaWmLwUYa4Eps1VKY9qP7RoY/apCrOEdlyhvZiVuMGBFFdxMFKrsbMMH26YuF34z 668PL4FGCbYMIsdU2ER1UhBAQBWlh4ef3NMUkid1rH8YTVpi28B7ElXZniWT/T9pLwqd s6WBnMneo6whXmUPDOpw5SjtA7hZ1JEV1Vj5Bkglc8YdsjpNnRGIduI7qX9BuzkHUmbo Rq9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=pvvVT/b95UaLpYd8lIo04uOv4SDYk7PHg7fzm5Afymw=; b=yAc3JERt+TT3vwo35C3Tus6vkJBcBzA3KK92DacrqtOe2gHOmLVP21l/REhA1WWUD7 2BY6x7Ff19Q1ALSbWa4/EK4Bt4T/nAMSajM6roXVm9FITGBZaQ93b55TaiUmuSXQeRlc Fj+PMZVH+VSSZu9Z0C8f78G+F4CgQOk15A8ijeBig25bpf8Jw6u+YXuK8MdViBHHP/+k eJigAcu9+y7lztRDRZBKUCU5XUqezyu6YzBQV1gPYLQJY2NkITQp0ppNqSo10FeclX9l R5gJ8wvrLDBPkLC4teGyEzjkGdJYczXFucwz67uMnSnkKPnZwepPdl2sSCXpkp5pIVKN U/ew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=2CM33z3Q; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 14si2291771oie.181.2020.01.29.20.11.38; Wed, 29 Jan 2020 20:12:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=2CM33z3Q; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726927AbgA3EEM (ORCPT + 99 others); Wed, 29 Jan 2020 23:04:12 -0500 Received: from mail-pf1-f193.google.com ([209.85.210.193]:46567 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726811AbgA3EEM (ORCPT ); Wed, 29 Jan 2020 23:04:12 -0500 Received: by mail-pf1-f193.google.com with SMTP id k29so766459pfp.13 for ; Wed, 29 Jan 2020 20:04:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=pvvVT/b95UaLpYd8lIo04uOv4SDYk7PHg7fzm5Afymw=; b=2CM33z3QmNsLGizAUud8ZrRtcS/UOJVh5srO6r0beE7dVVirSjyUJu5uQbG3wAp+1j igd5VCWO6Rh8WcpPgbCzn/iOdFGAqmclnWh0idY9BDEcZvb8O3xACKrJcCrO0OHWMdcq x0gzeZkIYTrIil50MthvcQxlBLvgEaiZS/6VnOfXiADJd/0akppJPB9uEdD6YU2+No8q w/F5aHJsL9e9kGlTGyHtzjzKWqzEdgL1BL/EeyQoGS/lINLfuj0gi33Eyanul2MMl7Dj JIiHVq9Mj5pq+/+5Zh8f3kdl7zJjHAOgGykuowufHJNu87NGEweXdXwHyyMDxiOQI3lb oBbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=pvvVT/b95UaLpYd8lIo04uOv4SDYk7PHg7fzm5Afymw=; b=VbesGvRcxPRXr8d/Dl4hB9tlt6u3l65HT6FqxExj82ERMKY61wivJlDamRL1UvwsT5 tpetz+o7toKx5HHaGcvN3Ib78N1izvhNEMO/N8g7eJ5Gf5wjzcvLp90ExoBFAFw4zFXH oN674fsjlV7BO3aVAemNnij1jqEsFct0bEo338Xn2+Iq/Z0r+j5dW/xqNeLmi36/p/4o Kykt1q70w/C3LtkQAeTdT8wOjxT76e0EVweJx+dgS/n1tJylCKx9YFNeBTYXUGO53RuI IHaF9j5SSsFot7CnMmKvii0T0CYgWy9nHu7o/2k1NYq0qZqgzG1kofzTscvMlrVI+Kth Ov8Q== X-Gm-Message-State: APjAAAUmInUwRe4LstLI1h0rfm7CTx1WdZ4BHX9aoRpz0w4QoBHpE4/m ItBUs73bQgfgS6ZrpBiPDIUt1wbRrpc= X-Received: by 2002:a63:78c:: with SMTP id 134mr2473976pgh.279.1580357051523; Wed, 29 Jan 2020 20:04:11 -0800 (PST) Received: from [192.168.1.188] ([66.219.217.145]) by smtp.gmail.com with ESMTPSA id j17sm4483515pfa.28.2020.01.29.20.04.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jan 2020 20:04:11 -0800 (PST) Subject: Re: [PATCH] drbd fifo_alloc: use struct_size To: Stephen Kitt , Philipp Reisner , Lars Ellenberg , drbd-dev@lists.linbit.com Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200124200307.1808593-1-steve@sk2.org> From: Jens Axboe Message-ID: Date: Wed, 29 Jan 2020 21:04:09 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200124200307.1808593-1-steve@sk2.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/24/20 1:03 PM, Stephen Kitt wrote: > Switching to struct_size for the allocation in fifo_alloc avoids > hard-coding the type of fifo_buffer.values in fifo_alloc. It also > provides overflow protection; to avoid pessimistic code being > generated by the compiler as a result, this patch also switches > fifo_size to unsigned, propagating the change as appropriate. Applied, thanks. -- Jens Axboe