Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1480309ybl; Thu, 30 Jan 2020 00:12:59 -0800 (PST) X-Google-Smtp-Source: APXvYqwN2dhqeUmSDiAMfmEWg3D2yHpFRrJhCD0q6nQAn8pQEt24jKoOYsfiRzD0u4Vc8WQqd79J X-Received: by 2002:a9d:6b12:: with SMTP id g18mr2546883otp.211.1580371979829; Thu, 30 Jan 2020 00:12:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580371979; cv=none; d=google.com; s=arc-20160816; b=w9qxVWyyp2eU8Q4ans6K70VXCsfeKdPS9ZH7UuTi1ATG2n6YSrQyaX4G1gX16GpcbU BI49lmpv1dyeKaDU0mXgYzYChBkvwTZT+l1thk7M4y5sJpr5/ykrxCsoXGUG2QHY5R4P FcF4ELuOjB+TTdICJ8POc6OXh9BhQptX6r8k2xM6qvGRfMAgiM5Lymunaw/rBhQpR32i 36Bj5mvu/w+cJmDrS26BhVBagXQQc3TLAsg33lPDMLJdLc5GbXoBT2c3YOtxCjOWyylH evEjvHEiJqkJQw7Pv0Os1B5aDirpkkNIUqToKc9bFLc3PUAplvoQRvJWE3rqy38rqplv 5Yfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=SEQYndPiQmHOinSK+5y0b6xfiS41LxvS+Ygq8GPrsz0=; b=wu0gSTgCe8avVsdod/iX0gdD4/4vmmgwNDo/Nm3ZZ36xju5JP5hWJ2fiUgEjq7EPPB Q2aanfQCwtW0cg1ingBzKqo9sy3V28Apk8S/P2O36LHcc3Sp1PmhYvdJzD4v0EYfad3V M5/X39wM8chgEaKeYf19bPa7uVOYMR5lkVAWYa/tOKB4Z3r22F4b4wDIhvHhNKtn2Bv0 u++FCvwEIAhHxmJ4jRUv+bC94ETkSjt9ANpWPnFoYCZzQ8wIP0ZFj23cHLGw1Ah6ksgN 5ApXO8gOG2GDchJQ6EzFs3dXWi2q/BQRVNH7O8gEY91saDbOxwtXnsgkgELC5CZdjiTw NVTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=Woj0I4jn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m85si2522610oig.158.2020.01.30.00.12.46; Thu, 30 Jan 2020 00:12:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=Woj0I4jn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726882AbgA3IKw (ORCPT + 99 others); Thu, 30 Jan 2020 03:10:52 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:46132 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726397AbgA3IKv (ORCPT ); Thu, 30 Jan 2020 03:10:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=SEQYndPiQmHOinSK+5y0b6xfiS41LxvS+Ygq8GPrsz0=; b=Woj0I4jnSm3FzQbmUq6+phIAE VpS2wAWZ6qzBTSiA6+KJLJeZ9IJQo1IqzfIFbO9F9U013MkZDuBKnAfT5OB68HV2xbY5/kB+RHbVE E8P7HSQNZWfZIyY8SuKKokFMl/gRwea6+t3lTcWic2MCWwljy7u9IP7KvM4SleQbf9WV0h7SBx0/r RlsnXkgBCOBUo60U2z1I/x5z8+WOFcrYrEUkrqxsd9ZAOBPILh+nkp14gflmaQYWVuhu3TkQ+OemW SXh8xd/27OU7EMzKIdB6M87ZCaFb7NYahHbS5SggQfDRIrmHZsY8eK4pkWy+xMjY0X27qIaQ+6ixP 5RWDLmRFA==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1ix4uZ-0000RV-KY; Thu, 30 Jan 2020 08:10:51 +0000 Date: Thu, 30 Jan 2020 00:10:51 -0800 From: Matthew Wilcox To: Dave Chinner Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-erofs@lists.ozlabs.org Subject: Re: [PATCH 07/12] erofs: Convert uncompressed files from readpages to readahead Message-ID: <20200130081051.GM6615@bombadil.infradead.org> References: <20200125013553.24899-1-willy@infradead.org> <20200125013553.24899-8-willy@infradead.org> <20200129005741.GJ18610@dread.disaster.area> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200129005741.GJ18610@dread.disaster.area> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 29, 2020 at 11:57:41AM +1100, Dave Chinner wrote: > > + bio = NULL; > > + put_page(page); > > } > > > > - /* pages could still be locked */ > > put_page(page); > > A double put_page() on error? Yup, already fixed when Gao Xiang pointed it out ;-)