Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1521673ybl; Thu, 30 Jan 2020 01:10:37 -0800 (PST) X-Google-Smtp-Source: APXvYqw2Iu+F5sjuF9u6q3CYGVJQ2XJOZuSYggtm1vvdp8CIRKwzSm0N+QrUNqQJKSAk+ars87t3 X-Received: by 2002:a9d:4711:: with SMTP id a17mr2839491otf.233.1580375437586; Thu, 30 Jan 2020 01:10:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580375437; cv=none; d=google.com; s=arc-20160816; b=fIDxUQjag3sQ6IjA4bkjOEcdqCpsdgmfGVYaU/mhHd5ierwQaJEpHq0HwIn5Jo0PsM rhvymN1FqE/5T0Px36omm4BPuglthTQSuwGenmrlTscgQA2ZxY8kq6lDRSDeP7rh4OOd ZHs3v7l2gvDULLr8hY05Liv5K3FeogYn8DOtIRkDOPa/V6FXIp7uvyIZOgvguT83H0TF YZglHTuHKnsNZLyQGaG82n/N+a9khbzCEd7sHmtB6RXJbp5lW2qTe6+eY6hd/hNm62Rt bwjIoA5OaATTcVfD5sGXjfZUm8K3+tJgjLvybtS3zZhuuHm7quECJkl0aa4W/NqeCnf4 m5Ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=qvKQv6tHR8uHOTRp8jYkxgJFuLu0krq90j05pRXWdVg=; b=G2s1EZtdda5dx2DOK49w4O8VHdJblGie/tBmTfz9hZuwZKMqb/m2skuXvZOi3OPH9B 9iLQSTOdDWnYOmU90WHrkGtlZqrx4Hj8dKdq9ngduAqpEMDuZPsz6K31MakxTHcauOYx J5THqiRWjCL+4i0GSPn1a5AZW1VcxACZhxIpY33fUy0TJ7ZfnKUiC6j9yxij12n9CLAt YkO9+dujq5omXWWPz0WbvR86ig1Sx+V83bqlqnZTceNW5jFfu8mjXXPmIAvgvQcTvPQc DlAirf3RZCerGuBdI5KRh8L9T/hHENoRw6iMPKxr0EviXxBssX6FNxtr5EorSQXIy4g/ j4rQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y20si2809673otq.190.2020.01.30.01.10.25; Thu, 30 Jan 2020 01:10:37 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726902AbgA3JJT (ORCPT + 99 others); Thu, 30 Jan 2020 04:09:19 -0500 Received: from mx2.suse.de ([195.135.220.15]:35888 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726873AbgA3JJT (ORCPT ); Thu, 30 Jan 2020 04:09:19 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id C8A94ACCA; Thu, 30 Jan 2020 09:09:17 +0000 (UTC) Date: Thu, 30 Jan 2020 10:09:17 +0100 From: Petr Mladek To: Andy Shevchenko Cc: Sergey Senozhatsky , Steven Rostedt , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 5/5] console: Introduce ->exit() callback Message-ID: <20200130090917.sg5vnwvlng4ox6ua@pathway.suse.cz> References: <20200127114719.69114-1-andriy.shevchenko@linux.intel.com> <20200127114719.69114-5-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200127114719.69114-5-andriy.shevchenko@linux.intel.com> User-Agent: NeoMutt/20170912 (1.9.0) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 2020-01-27 13:47:19, Andy Shevchenko wrote: > Some consoles might require special operations on unregistering. For example, > serial console, when registered in the kernel, keeps power on for entire time, > until it gets unregistered. For such cases to have a balance we would provide > ->exit() callback. Is there any plan to use this callback, please? The console init, setup, registration code needs a clean up, definitely. If you plan some rework, I would like to understand the bigger picture before we start adding new callbacks. Best Regards, Petr