Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v3 2/3] sched/topology: Remove SD_BALANCE_WAKE on
 asymmetric capacity systems
To:     Dietmar Eggemann <dietmar.eggemann@arm.com>,
        linux-kernel@vger.kernel.org
Cc:     mingo@redhat.com, peterz@infradead.org, vincent.guittot@linaro.org,
        morten.rasmussen@arm.com, qperret@google.com,
        adharmap@codeaurora.org
References: <20200126200934.18712-1-valentin.schneider@arm.com>
 <20200126200934.18712-3-valentin.schneider@arm.com>
 <92f38645-c6ae-0e15-fac9-8c6064b5d4cf@arm.com>
From:   Valentin Schneider <valentin.schneider@arm.com>
Message-ID: <203f41b4-6fbe-2b69-0548-02ea326b704e@arm.com>
Date:   Thu, 30 Jan 2020 11:06:49 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <92f38645-c6ae-0e15-fac9-8c6064b5d4cf@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 29/01/2020 16:27, Dietmar Eggemann wrote:
> On 26/01/2020 21:09, Valentin Schneider wrote:
>> From: Morten Rasmussen <morten.rasmussen@arm.com>
> 
> [...]
> 
>> @@ -1374,18 +1374,9 @@ sd_init(struct sched_domain_topology_level *tl,
>>  	 * Convert topological properties into behaviour.
>>  	 */
>>  
>> -	if (sd->flags & SD_ASYM_CPUCAPACITY) {
>> -		struct sched_domain *t = sd;
>> -
>> -		/*
>> -		 * Don't attempt to spread across CPUs of different capacities.
>> -		 */
>> -		if (sd->child)
>> -			sd->child->flags &= ~SD_PREFER_SIBLING;
>> -
>> -		for_each_lower_domain(t)
> 
> It seems that with this goes the last use of for_each_lower_domain().
> 
> [...]
> 

Indeed, good catch. I see that was used at some point before the
select_idle_sibling() rework:

  10e2f1acd010 ("sched/core: Rewrite and improve select_idle_siblings()")

and our asymmetry policy saved it. I'll remove it in v4.