Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 2/7] gcov_seq_next should increase position index
To:     Vasily Averin <vvs@virtuozzo.com>, linux-kernel@vger.kernel.org
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        NeilBrown <neilb@suse.com>, Waiman Long <longman@redhat.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ingo Molnar <mingo@redhat.com>
References: <f65c6ee7-bd00-f910-2f8a-37cc67e4ff88@virtuozzo.com>
From:   Peter Oberparleiter <oberpar@linux.ibm.com>
Date:   Thu, 30 Jan 2020 14:09:42 +0100
MIME-Version: 1.0
In-Reply-To: <f65c6ee7-bd00-f910-2f8a-37cc67e4ff88@virtuozzo.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Message-Id: <44b8bbff-0ade-d390-e2df-7a66d6c3f19c@linux.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 24.01.2020 08:02, Vasily Averin wrote:
> if seq_file .next fuction does not change position index,
> read after some lseek can generate unexpected output.
> 
> https://bugzilla.kernel.org/show_bug.cgi?id=206283
> Signed-off-by: Vasily Averin <vvs@virtuozzo.com>

Acked-by: Peter Oberparleiter <oberpar@linux.ibm.com>

> ---
>  kernel/gcov/fs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/gcov/fs.c b/kernel/gcov/fs.c
> index e5eb5ea..cc4ee48 100644
> --- a/kernel/gcov/fs.c
> +++ b/kernel/gcov/fs.c
> @@ -108,9 +108,9 @@ static void *gcov_seq_next(struct seq_file *seq, void *data, loff_t *pos)
>  {
>  	struct gcov_iterator *iter = data;
>  
> +	(*pos)++;
>  	if (gcov_iter_next(iter))
>  		return NULL;
> -	(*pos)++;
>  
>  	return iter;
>  }
> 


-- 
Peter Oberparleiter
Linux on Z Development - IBM Germany