Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1793716ybl; Thu, 30 Jan 2020 06:10:22 -0800 (PST) X-Google-Smtp-Source: APXvYqz9sQ+f8/lcFat7Gs7i2zR1pJwM2a7Ntuv2S3dpZADgbgcY1iLqWD8O8PTrTITCKX0D3GRo X-Received: by 2002:aca:ebcb:: with SMTP id j194mr2983935oih.154.1580393422168; Thu, 30 Jan 2020 06:10:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580393422; cv=none; d=google.com; s=arc-20160816; b=VofslrvXfLBa4tqt5Q1prwoGGJSHQAKWD8eCvmW459aazzC8K9AnFSfK1V94P5M6v2 bzp3etnNxrWoLhDXL+UQcfJlrY+K+67YEO5otbfD5r5QvmXLwdzFcbq7XNAqmpKpMf5h NDpZRC05/5BATRZFNv1XtVWfpoM0Y3+ID0nu/yYHFy2w7yH0WQzCxjg6qt0LYqpqaQaL gKAy/YOWWC2GyA8oxkY/UEQ6pINWWQ7uiVQsiJR4jtKYg0EvIAhzRhEXGY4PktOOiQ+d 81dzjzMvi7jD6uggVo+HyqmpJ6xmnrsWCgqbebe0PTJlmv90v+OfN5jSMfKDxT6b5qwp 8AWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=UCUlEQh4dM/fiU5bq3M69yQEqZFXhp6oKN/xEZvymvw=; b=D7garwim//gKL+qMjxydk6KFwGi/A2kwJoDBswGWak4HtcErOd4VwnT9maDd29fURp NPJZ0VOYhrzZG/mp028IrLBMZElnp9Cow/UbGSRwyQcZQdrf5yUgDptb5uMMQr/dgFX8 pA8wGZyl2is13AuYSBYXcp/7eC4P00lnrL2hiC7CSlPkKKbQwEJRAHVvK9c0MqRKtb6Z 9SUsHYm8dUKYoeNGrTb0dCRWQTFWzXVJ66ITZDXszuMXBGl79HPGsLr9LvuVhbaA2elU 5PGmDrvHUoXt5jxthYz2pB9U3UrqYMKsfhtc4gQKelE3R3YHq05Z59mui9H/Kipd9lV0 wy6g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p186si3018714oih.172.2020.01.30.06.10.08; Thu, 30 Jan 2020 06:10:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727261AbgA3OIp (ORCPT + 99 others); Thu, 30 Jan 2020 09:08:45 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:59472 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726902AbgA3OIp (ORCPT ); Thu, 30 Jan 2020 09:08:45 -0500 Received: from [109.134.33.162] (helo=wittgenstein) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1ixAUo-0007pq-GF; Thu, 30 Jan 2020 14:08:38 +0000 Date: Thu, 30 Jan 2020 15:08:38 +0100 From: Christian Brauner To: Dave Chinner , Mike Christie , Michal Hocko Cc: Shakeel Butt , Andrew Morton , linux-api@vger.kernel.org, idryomov@gmail.com, Linux MM , LKML , linux-scsi@vger.kernel.org, linux-fsdevel , linux-block@vger.kernel.org, martin@urbackup.org, Damien.LeMoal@wdc.com, Michal Hocko , Masato Suzuki Subject: Re: [PATCH] Add prctl support for controlling mem reclaim V4 Message-ID: <20200130140838.mfl2p3zb5f26kej6@wittgenstein> References: <20191112001900.9206-1-mchristi@redhat.com> <5E2B19C9.6080907@redhat.com> <20200124211642.GB7216@dread.disaster.area> <20200127130258.2bknkl3mwpkfyml4@wittgenstein> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200127130258.2bknkl3mwpkfyml4@wittgenstein> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 27, 2020 at 02:02:59PM +0100, Christian Brauner wrote: > On Sat, Jan 25, 2020 at 08:16:42AM +1100, Dave Chinner wrote: > > On Fri, Jan 24, 2020 at 10:22:33AM -0600, Mike Christie wrote: > > > On 12/05/2019 04:43 PM, Shakeel Butt wrote: > > > > On Mon, Nov 11, 2019 at 4:19 PM Mike Christie wrote: > > > >> This patch adds a new prctl command that daemons can use after they have > > > >> done their initial setup, and before they start to do allocations that > > > >> are in the IO path. It sets the PF_MEMALLOC_NOIO and PF_LESS_THROTTLE > > > >> flags so both userspace block and FS threads can use it to avoid the > > > >> allocation recursion and try to prevent from being throttled while > > > >> writing out data to free up memory. > > > >> > > > >> Signed-off-by: Mike Christie > > > >> Acked-by: Michal Hocko > > > >> Tested-by: Masato Suzuki > > > >> Reviewed-by: Damien Le Moal > > > > > > > > I suppose this patch should be routed through MM tree, so, CCing Andrew. > > > > > > > > > > Andrew and other mm/storage developers, > > > > > > Do I need to handle anything else for this patch, or are there any other > > > concerns? Is this maybe something we want to talk about at a quick LSF > > > session? > > > > > > I have retested it with Linus's current tree. It still applies cleanly > > > (just some offsets), and fixes the problem described above we have been > > > hitting. > > > > I must have missed this version being posted (just looked it up on > > lore.kernel.org). As far as I'm concerned this is good to go and it > > is absolutely necessary for userspace IO stacks to function > > correctly. > > > > Reviewed-by: Dave Chinner > > > > If no manintainer picks it up before the next merge window, then I > > Since prctl() is thread-management and fs people seem to be happy and > have acked it I can pick this up too if noone objects and send this > along with the rest of process management. This is upstream now https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8d19f1c8e1937baf74e1962aae9f90fa3aeab463 Christian