Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp2101737ybl; Thu, 30 Jan 2020 11:23:04 -0800 (PST) X-Google-Smtp-Source: APXvYqzuy2LR/K3zD3d9bbiNqYCS2UTqzKTlbIBqGo8ZwhVlmNBotykcopr9Q93tbtolE4Pz52j7 X-Received: by 2002:aca:36c1:: with SMTP id d184mr3915745oia.70.1580412184357; Thu, 30 Jan 2020 11:23:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580412184; cv=none; d=google.com; s=arc-20160816; b=0GsDYqK1zTPvbC9vEEvzHuKviI4/rZY2bSYmcnYHbRbkrnHClmDHb7CqYM/WoLYmN/ SH5MPdsvdbgSVk3o7zcoY0HzpQ9YOlmF+OFVjS6hm2EQURjUpQvRg3NrIJTYp/tvL+/M DLYv7JYeWLFEICChiWeG42FoYf05jIK9F+LLucWk42O9O1l9/PYh+tuYihe42wTA8o+S 019NKsIiuhYK9FLxhbV2UYFTdQwmmB0tDxirAruqciEX/HLzeLqV2OUWcwrgmp+uCpi2 1bHLihqqPOwIfwMjuZ4TxVtJtBBm2dFHrrplFo2uw3W6N9Gu6VuOyRjTSdL1jdNEPRxb PxFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=S+NV4pbV4L892bMLeLfmqiQDVAKFurt/Wyt+526Y2Z0=; b=iEeL2jdi2nDfK2AKhKklIYNxeAJsogXZG72hWB6L5pl4CEnD8YLQ9H4uYT2zNENheM TgPyelf11UuKZbwLBfF9VF2JMoS8dstez3jbed5U+jnqFdB7JNRpxEa2/YvsjPb/Nh88 F+RG5b7j4GGw8G99n6k/w+a19/0QXynnynvgKRek6KvXZ8181FDaf18aZjYTu+lZTMWz hHHkouiBlH3Hpv1aKV1TKaaKmhC1JH491Yhf4caQ8qsKOvbw9+PJvOBasAeXH34Bk8s9 /JHv4+NfFc6MUtLh4DM7gQ3Pjwnjub7MVl3hwc9VhLbcIgFTbvggqVYyYfHNQRllYEHv G3IQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o13si3761135otp.27.2020.01.30.11.22.51; Thu, 30 Jan 2020 11:23:04 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727693AbgA3TQg (ORCPT + 99 others); Thu, 30 Jan 2020 14:16:36 -0500 Received: from mga04.intel.com ([192.55.52.120]:9436 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726267AbgA3TQg (ORCPT ); Thu, 30 Jan 2020 14:16:36 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jan 2020 11:16:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,382,1574150400"; d="scan'208";a="262281101" Received: from ranger.igk.intel.com ([10.102.21.164]) by fmsmga002.fm.intel.com with ESMTP; 30 Jan 2020 11:16:33 -0800 Date: Thu, 30 Jan 2020 13:07:30 +0100 From: Maciej Fijalkowski To: Jakub Kicinski Cc: Robert Jones , Sunil Goutham , Robert Richter , David Miller , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Tim Harvey Subject: Re: [PATCH net] net: thunderx: workaround BGX TX Underflow issue Message-ID: <20200130120730.GA60572@ranger.igk.intel.com> References: <20200129223609.9327-1-rjones@gateworks.com> <20200130091055.159d63ed@cakuba> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200130091055.159d63ed@cakuba> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 30, 2020 at 09:10:55AM -0800, Jakub Kicinski wrote: > On Wed, 29 Jan 2020 14:36:09 -0800, Robert Jones wrote: > > From: Tim Harvey > > > > While it is not yet understood why a TX underflow can easily occur > > for SGMII interfaces resulting in a TX wedge. It has been found that > > disabling/re-enabling the LMAC resolves the issue. > > > > Signed-off-by: Tim Harvey > > Reviewed-by: Robert Jones > > Sunil or Robert (i.e. one of the maintainers) will have to review this > patch (as indicated by Dave by marking it with "Needs Review / ACK" in > patchwork). > > At a quick look there are some things which jump out at me: > > > +static int bgx_register_intr(struct pci_dev *pdev) > > +{ > > + struct bgx *bgx = pci_get_drvdata(pdev); > > + struct device *dev = &pdev->dev; > > + int num_vec, ret; > > + > > + /* Enable MSI-X */ > > + num_vec = pci_msix_vec_count(pdev); > > + ret = pci_alloc_irq_vectors(pdev, num_vec, num_vec, PCI_IRQ_MSIX); > > + if (ret < 0) { > > + dev_err(dev, "Req for #%d msix vectors failed\n", num_vec); > > + return 1; > > Please propagate real error codes, or make this function void as the > caller never actually checks the return value. > > > + } > > + sprintf(bgx->irq_name, "BGX%d", bgx->bgx_id); Another quick look: use snprintf so that you won't overflow the bgx->irq_name in case bgx->bgx_id has some weird big number. > > + ret = request_irq(pci_irq_vector(pdev, GMPX_GMI_TX_INT), > > There is a alloc_irq and request_irq call added in this patch but there > is never any freeing. Are you sure this is fine? Devices can be > reprobed (unbound and bound to drivers via sysfs). > > > + bgx_intr_handler, 0, bgx->irq_name, bgx); > > Please align the continuation line with the opening bracket (checkpatch > --strict should help catch this). > > > + if (ret) > > + return 1; > > + > > + return 0; > > +}