Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 31 Jan 2020 06:38:39 +0900
From:   Stafford Horne <shorne@gmail.com>
To:     Krzysztof Kozlowski <krzk@kernel.org>
Cc:     Jonas Bonn <jonas@southpole.se>,
        Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
        Andrew Morton <akpm@linux-foundation.org>,
        openrisc@lists.librecores.org, linux-kernel@vger.kernel.org,
        yamada.masahiro@socionext.com
Subject: Re: [PATCH] openrisc: configs: Cleanup CONFIG_CROSS_COMPILE
Message-ID: <20200130213839.GW24874@lianli.shorne-pla.net>
References: <20200130191938.2444-1-krzk@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200130191938.2444-1-krzk@kernel.org>
User-Agent: Mutt/1.11.4 (2019-03-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

+cc: Masahiro,

On Thu, Jan 30, 2020 at 08:19:38PM +0100, Krzysztof Kozlowski wrote:
> CONFIG_CROSS_COMPILE is gone since commit f1089c92da79 ("kbuild: remove
> CONFIG_CROSS_COMPILE support").

I see this patch is already in, but does it break 0-day test tools that depend
on this CONFIG_CROSS_COMPILE setup?  I guess its been in since 2018, so there
should be no problem.

Can you also help to update "Documentation/openrisc/openrisc_port.rst"?  It
mentions the build steps are:

    Build the Linux kernel as usual::                                               
                                                                                
        make ARCH=openrisc defconfig                                            
        make ARCH=openrisc

This now changes, I used to use `make ARCH=openrisc CROSS_COMPILE=or1k-linux-`
is this still going to work?

-Stafford

> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  arch/openrisc/configs/or1ksim_defconfig    | 1 -
>  arch/openrisc/configs/simple_smp_defconfig | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/arch/openrisc/configs/or1ksim_defconfig b/arch/openrisc/configs/or1ksim_defconfig
> index d8ff4f8ffb88..75f2da324d0e 100644
> --- a/arch/openrisc/configs/or1ksim_defconfig
> +++ b/arch/openrisc/configs/or1ksim_defconfig
> @@ -1,4 +1,3 @@
> -CONFIG_CROSS_COMPILE="or1k-linux-"
>  CONFIG_NO_HZ=y
>  CONFIG_LOG_BUF_SHIFT=14
>  CONFIG_BLK_DEV_INITRD=y
> diff --git a/arch/openrisc/configs/simple_smp_defconfig b/arch/openrisc/configs/simple_smp_defconfig
> index 64278992df9c..ff49d868e040 100644
> --- a/arch/openrisc/configs/simple_smp_defconfig
> +++ b/arch/openrisc/configs/simple_smp_defconfig
> @@ -1,4 +1,3 @@
> -CONFIG_CROSS_COMPILE="or1k-linux-"
>  CONFIG_LOCALVERSION="-simple-smp"
>  CONFIG_NO_HZ=y
>  CONFIG_LOG_BUF_SHIFT=14
> -- 
> 2.17.1
>