Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp2261818ybl; Thu, 30 Jan 2020 14:16:09 -0800 (PST) X-Google-Smtp-Source: APXvYqyccoxQUPugRyTQkRjM8hP5x1RsuBHZGliCbOlpXLvxjfELLalX/QDrcJZEhwNmAOnNTO5c X-Received: by 2002:a9d:23b5:: with SMTP id t50mr5169760otb.122.1580422569070; Thu, 30 Jan 2020 14:16:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580422569; cv=none; d=google.com; s=arc-20160816; b=Nsg97EOqOjbHWC1iv2mz++xbweX15pgyx87flIlOASOD5b2Cbtx7UFj30T7eJl98OD xK63uAqTAlEbeNgXmVyM7wjlf8e+WmKzqXl63n621bXL16Hx3L0RxGWOhWjAafz883m4 d15hDNIW9njFeyGHhIYrgkKc24C20TyMWaJMejHd4/LBLmNMRftiaH2edFbTzKBCaafv H+qz6jnuFu/DpDaIHA/Pxk/a0ibUcNw2DoPHzIKAJ72AoyO+vfP+StDItew/IfcESPgD HudSi0/DLprQBu86RT2M6Ke+w1Dwqg3Y+aqWSLogJbFVjXY7C7KlMQx1GQ/K7+TyXSPd vCNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=WctE6/uPL864LyWZFTVpoTt7ctgPlTuShJdS4Mru7ow=; b=Qv59h4vHc9boVLPD+Tf46/GAV5xHrKPWLJWELw7+/HITW1TmK45YDjAs1CpuBNz5PG tGaJbqrAXUBYz+0l2OiUP2Lv/CxGYrfDnYpn3eTIs0eAzlMf/Z45E43ytP9LTDdAa3Qu I8lEzncDqLb5az767RpYca48RcDMA0Z5H4b4vvngjGVVdsI2KGsJdXw4n8uKgTvmHL7h AKemQV8KCAjjkWFVuVhEE1zp/9Czi9LakGOUN46BiDvSbwwGcA0cxIq70zX61Tq77anP QKPUHE0DrG0NDftCXa37sNkT2yOFpvgIMccpoGRBYneyI3syBUtj39JxulSjdz07Ibxw 3Xsg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=s9ACRgpQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m11si3259575oim.223.2020.01.30.14.15.54; Thu, 30 Jan 2020 14:16:09 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=s9ACRgpQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726124AbgA3WOu (ORCPT + 99 others); Thu, 30 Jan 2020 17:14:50 -0500 Received: from mail.kernel.org ([198.145.29.99]:38972 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725907AbgA3WOu (ORCPT ); Thu, 30 Jan 2020 17:14:50 -0500 Received: from cakuba (unknown [199.201.64.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9273620707; Thu, 30 Jan 2020 22:14:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580422489; bh=Hh04uXBi7OcIx5ozha/taPqwFRcX5aRWOqzIboXiuHU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=s9ACRgpQmFHVWcx5jc0K+lNdf539SserYwTzfbdVUaTUnC72bjHFmygCrnuZfE5YA Fq2wn2udDI8nOuRa0iIxQqUBuI0H5aIv4+vAlGbBnR5UQ41+QE7ALfD8/n9YpQb9oa yxbZaXU5dQF8EM3PF6N4Qp57ZJ8F5vD3Mrf60/Ok= Date: Thu, 30 Jan 2020 14:14:48 -0800 From: Jakub Kicinski To: Pablo Neira Ayuso Cc: Matteo Croce , netdev@vger.kernel.org, linux-doc@vger.kernel.org, "David S. Miller" , Florian Westphal , linux-kernel@vger.kernel.org Subject: Re: [PATCH net] netfilter: nf_flowtable: fix documentation Message-ID: <20200130141448.27fa32aa@cakuba> In-Reply-To: <20200130191019.19440-1-mcroce@redhat.com> References: <20200130191019.19440-1-mcroce@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 30 Jan 2020 20:10:19 +0100, Matteo Croce wrote: > In the flowtable documentation there is a missing semicolon, the command > as is would give this error: > > nftables.conf:5:27-33: Error: syntax error, unexpected devices, expecting newline or semicolon > hook ingress priority 0 devices = { br0, pppoe-data }; > ^^^^^^^ > nftables.conf:4:12-13: Error: invalid hook (null) > flowtable ft { > ^^ > > Fixes: 19b351f16fd9 ("netfilter: add flowtable documentation") > Signed-off-by: Matteo Croce This is netfilter so even though it's tagged as net, I'm expecting Pablo (or Jon) to take it. Please LMK if I'm wrong.