Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [Patch v2 0/4] mm/mremap: cleanup move_page_tables() a little
To:     Wei Yang <richardw.yang@linux.intel.com>,
        akpm@linux-foundation.org, aneesh.kumar@linux.ibm.com,
        kirill@shutemov.name, dan.j.williams@intel.com,
        yang.shi@linux.alibaba.com, thellstrom@vmware.com
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org
References: <20200129002642.13508-1-richardw.yang@linux.intel.com>
From:   Dmitry Osipenko <digetx@gmail.com>
Message-ID: <50f408bd-502e-bd02-53d4-719300736ce2@gmail.com>
Date:   Fri, 31 Jan 2020 01:18:00 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.3.0
MIME-Version: 1.0
In-Reply-To: <20200129002642.13508-1-richardw.yang@linux.intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

29.01.2020 03:26, Wei Yang пишет:
> move_page_tables() tries to move page table by PMD or PTE.
> 
> The root reason is if it tries to move PMD, both old and new range should
> be PMD aligned. But current code calculate old range and new range
> separately.  This leads to some redundant check and calculation.
> 
> This cleanup tries to consolidate the range check in one place to reduce
> some extra range handling.
> 
> v2:
>   * remove 3rd patch which doesn't work on ARM platform. Thanks report from
>     Dmitry Osipenko
> 
> Wei Yang (4):
>   mm/mremap: format the check in move_normal_pmd() same as
>     move_huge_pmd()
>   mm/mremap: it is sure to have enough space when extent meets
>     requirement
>   mm/mremap: calculate extent in one place
>   mm/mremap: start addresses are properly aligned
> 
>  include/linux/huge_mm.h |  2 +-
>  mm/huge_memory.c        |  8 +-------
>  mm/mremap.c             | 17 ++++++-----------
>  3 files changed, 8 insertions(+), 19 deletions(-)
> 

Hello Wei,

I haven't noticed any problems using the v2. Thank you very much for
addressing the problem!

Tested-by: Dmitry Osipenko <digetx@gmail.com>