Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200128085742.14566-1-sjpark@amazon.com> <20200128090029.15691-1-sjpark@amazon.com>
In-Reply-To: <20200128090029.15691-1-sjpark@amazon.com>
From:   Brendan Higgins <brendanhiggins@google.com>
Date:   Thu, 30 Jan 2020 16:02:26 -0800
Message-ID: <CAFd5g45yXr-dNtgwUytVxwOGS5vfktZORNQ-p050cpN6W37bJQ@mail.gmail.com>
Subject: Re: [PATCH v2 6/9] mm/damon: Add minimal user-space tools
To:     SeongJae Park <sjpark@amazon.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        SeongJae Park <sjpark@amazon.de>,
        SeongJae Park <sj38.park@gmail.com>, acme@kernel.org,
        amit@kernel.org, brendan.d.gregg@gmail.com,
        Jonathan Corbet <corbet@lwn.net>, dwmw@amazon.com,
        mgorman@suse.de, Steven Rostedt <rostedt@goodmis.org>,
        kirill@shutemov.name, colin.king@canonical.com, minchan@kernel.org,
        vdavydov.dev@gmail.com, vdavydov@parallels.com, linux-mm@kvack.org,
        "open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jan 28, 2020 at 1:00 AM <sjpark@amazon.com> wrote:
>
> From: SeongJae Park <sjpark@amazon.de>
>
> This commit adds a shallow wrapper python script, ``/tools/damon/damo``
> that provides more convenient interface.  Note that it is only aimed to
> be used for minimal reference of the DAMON's raw interfaces and for
> debugging of the DAMON itself.  Based on the debugfs interface, you can
> create another cool and more convenient user space tools.
>
> Signed-off-by: SeongJae Park <sjpark@amazon.de>
> ---
>  MAINTAINERS               |   1 +
>  tools/damon/.gitignore    |   1 +
>  tools/damon/_dist.py      |  35 ++++
>  tools/damon/bin2txt.py    |  64 +++++++
>  tools/damon/damo          |  37 ++++
>  tools/damon/heats.py      | 358 ++++++++++++++++++++++++++++++++++++++
>  tools/damon/nr_regions.py |  88 ++++++++++
>  tools/damon/record.py     | 194 +++++++++++++++++++++
>  tools/damon/report.py     |  45 +++++
>  tools/damon/wss.py        |  94 ++++++++++
>  10 files changed, 917 insertions(+)
>  create mode 100644 tools/damon/.gitignore
>  create mode 100644 tools/damon/_dist.py
>  create mode 100644 tools/damon/bin2txt.py
>  create mode 100755 tools/damon/damo
>  create mode 100644 tools/damon/heats.py
>  create mode 100644 tools/damon/nr_regions.py
>  create mode 100644 tools/damon/record.py
>  create mode 100644 tools/damon/report.py
>  create mode 100644 tools/damon/wss.py
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 5a4db07cad33..95729c138d34 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -4616,6 +4616,7 @@ M:        SeongJae Park <sjpark@amazon.de>
>  L:     linux-mm@kvack.org
>  S:     Maintained
>  F:     mm/damon.c
> +F:     tools/damon/*
>
>  DAVICOM FAST ETHERNET (DMFE) NETWORK DRIVER
>  L:     netdev@vger.kernel.org

Another reason to put the MAINTAINERS update at the end; that way you
don't have multiple edits sprinkled around your patchset.