Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp242240ybl; Thu, 30 Jan 2020 21:16:24 -0800 (PST) X-Google-Smtp-Source: APXvYqx4a1gOfsPxeEKPtvuK+RsAW8fMgXb1gVABwuVvz9SKgzKmRNGVfxg1144N5GQhFijDVq/l X-Received: by 2002:a9d:6181:: with SMTP id g1mr6585837otk.104.1580447784310; Thu, 30 Jan 2020 21:16:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580447784; cv=none; d=google.com; s=arc-20160816; b=0tvu5Im+kGD5pYHMAzSqMupCex48y1T7NbgWrgyM0Kdyyh9qPLjCv+q25s3hA1l7Oa MZGu0eOeQXGxXT9VtrDYoZSxp7KpCOVvCZGgdVrgKh9Fd8jrFf4S5OVrysqSggjOUbAd l2qCOWO1jLtB2WboCduQXo59L67+nORUziEHOFxOpB0xC4FXdRlaEYpmyKPjZ2p8lezr SDyvIilozFIWmZESzV+ayTTYdsjj2q2OmTRC0zGOM0yQGbSE87IRUAqtKRffxsIAZm9b kiDZqo0yLViO3fMrK4ueYCwr6mTpYFSBrwlu1LMdq/Ab5RvcTcbQ833nW3c2KnuoE8Zk mXNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=PMcuS4LHry0i7DZ7ldtekzqzj8KrQxFLARw5rUFC3dY=; b=NeK5L2G5YgoVpbzZT5+VlceRzcEQ4msaRjVtn8h4+4ZlGpylpgzplwEBj58i++SkTP LWlyCXw+R4YMwFA3fvl4jw1VpqFlyMmhSKqr+oi/uDIQbSgqlIb+w8Tw68BfdeFJJouI NXugAS30Ytsm2/QWEUVGtrHpmzIn5M+ZiIVBxttETwGPr1R4zuT+PgNbcRMRZad6eFCI iE0YS1sPzAO4Xz2X7645iX6/DcoINvYyebH7rRoWm2CuQtL1WFDr+Rgwe0LXhHMAPRR4 G3ygA+um2NADVjKoaHFr7QLL3t3938g/Iqr9VPLXNciUzjIp4zyzeUY6cGP0adUsb51n 1EKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=YB4BUNeP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l84si3673243oig.5.2020.01.30.21.16.11; Thu, 30 Jan 2020 21:16:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=YB4BUNeP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726488AbgAaFOq (ORCPT + 99 others); Fri, 31 Jan 2020 00:14:46 -0500 Received: from mail-oi1-f193.google.com ([209.85.167.193]:33089 "EHLO mail-oi1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725263AbgAaFOp (ORCPT ); Fri, 31 Jan 2020 00:14:45 -0500 Received: by mail-oi1-f193.google.com with SMTP id q81so6174522oig.0 for ; Thu, 30 Jan 2020 21:14:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=PMcuS4LHry0i7DZ7ldtekzqzj8KrQxFLARw5rUFC3dY=; b=YB4BUNePIM6enPmASfYT3cwjHuMA+cOwjd5AU1JFMP5dn8Yq9YXqx0L53gjl6Gyzkl 5kG1BNLepiYkWJbao814Aj5KzNKw/SxFciSCG9pAPQ1Vl31Lb+FRijSu2RlvWwqxmz1V t5OFCVsaMUxgTHH27jx3c7DfQTOYiNeCNZHhh4U1dkxfAuDoeJ0RoCD5pWybXaXBKCgR 5lg6a4vN6IMCyAVqu8i3QQhIjzPPi0qOUgutCMcqCoyTr/+f3QgmReQ1QgRvUUQDoQAM nEeQT5nqUOxl1z7kuLI9kthwhBXP3Zyf9wOXQ/9C1+PkspbY4Qep23XKZEohNh4rbaAF 79HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=PMcuS4LHry0i7DZ7ldtekzqzj8KrQxFLARw5rUFC3dY=; b=GFnnt4tJK909RZRk1cxwd/YuYgW1N/eYc7mpx+MbiAWi06hm/ePPamfl/OcFqh7yAy R9Fnmjz3pqIbkMZWu51B3/H9RPtK/NVJDDNxaWT2+Euf92AcMRUFoWc0avfWzcjfRTcW nx0+VGOL9yv9SMj5Oig6jAo7H31Y+g9iOX7XzzdTiFO65VfNtpOvuAGPrGoZx6g/wjg2 Ur1mcHEPOy+WJHQDTOt2RiSqRsHGuFUHHvXR1h8BrwUOF5vS8dJ/wMQysadkbKLs9MW3 paJjKZjP0Lwp4JwXCRdob0O1HpUgrKUoW0HD9ZCfCrzW9CsLRHTTp5iBa4qEPA5IovI6 Pn7A== X-Gm-Message-State: APjAAAUi1TWQZyDQ66mApD6VwxOKYG4rTKoLgp4a4pFY6reX5PH2VGTz 6RdtcYl6eEshCU8hoo3P6Wi81k+5RXq+KAa1QJJ68A== X-Received: by 2002:a05:6808:a83:: with SMTP id q3mr5446118oij.0.1580447684795; Thu, 30 Jan 2020 21:14:44 -0800 (PST) MIME-Version: 1.0 References: <20191025044721.16617-1-alastair@au1.ibm.com> <20191025044721.16617-10-alastair@au1.ibm.com> <3ba57ce6-9135-0d83-b99d-1c5b0c744855@linux.ibm.com> In-Reply-To: From: Dan Williams Date: Thu, 30 Jan 2020 21:14:33 -0800 Message-ID: Subject: Re: [PATCH 09/10] powerpc: Enable OpenCAPI Storage Class Memory driver on bare metal To: "Alastair D'Silva" Cc: Frederic Barrat , Oscar Salvador , Madhavan Srinivasan , Geert Uytterhoeven , David Hildenbrand , Wei Yang , Keith Busch , Linux MM , Michal Hocko , Paul Mackerras , Ira Weiny , Thomas Gleixner , Pavel Tatashin , Dave Jiang , linux-nvdimm , Vishal Verma , Krzysztof Kozlowski , Anju T Sudhakar , Mahesh Salgaonkar , Andrew Donnellan , Arnd Bergmann , Greg Kurz , Qian Cai , =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , Hari Bathini , Greg Kroah-Hartman , Linux Kernel Mailing List , Vasant Hegde , Andrew Morton , linuxppc-dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 30, 2020 at 8:57 PM Alastair D'Silva wro= te: > > On Fri, 2019-11-08 at 08:10 +0100, Frederic Barrat wrote: > > > > Le 25/10/2019 =C3=A0 06:47, Alastair D'Silva a =C3=A9crit : > > > From: Alastair D'Silva > > > > > > Enable OpenCAPI Storage Class Memory driver on bare metal > > > > > > Signed-off-by: Alastair D'Silva > > > --- > > > arch/powerpc/configs/powernv_defconfig | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/arch/powerpc/configs/powernv_defconfig > > > b/arch/powerpc/configs/powernv_defconfig > > > index 6658cceb928c..45c0eff94964 100644 > > > --- a/arch/powerpc/configs/powernv_defconfig > > > +++ b/arch/powerpc/configs/powernv_defconfig > > > @@ -352,3 +352,7 @@ CONFIG_KVM_BOOK3S_64=3Dm > > > CONFIG_KVM_BOOK3S_64_HV=3Dm > > > CONFIG_VHOST_NET=3Dm > > > CONFIG_PRINTK_TIME=3Dy > > > +CONFIG_OCXL_SCM=3Dm > > > +CONFIG_DEV_DAX=3Dy > > > +CONFIG_DEV_DAX_PMEM=3Dy This specific line is not needed since DEV_DAX_PMEM already defaults to DEV= _DAX. > > > +CONFIG_FS_DAX=3Dy > > > > If this really the intent or do we want to activate DAX only if > > CONFIG_OCXL_SCM is enabled? > > > > Fred > > We had a bit of a play around with reworking this the other day. > > Putting them in as depends didn't make sense, as they are "soft" > dependancies - the driver works and you can do some things without DAX. > > Adding them as selects was rejected as selecting symbols that can also > be manually select is discouraged. > > We ended up going full circle and adding them back to the defconfig. This dovetails with a suggestion Dave made a while back [1]. Given all the pieces that need to be turned on to have a "feature complete" persistent memory enabled build it would be nice to have general config symbols that go and select all the necessary dependencies for DAX, and let the rest happen by default. [1]: https://lore.kernel.org/lkml/20161129021052.GF28177@dastard/