Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200124114914.27065-1-dafna.hirschfeld@collabora.com>
 <CAL_JsqKgNzY=KF8XzuGjw2NogBawfi0gh9ytrk_nw_Ewg2QDdg@mail.gmail.com>
 <9c4a971f-6a65-594e-4a79-9e2aa16e58cb@collabora.com> <d9888d47-f320-57f4-5773-454673e5762d@ti.com>
In-Reply-To: <d9888d47-f320-57f4-5773-454673e5762d@ti.com>
From:   Rob Herring <robh+dt@kernel.org>
Date:   Fri, 31 Jan 2020 08:56:28 -0600
Message-ID: <CAL_JsqL8DMhwUhn5RG6X5X=d20rmJyDWx-apecC_eAYLSGQppA@mail.gmail.com>
Subject: Re: [PATCH] dt-bindings: fix compilation error of the example in intel,lgm-emmc-phy.yaml
To:     Kishon Vijay Abraham I <kishon@ti.com>
Cc:     Dafna Hirschfeld <dafna.hirschfeld@collabora.com>,
        devicetree@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Helen Koike <helen.koike@collabora.com>,
        Ezequiel Garcia <ezequiel@collabora.com>,
        Collabora Kernel ML <kernel@collabora.com>, dafna3@gmail.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jan 27, 2020 at 6:21 AM Kishon Vijay Abraham I <kishon@ti.com> wrote:
>
>
>
> On 24/01/20 7:59 pm, Dafna Hirschfeld wrote:
> >
> >
> > On 24.01.20 15:03, Rob Herring wrote:
> >> On Fri, Jan 24, 2020 at 5:49 AM Dafna Hirschfeld
> >> <dafna.hirschfeld@collabora.com> wrote:
> >>>
> >>> Running:
> >>> export
> >>> DT_SCHEMA_FILES=Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.yaml
> >>>
> >>> 'make dt_binding_check'
> >>>
> >>> gives a compilation error. This is because in the example there
> >>> is the label 'emmc-phy' but labels are not allowed to have '-' sing.
> >>> Replace the '-' with '_' to fix the error.
> >>>
> >>> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
> >>
> >> There's a fix from the author, but you're first to get the fix
> >> correct, so:
> > Oh, sorry, I was not aware of that.
> > Dafna
> >
> >>
> >> Fixes: 5bc999108025 ("dt-bindings: phy: intel-emmc-phy: Add YAML
> >> schema for LGM eMMC PHY")
> >> Acked-by: Rob Herring <robh@kernel.org>
> >>
> >> Kishon, Please apply these soon as linux-next is broken.
> >>
>
> merged now, Thanks!

And please drop or revert this. It's still has failures:

Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.example.dts:23.13-33:
Warning (reg_format): /example-0/chiptop@e0200000/emmc-phy@a8:reg:
property has invalid length (8 bytes) (#address-cells == 2,
#size-cells == 1)
Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.example.dt.yaml:
Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.example.dt.yaml:
Warning (i2c_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.example.dt.yaml:
Warning (spi_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.example.dts:21.33-26.13:
Warning (avoid_default_addr_size):
/example-0/chiptop@e0200000/emmc-phy@a8: Relying on default
#address-cells value
Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.example.dts:21.33-26.13:
Warning (avoid_default_addr_size):
/example-0/chiptop@e0200000/emmc-phy@a8: Relying on default
#size-cells value


I'll send out a complete fix and take via the DT tree so maybe we can
have an rc1 that works.

Rob