Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp738515ybl; Fri, 31 Jan 2020 07:11:04 -0800 (PST) X-Google-Smtp-Source: APXvYqwnVnKfBbc32VgNNwLsL7r//jUbaefylrGXwGheoNzzm6nsju9aG+gizg6nrgV9cZAr27LP X-Received: by 2002:a9d:6181:: with SMTP id g1mr8272779otk.104.1580483464294; Fri, 31 Jan 2020 07:11:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580483464; cv=none; d=google.com; s=arc-20160816; b=g+YaBVnk5SOtMaKZgSK3uBTvk8sDk1tUd3UqU8gUxSMjgytxPFzWqHW9dBSj3dyC8a 2Q3RXA2+rGUKZnLiCwSmV72YIvhVI4XA7jdnls/iWlJpIoFXkM/0FfGhZgU7EunkAs5V fsAIugfzrBdVdCrY3hnTYdoohCgCt3keQFQKbdWSyYRrjGusovU0/2qHpO78WF8l/hdL lxU2Y4SS7JXxqP8uGRWiaHULxSceww50LqW5hRt1/GKubAgYUxnLc2DdYqPndzQCT+aV dCJIlMeq44ave640POze99JuyKHYJ8RNrNb9zVFMbgsZpGvk3DIHaenBT4+6RxU/jnP1 tnfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:in-reply-to:message-id:date :subject:cc:to:from:ironport-sdr:dkim-signature; bh=TWhifcpHB+dd048pcnCF4nKnIf/oG0lsDe/ax/0lEmw=; b=arkCrfbOkafBIuzN6LeaELuzvMOmi1xA2t+9Jf6yhjOUmVeKavksfY6jNgL9kPnuYl fUahym2Os4Fk73e9ZXLe31slNjM6N89CTOKMiBffQ4OEGwbhUt337JEYc0YYupEqpioa gz+jLReJYUvI2TJEuP5j1HqHtJB0nf9wXfe0koayTXBTrhGt2QOwH2BCUzbbUSkL5gyr E4ft+GIqE5/zlywTJVjtPihb3dPLao45Ks6Tr4Hyd6pzyk99TDf5/azqz/RwV3N0vjzs DBXgwz1OPFfWM4oEZ+4pEKAPFz+hZNy2tfW2h8s01kuFB7RXn8MB+/jvVUNijwfzpKze YyPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amazon.com header.s=amazon201209 header.b="JX/viUVY"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i8si4607625otp.254.2020.01.31.07.10.51; Fri, 31 Jan 2020 07:11:04 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@amazon.com header.s=amazon201209 header.b="JX/viUVY"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729260AbgAaPJh (ORCPT + 99 others); Fri, 31 Jan 2020 10:09:37 -0500 Received: from smtp-fw-33001.amazon.com ([207.171.190.10]:59720 "EHLO smtp-fw-33001.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729004AbgAaPJg (ORCPT ); Fri, 31 Jan 2020 10:09:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1580483376; x=1612019376; h=from:to:cc:subject:date:message-id:in-reply-to: mime-version; bh=TWhifcpHB+dd048pcnCF4nKnIf/oG0lsDe/ax/0lEmw=; b=JX/viUVYXWGUpQFjNc3f7m+0Ro8fR7SecP47z/QswizKyiFN5wEdMFI8 KCDFei+yqMoU4MA9UwdSgQ/XSNodLvL1zjHRfWhPt4W5oip8W0hK/YpPJ z3EC2q8Wn4EGXR6SzzlH+/SMrbZWHiStttYoeb5amSNRnl/KglPUZmgvX o=; IronPort-SDR: H6IgLyGs83Nn0RsWC4S5JdFqMKDINuBsVCNl3MoHrAyAVHYqYqtWbtvCpZXhKvSbSPEvXFTiez z3fLBQw8nkNw== X-IronPort-AV: E=Sophos;i="5.70,386,1574121600"; d="scan'208";a="23625855" Received: from sea32-co-svc-lb4-vlan3.sea.corp.amazon.com (HELO email-inbound-relay-2c-2225282c.us-west-2.amazon.com) ([10.47.23.38]) by smtp-border-fw-out-33001.sea14.amazon.com with ESMTP; 31 Jan 2020 15:09:24 +0000 Received: from EX13MTAUEA002.ant.amazon.com (pdx4-ws-svc-p6-lb7-vlan3.pdx.amazon.com [10.170.41.166]) by email-inbound-relay-2c-2225282c.us-west-2.amazon.com (Postfix) with ESMTPS id 4DD4EA25AC; Fri, 31 Jan 2020 15:09:24 +0000 (UTC) Received: from EX13D31EUA001.ant.amazon.com (10.43.165.15) by EX13MTAUEA002.ant.amazon.com (10.43.61.77) with Microsoft SMTP Server (TLS) id 15.0.1236.3; Fri, 31 Jan 2020 15:09:24 +0000 Received: from u886c93fd17d25d.ant.amazon.com (10.43.161.117) by EX13D31EUA001.ant.amazon.com (10.43.165.15) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Fri, 31 Jan 2020 15:09:19 +0000 From: To: Eric Dumazet CC: , David Miller , Shuah Khan , netdev , "open list:KERNEL SELFTEST FRAMEWORK" , LKML , , , SeongJae Park Subject: Re: Re: [PATCH 1/3] net/ipv4/inet_timewait_sock: Fix inconsistent comments Date: Fri, 31 Jan 2020 16:09:05 +0100 Message-ID: <20200131150905.27132-1-sjpark@amazon.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.43.161.117] X-ClientProxiedBy: EX13D29UWA001.ant.amazon.com (10.43.160.187) To EX13D31EUA001.ant.amazon.com (10.43.165.15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 31 Jan 2020 06:54:53 -0800 Eric Dumazet wrote: > On Fri, Jan 31, 2020 at 4:24 AM wrote: > > > > From: SeongJae Park > > > > Commit ec94c2696f0b ("tcp/dccp: avoid one atomic operation for timewait > > hashdance") mistakenly erased a comment for the second step of > > `inet_twsk_hashdance()`. This commit restores it for better > > readability. > > > > Signed-off-by: SeongJae Park > > --- > > net/ipv4/inet_timewait_sock.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/net/ipv4/inet_timewait_sock.c b/net/ipv4/inet_timewait_sock.c > > index c411c87ae865..fbfcd63cc170 100644 > > --- a/net/ipv4/inet_timewait_sock.c > > +++ b/net/ipv4/inet_timewait_sock.c > > @@ -120,6 +120,7 @@ void inet_twsk_hashdance(struct inet_timewait_sock *tw, struct sock *sk, > > > > spin_lock(lock); > > > > + /* Step 2: Hash TW into tcp ehash chain. */ > > This comment adds no value, please do not bring it back. > > net-next is closed, now is not the time for cosmetic changes. > > Also take a look at Documentation/networking/netdev-FAQ.rst Thank you for this kind reference. Will drop this in next spin. Thanks, SeongJae Park >