Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: KVYn3WWRFZcf3tBkHpyDu7mmLFvMRWRoxr8gDHFHRpJ7/4LVKKqIClS8gp9SN7t9eoYm0+9Rda
 Ar54+gtUYhcA==
From:   <sjpark@amazon.com>
To:     Eric Dumazet <edumazet@google.com>
CC:     <sjpark@amazon.com>, David Miller <davem@davemloft.net>,
        Shuah Khan <shuah@kernel.org>, netdev <netdev@vger.kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, <sj38.park@gmail.com>,
        <aams@amazon.com>, SeongJae Park <sjpark@amazon.de>
Subject: Re: Re: [PATCH 3/3] selftests: net: Add FIN_ACK processing order related latency spike test
Date:   Fri, 31 Jan 2020 16:13:02 +0100
Message-ID: <20200131151302.28040-1-sjpark@amazon.com>
In-Reply-To: <CANn89iJrwVuEUHFqH1iCJd3nwTWAuXCdEJozwz6gzDV5Snm3Ug@mail.gmail.com> (raw)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 31 Jan 2020 06:56:13 -0800 Eric Dumazet <edumazet@google.com> wrote:

> On Fri, Jan 31, 2020 at 4:25 AM <sjpark@amazon.com> wrote:
> >
> > From: SeongJae Park <sjpark@amazon.de>
> >
> > This commit adds a test for FIN_ACK process races related reconnection
> > latency spike issues.  The issue has described and solved by the
> > previous commit ("tcp: Reduce SYN resend delay if a suspicous ACK is
> > received").
> >
> 
> I do not know for other tests, but using a hard coded port (4242) is
> going to be flakky, since the port might be already used.
> 
> Please make sure to run tests on a separate namespace.

Agreed, will do so in next spin.


Thanks,
SeongJae Park