Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] Revert "ASoC: tegra: Allow 24bit and 32bit samples"
To:     Dmitry Osipenko <digetx@gmail.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        Ben Dooks <ben.dooks@codethink.co.uk>
CC:     <alsa-devel@alsa-project.org>, <linux-tegra@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>
References: <20200131091901.13014-1-jonathanh@nvidia.com>
 <2bb53d7d-2d36-e16e-5858-24360b19f936@gmail.com>
From:   Jon Hunter <jonathanh@nvidia.com>
Message-ID: <7fafb8d2-8754-e5c0-8952-0253ba8b656a@nvidia.com>
Date:   Fri, 31 Jan 2020 16:08:18 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <2bb53d7d-2d36-e16e-5858-24360b19f936@gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 31/01/2020 15:38, Dmitry Osipenko wrote:
> 31.01.2020 12:19, Jon Hunter =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
>> Commit f3ee99087c8ca0ecfdd549ef5a94f557c42d5428 ("ASoC: tegra: Allow
>> 24bit and 32bit samples") added 24-bit and 32-bit support for to the
>> Tegra30 I2S driver. However, there are two additional commits that are
>> also needed to get 24-bit and 32-bit support to work correctly. These
>> commits are not yet applied because there are still some review comments
>> that need to be addressed. With only this change applied, 24-bit and
>> 32-bit support is advertised by the I2S driver, but it does not work and
>> the audio is distorted. Therefore, revert this patch for now until the
>> other changes are also ready.
>>
>> Furthermore, a clock issue with 24-bit support has been identified with
>> this change and so if we revert this now, we can also fix that in the
>> updated version.
>>
>> Cc: stable@vger.kernel.org
>>
>> Reported-by: Dmitry Osipenko <digetx@gmail.com>
>> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
>> ---
>=20
> Thanks, Jon!
>=20
> Tested-by: Dmitry Osipenko <digetx@gmail.com>

Thanks. I just realised I forgot the fixes-tag ...

Fixes: f3ee99087c8c ("ASoC: tegra: Allow 24bit and 32bit samples")

Mark, let me know if you want me to resend.

Jon

--=20
nvpublic