Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 31 Jan 2020 09:40:56 -0800
From:   Davidlohr Bueso <dave@stgolabs.net>
To:     "Paul E. McKenney" <paulmck@kernel.org>
Cc:     josh@joshtriplett.org, linux-kernel@vger.kernel.org,
        will@kernel.org, peterz@infradead.org
Subject: Re: [PATCH RFC locktorture] Print ratio of acquisitions, not failures
Message-ID: <20200131174055.slzlp33qeefbzgdw@linux-p48b>
References: <20200123172707.GA24441@paulmck-ThinkPad-P72>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <20200123172707.GA24441@paulmck-ThinkPad-P72>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 23 Jan 2020, Paul E. McKenney wrote:

>The __torture_print_stats() function in locktorture.c carefully
>initializes local variable "min" to statp[0].n_lock_acquired, but
>then compares it to statp[i].n_lock_fail.  Given that the .n_lock_fail
>field should normally be zero, and given the initialization, it seems
>reasonable to display the maximum and minimum number acquisitions
>instead of miscomputing the maximum and minimum number of failures.
>This commit therefore switches from failures to acquisitions.

This makes sense, thanks!

>
>Reported-by: Will Deacon <will@kernel.org>
>Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
>Cc: Davidlohr Bueso <dave@stgolabs.net>
>Cc: Josh Triplett <josh@joshtriplett.org>
>Cc: Peter Zijlstra <peterz@infradead.org>

Acked-by: Davidlohr Bueso <dbueso@suse.de>