Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Davidlohr Bueso <dave@stgolabs.net>,
        Alex Shi <alex.shi@linux.alibaba.com>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] locking/rtmutex: remove unused cmpxchg_relaxed
In-Reply-To: <20200131173922.hjvugxuybrn2wbsn@linux-p48b>
References: <1579595686-251535-1-git-send-email-alex.shi@linux.alibaba.com> <20200131173922.hjvugxuybrn2wbsn@linux-p48b>
Date:   Fri, 31 Jan 2020 21:23:01 +0100
Message-ID: <87r1zfxtne.fsf@nanos.tec.linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Davidlohr Bueso <dave@stgolabs.net> writes:
> On Tue, 21 Jan 2020, Alex Shi wrote:

  Subject: locking/rtmutex: remove unused cmpxchg_relaxed

should be

  Subject: locking/rtmutex: Remove unused rt_mutex_cmpxchg_relaxed()

You're not removing cmpxchg_relaxed, right?

>> No one use this macro after it was introduced. Better to remove it?

Please make that factual.

 The macro was never used at all. Remove it.

> You also need to remove it for the CONFIG_DEBUG_RT_MUTEXES=y case.

Yes.

> Hmm unrelated, but do we want CCAS for rtmutex fastpath? Ie:
>
>      (l->owner == c && cmpxchg_acquire(&l->owner, c, n) == c)
>
> That would optimize for the contended case and avoid the cmpxchg - it would
> also help if we ever do the top-waiter spin thing.

Not sure if it buys much, but it kinda makes sense.

Thanks,

        tglx