Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1114494ybl; Fri, 31 Jan 2020 14:25:26 -0800 (PST) X-Google-Smtp-Source: APXvYqzb2mWSCQ8VI5i9L/d8EL7v0FRdwrPt1WG6yU9gwvL54QMIFAcDhmNzPvMfUWL5MLDn7eMQ X-Received: by 2002:a05:6808:b18:: with SMTP id s24mr7645806oij.31.1580509526018; Fri, 31 Jan 2020 14:25:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580509526; cv=none; d=google.com; s=arc-20160816; b=JSRQtW3iCbj+9Jd8wtYipj/rrL3UoCvdFDYWcZ90A1T15iyKKnHEXPaHOd4IgX05NR y4Ehx+2lNZTusIFSbzJefI8BSg1fOR4cHej7zzA4F01eZuiAtHSkQ33nSiBNiY3WHllE b4XGT4zfQYqAv6rntk5xfxoqAYIqr5RL7wO0EnJWKjjMC45b07fAjGs9Gh/jnvjJlHgx rG4e7LVMet3mD++ct5EiaAkrn9GisR3RR3oA4SpuO/yzTXZTWjMRBZdxnhwakD3+29SY X+Ejl0EGRRleLfUbYAX9/ph9ITa3WfYXVHmqvkPwG5u4yYMNYztg1QVqdWlW4j+2Qy/g vnAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:dkim-signature; bh=oNPDXr5T2F3ltBr6ZWUFkUTRD5GIjwn23cg1EDJm7Qc=; b=RQhr99BDkTQvIW/gmBgSmETonu+p6OP0sAR6NY9EvRO33QvknnJep8tHy8tP2+T8eM OiLm8In7FDKtqLzyTZcG6ClfCs0t+/g3r3gqy9k74uT9fjGaSIK2sy+exhlN9rOiB1yz SzA21nElugIXOC19URpxCVg8LH1s6OvcMRXTSu3OImNIVAPq9KTlUMl42tTXosRqC8fc ysp1zg0bH48KuYwwv5LvXx2mKuODc9RMjh13JUaX1nuwE176eL6Fy91cWS9Nb08oicRo 4tFnuktCx5t8ThI9DdHsBNuEw+sl1Ikn/yEHCfHS0ArU6NP9IYrEDdHeznyZCtWt1BcL vEuA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=he0YCpvP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t12si5587633otm.224.2020.01.31.14.25.14; Fri, 31 Jan 2020 14:25:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=he0YCpvP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726373AbgAaWYJ (ORCPT + 99 others); Fri, 31 Jan 2020 17:24:09 -0500 Received: from mail-pf1-f196.google.com ([209.85.210.196]:35891 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726180AbgAaWYJ (ORCPT ); Fri, 31 Jan 2020 17:24:09 -0500 Received: by mail-pf1-f196.google.com with SMTP id 185so4085361pfv.3 for ; Fri, 31 Jan 2020 14:24:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=oNPDXr5T2F3ltBr6ZWUFkUTRD5GIjwn23cg1EDJm7Qc=; b=he0YCpvPIXitkS2gkBPL7SoeIrDKJ6TyukF76x/Odh2lowB7nunGusPhq/d4ccAJKo w9snSRWXHEqoPw0uC4UfmOa/YxRkzBM4y0IncMjvWnm8BTlSvbpz0kIOJTF5NBwvzt1I GFarbrT5hGOVCKGgTj+B64Zxc3ObuJR5Wxvlf4nXLAuH/stizMkhu9XxTr0NMywPpGXa FgMjJjW0oai/+kJeUc99yV5YVuA3PGQX61Hj3YLkNCkqfzheOYSA052mK5tcZsh9iHQR n+wzROfVBw1/+JU/QpCXDwSiqH3LfEKAIZrcEkTP3flw7WJ6c6HCJRYTIlO/htosbNVJ jnuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=oNPDXr5T2F3ltBr6ZWUFkUTRD5GIjwn23cg1EDJm7Qc=; b=lxf+KaigjR1dET3rJCq1xD44O/R3JqF8UfAb2E58n1ZnQ4pPdLkXX813KQPWXTcHMT 6cm0X7dw0y+9Ms7jSsdX2gv8r7wsTrXldC24/RJFK7tlN3Vds2YmwYDMQ/hzyshDvk+c VzJc7/E018NMLiLkWRWkkIsr5llxyY4RPlryiqzLFIVR2YBN3R2h0cofpO6vPy+XgIjX MtvJazQv+IpJuXAfX14j6THPp0MgkEw0GXTd0lrPQIL+LBo+FE/T3wJmXHrOXE52G6/m I0sNM0KtX4UwVj5BIAJI+Y8DbZ45eWcEQgZL7qMx+EHQw3msG1tr/LTIrD9HppHB95Lq zaOQ== X-Gm-Message-State: APjAAAViNsZb9oWfu7yValhHlbbcEn6mCRShUNP9vczOG91/6QcaDHlj 5DdqKUs+p1Syq6NDRWW+nw9c9zwdpVQ= X-Received: by 2002:a63:2309:: with SMTP id j9mr2382056pgj.54.1580509447440; Fri, 31 Jan 2020 14:24:07 -0800 (PST) Received: from [192.168.1.188] ([66.219.217.145]) by smtp.gmail.com with ESMTPSA id j7sm966255pji.7.2020.01.31.14.24.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Jan 2020 14:24:06 -0800 (PST) Subject: Re: [PATCH 1/1] io_uring: remove extra ->file check To: Pavel Begunkov , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org References: From: Jens Axboe Message-ID: <649d912f-704b-d362-2bc7-1217840de672@kernel.dk> Date: Fri, 31 Jan 2020 15:24:05 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/31/20 3:22 PM, Pavel Begunkov wrote: > It won't ever get into io_prep_rw() when req->file haven't been set in > io_req_set_file(), hence remove the check. Applied for 5.6, thanks. -- Jens Axboe