Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1386594ybl; Fri, 31 Jan 2020 20:51:25 -0800 (PST) X-Google-Smtp-Source: APXvYqyutucGp1IooURkpayi7+t690yDF7Ez8pJ8pzdUm9Zh9RrxKJz4B/zNSlBzTD+RzwtzRpRl X-Received: by 2002:a9d:6e14:: with SMTP id e20mr10754708otr.283.1580532684867; Fri, 31 Jan 2020 20:51:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580532684; cv=none; d=google.com; s=arc-20160816; b=L46wJVrORmkHQSB+VQFDTM2ogN+5iPdLUbK3rzAy1fbxrgfkbPBlkoMbJNjtjEgJbo vm2KpQtXZp+UFKg+JpB6197cBcIOOeRKjM7mJz1PVky5J/299BG7HyRW9Z23pfaN9+ah nG9wm1RnVji+NysCo9ibhPieir/O1UdlDjp+vEFr991l5DHvfBIUhlnM9ILCGZysdB3t L0rMLqLup0NP8njvt8gWw2gXyJyxw2R2BVJd5IuFUwLMA1/ObSH+tUF7QypFgP2+hfKW JhdTRjFtxS5fMFk2bXC5e+xcMPehbPhATgu+PHPP6nBDAp2A5s9kMjekzaLumBKJCg6V G5Kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=SDiRJgIexvsCRZyBGBkTLxhYXwLjtWjl6c8nsRIE3KI=; b=whPZseVYsjI44uMu54Y0szKiNYT4UNh91yhDTdDTgwG6uG5FzVaLW9+1OLOGCcKruI DJCidp8arpr8hOS25jsDG/X7YTBmJZKjA+MEU2Ul9aMWU2i51V5TjgkYj5l4uHscW+29 DmauJYHEgkv7XXETF2xPI9Xetxv+mq/s+3rA3Bvs5vEBHxB8iqD1DpM7G1TWIsu9AuFs djFWnb5oeqK6BEasSXgkCIVQa+gWjepDKEgSKP9LP8bjHQhiHop7EPLiyhVpCv8xsUsG yCeLsDH/qa5CgenzCdbAfonJY6YZZXQTPZCxdbYgsfdIu9TZsTQdW19b3oCAheU9OEty 5FYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=HBZz1k+W; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s77si5313708oih.51.2020.01.31.20.51.12; Fri, 31 Jan 2020 20:51:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=HBZz1k+W; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727145AbgBAEsv (ORCPT + 99 others); Fri, 31 Jan 2020 23:48:51 -0500 Received: from mail-pg1-f193.google.com ([209.85.215.193]:41060 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726772AbgBAEsu (ORCPT ); Fri, 31 Jan 2020 23:48:50 -0500 Received: by mail-pg1-f193.google.com with SMTP id l3so583218pgi.8 for ; Fri, 31 Jan 2020 20:48:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=SDiRJgIexvsCRZyBGBkTLxhYXwLjtWjl6c8nsRIE3KI=; b=HBZz1k+Wprky9UL45iCfSEdfdTFJ3ZF6QhbNruPR0fUAbcYvUerrtVj7qkTM047lft 8BElWoGLtA/lNBXCt2J+ks/ph1k2Hza6tplCjFwGcM7mZUho5XfOjlqFoS2o1H8gXket Yw8F9ap1aqe7PZ3c6pAyyrawdUZe/SMbgOy3gKMW+uAtVh5qnnljKK2L7Qf0IOqCcMHT xyUHKX3uyc6rGLHboDxnhFAR8iwpzBDOlLjeO3fq5lokQqHMloU+yqA1Wcy3+8M+1Fz4 tadcu2Ak1t5pgBFPxY/E75URx36YERI4lJeXY+UMEsXL+zuU3VLOvBk9sjipG5/yh7D9 hAsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=SDiRJgIexvsCRZyBGBkTLxhYXwLjtWjl6c8nsRIE3KI=; b=IlfEmuMuOIUtQIq0RuxxujEuRXA/UgSN9JNt6cGFFYw0lNDFmloftCwzHEcMZreyWY iAVVdpVhNLI9kWmIZMbVMMK1FssWy32wByKb3Y1fbE7Th/9QuUC7Yr/Gs9TSZRvVGCW2 n8kS5zv+Bmo8QJiZtshGLLoD1wugrldv2gLmxV6JSvROLAY93ih37NrOD9Q1rUq5fPK1 fiRRipIy1wK0BB6q5JUJe1SH+eyr3t6OZdM3V7kNHLjfuXNPeuWr8shoCDC7UR6WmPoJ eBiYDf2SdeR7XcS3BloDEh1HjlD94xw1wUkryRe/PjE2wX8JpmLUasy0qntKjoDGgbuX 6kwQ== X-Gm-Message-State: APjAAAXIIpeC0swLOPHwTX19aOzSc8uC2iQzE7hpjtmnLOO7ZnVlTiK6 J3dDdXBwSTVEYou0b5Qf5rOO/w== X-Received: by 2002:a63:f148:: with SMTP id o8mr14545058pgk.314.1580532530019; Fri, 31 Jan 2020 20:48:50 -0800 (PST) Received: from [192.168.1.188] ([66.219.217.145]) by smtp.gmail.com with ESMTPSA id d24sm13108879pfq.75.2020.01.31.20.48.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Jan 2020 20:48:49 -0800 (PST) Subject: Re: [PATCH BUGFIX 0/6] block, bfq: series of fixes, and not only, for some recently reported issues To: Paolo Valente Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, bfq-iosched@googlegroups.com, oleksandr@natalenko.name, patdung100@gmail.com, cevich@redhat.com References: <20200131092409.10867-1-paolo.valente@linaro.org> From: Jens Axboe Message-ID: Date: Fri, 31 Jan 2020 21:48:47 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200131092409.10867-1-paolo.valente@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/31/20 2:24 AM, Paolo Valente wrote: > Hi Jens, > these patches are mostly fixes for the issues reported in [1, 2]. All > patches have been publicly tested in the dev version of BFQ. > > Thanks, > Paolo > > [1] https://bugzilla.redhat.com/show_bug.cgi?id=1767539 > [2] https://bugzilla.kernel.org/show_bug.cgi?id=205447 > > Paolo Valente (6): > block, bfq: do not plug I/O for bfq_queues with no proc refs > block, bfq: do not insert oom queue into position tree > block, bfq: get extra ref to prevent a queue from being freed during a > group move > block, bfq: extend incomplete name of field on_st > block, bfq: get a ref to a group when adding it to a service tree > block, bfq: clarify the goal of bfq_split_bfqq() > > block/bfq-cgroup.c | 12 ++++++++++-- > block/bfq-iosched.c | 20 +++++++++++++++++++- > block/bfq-iosched.h | 3 ++- > block/bfq-wf2q.c | 27 ++++++++++++++++++++++----- > 4 files changed, 53 insertions(+), 9 deletions(-) I wish some of these had been sent sooner, they really should have been sent in a few weeks ago. Just took a quick look at the bug reports, and at least one of the bugs mentions looks like it had a fix available 2 months ago. Have they been in -next? They are all marked as bug fixes, should they have stable tags? All of them, some of them? -- Jens Axboe