Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1479775ybl; Fri, 31 Jan 2020 23:14:07 -0800 (PST) X-Google-Smtp-Source: APXvYqy13a6ZeBDfiE4W9odQ9UPlEEbh0ZCdG8oCwhtoCSULyhX4dEUJuTLuDTvrzsJP9bBzPh0T X-Received: by 2002:a05:6808:4c2:: with SMTP id a2mr8351653oie.118.1580541247173; Fri, 31 Jan 2020 23:14:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580541247; cv=none; d=google.com; s=arc-20160816; b=mlkPVTU/8A8+vSHYGbaWsA06rhqmXt2V3cobu2UEP3KwF7GgrONEBbcpp0gqA24p26 la6MhoQXcBk2O4lkw2dyRp4rPmCBo7SyJl+LcLzUzOn3crE7CLxDhVsq5hbWgsvz8/bw RZzcpP1T3ALadA+vpTtJf/MESo5Y5f2EdG68oAPLD0z3hDEig3DAv3q1Eq8Vfuky7q/p pjlAY7vA7wCC5iWdMB0rSDL69ECQ3i4rrLTeFjLEkjbO+vl/0xRO76gm+TR+giWnDGvK FzPGGZ+uMnLIHG0X6uqy6NYyzUGTAL0w1zF9QlOnRqdHvnZjjnmZh0AdlP4L2RIP3hfl 4usw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=b6qV3aMBeymGzLwDJRcGDsmyIzVeO9ybJtBlK6sW1Ak=; b=xAYYr8FBBqfFATfM0CIWB4Uc+kGnHsOflAfWIK0n6iUxy/Nevv6N6toGNlUCmVzX3H IHEGBZmEzWvUXsbPvkJcf6TUf7PXogM0bYqIoXdRUWWZNbEjBh3GrcbcBp3tm79dep1E NoIa66M3FSUrK8rt8qiO6oqc25Fam0iA4P7Fy0nY2YbtVxi59GGDWxyFvQc36SgZDw0k BD6eSTBEJo9QSEJvLoIn5CRppvHH1c4cZk8hjry0VSfvJRGk1ErjSwKfUYcZARMXkgKz OMes1Sj8cpKH4iciKlR/j3bz49lRGmfdt+We3KiqEbvxL0gJ8XnwJrysvEwmvn4mt7VL oqlg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=LT4tkcJp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m24si5406522oic.11.2020.01.31.23.13.55; Fri, 31 Jan 2020 23:14:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=LT4tkcJp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726169AbgBAHND (ORCPT + 99 others); Sat, 1 Feb 2020 02:13:03 -0500 Received: from mail-pl1-f195.google.com ([209.85.214.195]:35462 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726038AbgBAHND (ORCPT ); Sat, 1 Feb 2020 02:13:03 -0500 Received: by mail-pl1-f195.google.com with SMTP id g6so3718913plt.2 for ; Fri, 31 Jan 2020 23:13:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=b6qV3aMBeymGzLwDJRcGDsmyIzVeO9ybJtBlK6sW1Ak=; b=LT4tkcJpdMfNNjkKcPBf926I0IBovmA+IhxmnwugQweMj1ahP8yxKDCC0CsQKJGij0 igofp9nDM5c+Fn0g8DZdNLQM5eq50jT+e4/s+p4idkcY63MEs+WAKZt2AiA2IKCwE6Fv xohhNaF7g0WmJzrJTqMiRV+dXbVCp1NdIiEpQMdvQb26urB95RgaHIrs38IdkjR3krgF BBxbTRjigrhqN9LAtdsbGAj6CdWfMGbvytuUvm/4Kop3y5ZhAcjHEotq8c5adp1/6+wn QXeUoEejdU78JxX8dT5ELHqqDj0U7XO/TIGdHxUo5VOuFNhUYW5w498FVRdrsZqCm0hK tQwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=b6qV3aMBeymGzLwDJRcGDsmyIzVeO9ybJtBlK6sW1Ak=; b=ckbipmaWB2Sy6k6hI/3U3sIse5Szz4iUhYJTvo184dP41DVdhgKpfo9s+/5nh6Numc qX8SZ0c6Eik0LReUk56gBioW6Z0/nPzu2pq3TKEpFym50Be0Z9Lc2tnu+HfPpsL3X/Yi ytMFT4g+cAXqFLVBDxI8VE/oy17sp9TWNwQRB283lfCMTmVwcPLVUHrXgBwgrdHMGIc0 wScWQ6wrD/SFZViqGN32sx2gbLuck+TziCFAgwE+fDFSOrakGeUl8lLQjCtJwKzeFIPc UQcMLr1JCQLJdK7QEuCMxMuO00bSlhCLMt7VA66UZTeOke0Hgn9pcyfAhPtrGOY7HouA pKQg== X-Gm-Message-State: APjAAAUqektNeMnK272TojxwZEFwtZ9KaJr3Et2ljqjTk4s1yxKwYAfd C68L33783bOcvcFulXdLlJziDkkp89Y= X-Received: by 2002:a17:902:8bc1:: with SMTP id r1mr10192161plo.279.1580541182756; Fri, 31 Jan 2020 23:13:02 -0800 (PST) Received: from localhost ([43.224.245.179]) by smtp.gmail.com with ESMTPSA id k5sm12372180pju.29.2020.01.31.23.13.01 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 31 Jan 2020 23:13:02 -0800 (PST) From: qiwuchen55@gmail.com To: mark@fasheh.com, jlbec@evilplan.org, joseph.qi@linux.alibaba.com, trivial@kernel.org Cc: ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org, chenqiwu Subject: [PATCH] ocfs2: remove trivial nowait check for buffered read/write Date: Sat, 1 Feb 2020 15:12:58 +0800 Message-Id: <1580541178-7853-1-git-send-email-qiwuchen55@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: chenqiwu Remove trivial nowait check for buffered read/write, since buffered read is checked in generic_file_read_iter()-> generic_file_buffered_read(), buffered write is checked in generic_write_checks(). Signed-off-by: chenqiwu --- fs/ocfs2/file.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c index 9876db5..6a5e3b0 100644 --- a/fs/ocfs2/file.c +++ b/fs/ocfs2/file.c @@ -2298,9 +2298,6 @@ static ssize_t ocfs2_file_write_iter(struct kiocb *iocb, file->f_path.dentry->d_name.name, (unsigned int)from->nr_segs); /* GRRRRR */ - if (!direct_io && nowait) - return -EOPNOTSUPP; - if (count == 0) return 0; @@ -2453,9 +2450,6 @@ static ssize_t ocfs2_file_read_iter(struct kiocb *iocb, goto bail; } - if (!direct_io && nowait) - return -EOPNOTSUPP; - /* * buffered reads protect themselves in ->readpage(). O_DIRECT reads * need locks to protect pending reads from racing with truncate. -- 1.9.1