Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1888317ybl; Sat, 1 Feb 2020 08:30:45 -0800 (PST) X-Google-Smtp-Source: APXvYqwd9xum66JwMI2hIEuLAr13bT6oQwbeF+mRGtt5PYvy4l4JJhFxJCSJCn7ry81kixA/yIt8 X-Received: by 2002:aca:72d0:: with SMTP id p199mr10230899oic.40.1580574645238; Sat, 01 Feb 2020 08:30:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580574645; cv=none; d=google.com; s=arc-20160816; b=YU1hefeBs6ZCNwohZIcekVDZt9fZaHPwLiAmmzRsOHxE/Hb7QiyaOC9pKDdyPgKxV2 gzxGpvmTy+ZnUzyo8mExC54V7hKuqnzBBXLhXWMmjrk9vUosh/l9KUNAsRBw6VR33j5f C3ZUIxhRmKeoNyW4qIRx/btkqXhW7OPW/NxZIOYLcU3N7gU03NEaVI9Pkds1TwJqkojS wxNMLMgsk1/8w7Jnij8/DQFrS5msdWJfwCo9YQtHOClzo72JxSzRNGyTnjh/HgNdu8no 7ZA/8vTXqxoTYNuhdB56PKPB4sjwjmPlavyMsrFHFCfNMFBhW2fg2fC8qJ4UqvU2P3we aqig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:dkim-signature; bh=mklDpQSOx56X51WlKAqZtd/5MRjLcpIQ1Es0sl44ojw=; b=FIp1qP2CcOHPNEOF+zfewypI6wnWM0HVLcGh/0MpOTCsWtvCWxQnyAO/C9FInDida4 tN3u4b+pJi7QcE79HY3E/POeWlbAi2TRGGCY6cpIYsxzDeUML8u1/elznvidR++0j4hr Ha7qyqy5lcDAd+XdW/VBr0iam816RWe3EmpnAYA7bPXkm+gZRHS1tQe4ONock1pCZL8n sZrOZBVypC1WFV2o+Rx/Z4fj7JRo/6DtWlAwjN0L/7GX3194jpKVPK/RsMTaN/cso2Pz /aX2p6jMPMEAUvsuIHUl2Q+ayh19nGYnWpxDCD/+9NpRAARBe4mfBoOFrmQ6ZgvPf+Bv bRMw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=yB4T4q+3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s15si5463876oih.252.2020.02.01.08.30.32; Sat, 01 Feb 2020 08:30:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=yB4T4q+3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726947AbgBAQ2o (ORCPT + 99 others); Sat, 1 Feb 2020 11:28:44 -0500 Received: from mail-pj1-f41.google.com ([209.85.216.41]:50226 "EHLO mail-pj1-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726622AbgBAQ2n (ORCPT ); Sat, 1 Feb 2020 11:28:43 -0500 Received: by mail-pj1-f41.google.com with SMTP id r67so4335837pjb.0 for ; Sat, 01 Feb 2020 08:28:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=mklDpQSOx56X51WlKAqZtd/5MRjLcpIQ1Es0sl44ojw=; b=yB4T4q+3CDaLF5gscpyaw7VYcN/mkrBVX/QUVuJUuq5NgF7YDZ6B9YyskYhdsQTy3Y Q/+D8IPZQMwTQ3WPcOttfsUiaq5IPmRoBjVyM20ycxSsu+jYBd/E4wAj5RpeC//j5RYO HRw/YUK6w39O3os/xVXdU56+QZzRONXEyVksu/YBNfzyqFZ8+lhCxfPQmcMiRHOKxdql XxzcV7ZpCwtFE600P3319Nw0SdhrnZikoftK8l4eGL4xcpI5/Q/iOG14reK0/NYnyruE qGFIoNGm9FjmAInisKQlxgaEUOzDlugnqW5G4GbowI+ujF9ZhVIvq2WFKlVWnmQOWO6h 2pOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=mklDpQSOx56X51WlKAqZtd/5MRjLcpIQ1Es0sl44ojw=; b=E6sbVfPGfYKKWsdXLz23bHeNMUSaW8B1/lF9XfBvbaqtqHf8nyiNHaX0yez0yKSkf0 Yi1fshv4vYuCZflqq/KQobpqW7uHHeW3vTsRtBeOof/7tIay987UEwRrsY9pbb3xffzl dqKDGXZUJIfQIgsWU0V6gEQ4KV6IGtGeIg0AnBrc5iqOmDfMJoPaKYYS16xFWjy40k5e t3A2gra0yBstFzjgBIUVMKEurmtyo47oKUI61asfZryJvdLrJK9QkQr8IJq6+pyzFaQy Izn40QKucmWr2rTV4oI028dQHFoqxA4vVq0c4cSp8c8vEIWV1JWPaEsBSw4YweetstfX hBdg== X-Gm-Message-State: APjAAAUYANPLLCrRZyo78c5/foMO18BIWC/TiBS1LUAUzS0l9X2KNCF7 GQQK43C/DV9oHLgNyExf7YmDDhsVmyI= X-Received: by 2002:a17:902:968c:: with SMTP id n12mr15906957plp.144.1580574522316; Sat, 01 Feb 2020 08:28:42 -0800 (PST) Received: from [192.168.1.188] ([66.219.217.145]) by smtp.gmail.com with ESMTPSA id v4sm15364475pgo.63.2020.02.01.08.28.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 01 Feb 2020 08:28:41 -0800 (PST) Subject: Re: [PATCH 1/1] io_uring: place close flag changing code To: Pavel Begunkov , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org References: From: Jens Axboe Message-ID: <9dd02612-5c5b-9508-d7cd-39212d526e14@kernel.dk> Date: Sat, 1 Feb 2020 09:28:39 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/31/20 5:58 PM, Pavel Begunkov wrote: > Both iocb_flags() and kiocb_set_rw_flags() are inline and modify > kiocb->ki_flags. Place them close, so they can be potentially better > optimised. Applied, thanks. -- Jens Axboe