Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] ocfs2: remove trivial nowait check for buffered
 read/write
To:     qiwuchen55@gmail.com, mark@fasheh.com, jlbec@evilplan.org,
        trivial@kernel.org
Cc:     ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org,
        chenqiwu <chenqiwu@xiaomi.com>
References: <1580541178-7853-1-git-send-email-qiwuchen55@gmail.com>
From:   Joseph Qi <joseph.qi@linux.alibaba.com>
Message-ID: <64ca27c4-c3ee-2a43-3d97-35ad55e11472@linux.alibaba.com>
Date:   Sun, 2 Feb 2020 17:01:25 +0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:60.0)
 Gecko/20100101 Thunderbird/60.9.1
MIME-Version: 1.0
In-Reply-To: <1580541178-7853-1-git-send-email-qiwuchen55@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 20/2/1 15:12, qiwuchen55@gmail.com wrote:
> From: chenqiwu <chenqiwu@xiaomi.com>
> 
> Remove trivial nowait check for buffered read/write, since
> buffered read is checked in generic_file_read_iter()->
> generic_file_buffered_read(), buffered write is checked in
> generic_write_checks().
> 
You are right, but check it at the beginning of
ocfs2_file_[read|write]_iter() will save much effort for lock ops, so
I'd like to leave them there.

Thanks,
Joseph