Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp3254152ybl; Sun, 2 Feb 2020 19:04:17 -0800 (PST) X-Google-Smtp-Source: APXvYqzaWtEje0hUw0pAEELwiEWrcj4FnOsILBG4DJQRdm/YP+18cqLlsGY9SGglzM3Em+Mo9L/q X-Received: by 2002:a9d:4c8c:: with SMTP id m12mr16691289otf.312.1580699056991; Sun, 02 Feb 2020 19:04:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580699056; cv=none; d=google.com; s=arc-20160816; b=FlxHpPUTx3b8dm9yg9t8uxb2NPzai/bVHCPDkTrUR0Bh+wZSvMErkJ20wD4Sqhd/il WB71ZloICRI7HVWgIUOp36Es1vtQah8hqQ2LXA3raozTgOG7JiP7ys2ww1l/AMam43l1 0gZCwoma0A0eYUQJLIAsqjGMMIrX6UJqI87B7cc+VWdwxQmbPA5GpGO4tsYmehIkX6JN FkY+CW2X5SMLWSegOcOpXXwd735tCn5+dVR8Od63j4+pNLFreQCt0fHZEOixqDnC939P Y9GuQIqblozqD9MvpLBGC07xThc4Pvwu8pm54rejxvHZfSDWcQRpbd5qFk1x26Od1el3 zlgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=QGuievnAz+6RxT39lvMX1qmMHH1n6M4mYtCvsmu3+1Q=; b=FC2S8jeCwcEkm5k+71ze5x7EpgarpWtEgp0qGUXEV6EpMbdKGyRaZ5tvRI0+5DT80d fAklxN6/5LsL776txpYHI9dvO19SISh2QMZsLANBjtGAxGwAJckD+X58P5VIc5hDQdhK jCbHnVF4zVgeOkPBUxRG6GClIS9U2uhUNGvAaGExtjIDsApbOPFRs7+uQbUtCqRIXQkJ 03qh8RYVdqC7c9FKHU9Wr2n0m8dtVKr0F0iXewtnufl2l7+TwidSoTqLmX5Iq5F4sqzX vBcWRoQvhppcSsbyYWyxXdqZAWgnHK3ZIjzXSGLkWoQktHi4ST4Qd0HJCHZnKAc06BMf B3yQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=pigs9eQM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 71si9244232otm.111.2020.02.02.19.04.05; Sun, 02 Feb 2020 19:04:16 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=pigs9eQM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727307AbgBCCbs (ORCPT + 99 others); Sun, 2 Feb 2020 21:31:48 -0500 Received: from mail-pl1-f170.google.com ([209.85.214.170]:39324 "EHLO mail-pl1-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726393AbgBCCbs (ORCPT ); Sun, 2 Feb 2020 21:31:48 -0500 Received: by mail-pl1-f170.google.com with SMTP id g6so5225787plp.6; Sun, 02 Feb 2020 18:31:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=QGuievnAz+6RxT39lvMX1qmMHH1n6M4mYtCvsmu3+1Q=; b=pigs9eQM63p5H04ey3FdHUmFgB7MUx1wQStmMuZl4tQvK0VXrU59T+YnyD34Hy+hkC SherjMBhXZtgI2vuyXcBN6ms5peGiEnO2zlfegU7WV9hmziqswZKYgy9hIJ1U7mkkqcR cURdB6n2PgcXOzNav4ktu5w/vvQF0tZ0rdAcmjGlZ0fg6tH53uk+sfNjygrUyJTwGuF/ VtGS0WSOTn9HrdsOvEWFeMgbIjDHUM/P0+K2I2H9VydN7fpTidCEoK3hdKWU/DXUAg47 WZQEHORuebu+Ild+0AuRu636l5xjsao1wgQl7o8bG7rSdbribp3a8dxfubCoj9Dj0uv3 RKJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=QGuievnAz+6RxT39lvMX1qmMHH1n6M4mYtCvsmu3+1Q=; b=lb4Xv9vXn11OBkLYsNxoQAO2wcNVeZG4GQqnB8yL37PCdXcpxnZdqPO2U6tvibKIhk CRS5DQ8RQE6PolmD75NO6pa+x43nisSSVWpGgHCGoq0YUu4p52DFGGyCxD+K28MXVZUH mbSJQF7SLziVzTgqqnOss17Ro0wocDwrcH6ztKfGyRl8gQRc3NskVG5LUVBDRmYL9x4f B8LVdk2sszVwv7vWr1IGZKzCcHGVWW1Eg5EF2vP4GQM4J9Cq3JIjjQp2xcYc/9+imq2m 86fwa47JaZDmIbmEp9iPZ3KiHoEQJDJgbAEPy/Q/lhoBFQKLaxbyk8SvV3NlBvx5SFr2 mUzg== X-Gm-Message-State: APjAAAVI1Ce+LTWwYsgDltZ6T9ROvC7AgCecRlNrbRhtfwheDSYRB76g /h/iveGinVq/sQbjgsSYaxA= X-Received: by 2002:a17:90a:fb41:: with SMTP id iq1mr27423768pjb.89.1580697107688; Sun, 02 Feb 2020 18:31:47 -0800 (PST) Received: from localhost (c-73-241-114-122.hsd1.ca.comcast.net. [73.241.114.122]) by smtp.gmail.com with ESMTPSA id c15sm19682924pja.30.2020.02.02.18.31.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Feb 2020 18:31:47 -0800 (PST) Date: Sun, 2 Feb 2020 18:31:44 -0800 From: Richard Cochran To: christopher.s.hall@intel.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, hpa@zytor.com, mingo@redhat.com, x86@kernel.org, jacob.e.keller@intel.com, davem@davemloft.net, sean.v.kelley@intel.com Subject: Re: [Intel PMC TGPIO Driver 5/5] drivers/ptp: Add PMC Time-Aware GPIO Driver Message-ID: <20200203023144.GD3516@localhost> References: <20191211214852.26317-1-christopher.s.hall@intel.com> <20191211214852.26317-6-christopher.s.hall@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191211214852.26317-6-christopher.s.hall@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 11, 2019 at 01:48:52PM -0800, christopher.s.hall@intel.com wrote: > +static inline u32 intel_pmc_tgpio_readl > +(struct intel_pmc_tgpio_t *tgpio, u32 offset, unsigned int index) Coding style is off the deep end, here and in many following functions. Thanks, Richard