Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH -next] bpf: make btf_check_func_type_match() static
To:     Hongbo Yao <yaohongbo@huawei.com>, <ast@kernel.org>,
        <daniel@iogearbox.net>
CC:     <chenzhou10@huawei.com>, <kafai@fb.com>, <songliubraving@fb.com>,
        <andriin@fb.com>, <netdev@vger.kernel.org>, <bpf@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>,
        <clang-built-linux@googlegroups.com>
References: <20200203020220.117152-1-yaohongbo@huawei.com>
From:   Yonghong Song <yhs@fb.com>
Message-ID: <a29bf101-81b0-68ef-356c-dfdc9c53d899@fb.com>
Date:   Sun, 2 Feb 2020 22:20:31 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0)
 Gecko/20100101 Thunderbird/68.4.1
In-Reply-To: <20200203020220.117152-1-yaohongbo@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
Received-SPF: None (protection.outlook.com: fb.com does not designate
 permitted sender hosts)
X-MS-Exchange-CrossTenant-Network-Message-Id: d9cea84e-7bd2-4a5e-b2cc-08d7a8712e73
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2020 06:20:36.3118
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OutLqTq+6zduPepUAz5Nzz49tHmOmRiJr3BuC7z32tFpbXgwchloDlz3VmGz3mdf
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR15MB2826
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.572
 definitions=2020-02-03_01:2020-02-02,2020-02-03 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 phishscore=0
 mlxlogscore=999 suspectscore=0 clxscore=1011 priorityscore=1501
 adultscore=0 spamscore=0 mlxscore=0 lowpriorityscore=0 malwarescore=0
 bulkscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-1911200001 definitions=main-2002030049
X-FB-Internal: deliver
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2/2/20 6:02 PM, Hongbo Yao wrote:
> Fix sparse warning:
> kernel/bpf/btf.c:4131:5: warning: symbol 'btf_check_func_type_match' was
> not declared. Should it be static?

Yes, static is better since the function is only used in one file.

Please use the tag "[PATCH bpf-next]" instead of "[PATCH -next]".
Since this is to fix a sparse warning, I think it should be okay
to target bpf-next. Please resubmit after bpf-next reopens in
about a week.

> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Hongbo Yao <yaohongbo@huawei.com>
> ---
>   kernel/bpf/btf.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c
> index 8c9d8f266bef..83d3d92023af 100644
> --- a/kernel/bpf/btf.c
> +++ b/kernel/bpf/btf.c
> @@ -4144,7 +4144,7 @@ int btf_distill_func_proto(struct bpf_verifier_log *log,
>    * EFAULT - verifier bug
>    * 0 - 99% match. The last 1% is validated by the verifier.
>    */
> -int btf_check_func_type_match(struct bpf_verifier_log *log,
> +static int btf_check_func_type_match(struct bpf_verifier_log *log,
>   			      struct btf *btf1, const struct btf_type *t1,
>   			      struct btf *btf2, const struct btf_type *t2)

Please also align
   struct btf *btf1, const struct btf_type *t1,
   struct btf *btf2, const struct btf_type *t2)
properly after you added 'static' before the function declaration.

>   {
>