Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp3641584ybl; Mon, 3 Feb 2020 04:02:24 -0800 (PST) X-Google-Smtp-Source: APXvYqzCav1HzGpvQHhl83B3MTRZU8s+xPrUvycEPLWrXDlemPbHcnmckUJqJz94QPB7y7FpoxYe X-Received: by 2002:a9d:62d8:: with SMTP id z24mr16842357otk.362.1580731343695; Mon, 03 Feb 2020 04:02:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580731343; cv=none; d=google.com; s=arc-20160816; b=drsKbC+Y39gdt4ed2ecm6yb3gsLEr6W3SgHUk+fW8Qtqlks3iakewty2n8E3vvv41/ gbVF/OZUb2z1pLBBAb1XdUIxlK6SbHOLe/pZ0vc3nP26qRX5i/S5odrUfpm4MhhmFuNf ngZK1rMfs8OstZbvar0tp7NPhsTGBn1FOnGaXSUi2Prc+vyU2+Mzt/spd7R/IjIc68+4 qnbRmvJ0Gpu+iSFOsCIl2ueJCmI5VZkjFvx1dNtu2zZ7Uw1Qnt5ZZnWZUJahWFyC2F4O kJQJGbGCSQi4mqOCgl0WBihg0TVcHqHDcEVpIwTjltoTjr5nJSHoZOM+r/v9fqsHyvUo dxyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=9M/C89B+RPb3s/AEZzJiX5HrsMKA5pqQCZ+d/xtiimQ=; b=JrF9DhFZBn1EUFspXAV2II1FpxwIw0OFSum+NQAa+Z62xZc/0XlOjcWOoFJPBNFTVi T/ZI0/mOvqA1xmVE1Shvs5FuFW0qNZf4ioAIedb7mZCp2Lfr0aUMDoIwF7YqzhiHuP5Q 7xvFD+vbpEc4860/VYLvlIxiRI5uPLyZDE9wyMt/bk8o8Bq61X3jLTOs/x/ReVpYZ+P+ 7jX5tfHaW2gVAsdZq0NkmuI+Ubg3ujoj8vFpQiXllNTB+ZTeQOTS2s+a8122BNkTYEua U4nFCgPxFRY8V2SN99U1b9XKAGvhb5pZkoonW9l/s0G2I/DTwhk1GHTC3i/9h8SU4+Op BGbA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HGk1szuN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w4si9628101otl.214.2020.02.03.04.02.10; Mon, 03 Feb 2020 04:02:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HGk1szuN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727726AbgBCKl3 (ORCPT + 99 others); Mon, 3 Feb 2020 05:41:29 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:36561 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727661AbgBCKl0 (ORCPT ); Mon, 3 Feb 2020 05:41:26 -0500 Received: by mail-wm1-f68.google.com with SMTP id p17so16325069wma.1 for ; Mon, 03 Feb 2020 02:41:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9M/C89B+RPb3s/AEZzJiX5HrsMKA5pqQCZ+d/xtiimQ=; b=HGk1szuNHr8Rpi6K6AEB+UGzUz7mmYy5IVSIeYVQhByZzdXdbUVfmZOZXNPt+6FaDn 9YBerNBayTRTP2fjJYfNbtSO6+LlPgjwjOIoPMubtwUGpgPGgQUiQYBBSfZRzhrcHCdO 1JVKDUJ1QWcbscUWrS8iB06shr7HP+gyNZcHpdeRLm65/PTor0LwZ0YzW5KmgOMjfs/i scaIjBh4sXpXhScIiFB/DEGdD47H9x/n5w/s5dq6+znXOb7O1TVkhhehsjOkmbz1aIBR 9crljBQOXioT5+DnOKMl5A2EdaWHjOrNys/mlU9TOGFuYovwWoVTCy5mkWfzsRSw7a2x 80QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9M/C89B+RPb3s/AEZzJiX5HrsMKA5pqQCZ+d/xtiimQ=; b=tk/vmiWW5wv5QStbE2cjckbmJoJSXvoddlEgnt0fl9mx25iyIUts/aUAuZIigx58Ix VCdIFOun6ukilgSCtHLUVbkdggy8wZ1mc8o5PZgKF67JGxSr0zG8iFLKXXxaCxP08IUd iXVUFP60yz7gGPvpm8S4SIHYXEOC+TKjWkuWeYKqZ2CWPFXIUlzxUm2pOhALEdk+77iY BiifP29XDfigJ2mIVMUzKlrFUi+WsBREN0NogTPvVAqZsT7eGpMLAnQIH0xRB41jsZrP vUtJNiAr+Pa6+zL6F57paRO9ajl5t/4DU6m/0CIKK9tQuiz4k39wpeYS17fge35/FR3Z X1dQ== X-Gm-Message-State: APjAAAWwQ1MuEqJIGXB6weYnpYaK8OWKBQfeEqf26vk1MfkVkhIFSKU/ iI1tUZBiblQXGudmqwbZ+iEoKg== X-Received: by 2002:a05:600c:d7:: with SMTP id u23mr29184394wmm.145.1580726484032; Mon, 03 Feb 2020 02:41:24 -0800 (PST) Received: from localhost.localdomain (84-33-65-46.dyn.eolo.it. [84.33.65.46]) by smtp.gmail.com with ESMTPSA id i204sm23798930wma.44.2020.02.03.02.41.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Feb 2020 02:41:23 -0800 (PST) From: Paolo Valente To: Jens Axboe Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, bfq-iosched@googlegroups.com, oleksandr@natalenko.name, patdung100@gmail.com, cevich@redhat.com, Paolo Valente Subject: [PATCH BUGFIX V2 7/7] block, bfq: clarify the goal of bfq_split_bfqq() Date: Mon, 3 Feb 2020 11:41:00 +0100 Message-Id: <20200203104100.16965-8-paolo.valente@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200203104100.16965-1-paolo.valente@linaro.org> References: <20200203104100.16965-1-paolo.valente@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The exact, general goal of the function bfq_split_bfqq() is not that apparent. Add a comment to make it clear. Signed-off-by: Paolo Valente --- block/bfq-iosched.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index fff76c920968..8c436abfaf14 100644 --- a/block/bfq-iosched.c +++ b/block/bfq-iosched.c @@ -5979,6 +5979,8 @@ static void bfq_finish_requeue_request(struct request *rq) } /* + * Removes the association between the current task and bfqq, assuming + * that bic points to the bfq iocontext of the task. * Returns NULL if a new bfqq should be allocated, or the old bfqq if this * was the last process referring to that bfqq. */ -- 2.20.1