Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: 2GbKT/VjuBosUULWXJAjtk1xtrvwwrexE16bFfp5An0gW4hTQqd/bTDdDzlKgZtVmCUpMPzgbF
 YGmhsXmByzFZmW2qhekWgBWLVM2OwsQu3qRjNtCVlXJpdb0BBrp6G5czfaCCmVHBFE90j0ymhW
 D+YHPBP3ECIaNIXbKw7PWnSVyYCKOV6aVonLBgggoJX/+3mYdPIol+w34ZUF752bsxIK9Wss6y
 SaWVxHkY6+S6boXkfb1JtBLMt8TXIJCVu4SZPdnJ6ToVqaziP5xcP00fXrs3YKSFrGte6Zp1pm
 obU=
From:   Avi Shchislowski <Avi.Shchislowski@wdc.com>
To:     Guenter Roeck <linux@roeck-us.net>
CC:     Alim Akhtar <alim.akhtar@samsung.com>,
        Avri Altman <Avri.Altman@wdc.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: RE: [PATCH 0/5] scsi: ufs: ufs device as a temperature sensor
Thread-Topic: [PATCH 0/5] scsi: ufs: ufs device as a temperature sensor
Thread-Index: AQHV2bYg6ExsysKG0EeYEdSzahFFuKgISGeAgAEWP7A=
Date:   Mon, 3 Feb 2020 11:57:18 +0000
Message-ID: <MN2PR04MB61906E820FAF0F17082D53AE9A000@MN2PR04MB6190.namprd04.prod.outlook.com>
References: <1580640419-6703-1-git-send-email-avi.shchislowski@wdc.com>
 <20200202192105.GA20107@roeck-us.net>
In-Reply-To: <20200202192105.GA20107@roeck-us.net>
Accept-Language: en-US, he-IL
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 31105a18-7f74-48b3-a7d7-08d7a8a037e7
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Feb 2020 11:57:18.1337
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: wZaOkMNxmKxchIdTOSm5SqZcpxJul4gLyaKNYJDJFW0xI9ZVk8ssiNfXUUf6WnUFQ0+BWVNaeR2fTwbEHjE9V2V32g3pL7hKUGlu0vvHfKY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB6685
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Guenter Roeck <groeck7@gmail.com> On Behalf Of Guenter Roeck
> Sent: Sunday, February 2, 2020 9:21 PM
> To: Avi Shchislowski <Avi.Shchislowski@wdc.com>
> Cc: Alim Akhtar <alim.akhtar@samsung.com>; Avri Altman
> <Avri.Altman@wdc.com>; James E.J. Bottomley <jejb@linux.ibm.com>;
> Martin K. Petersen <martin.petersen@oracle.com>; linux-
> kernel@vger.kernel.org; linux-scsi@vger.kernel.org
> Subject: Re: [PATCH 0/5] scsi: ufs: ufs device as a temperature sensor
>=20
=20
> On Sun, Feb 02, 2020 at 12:46:54PM +0200, Avi Shchislowski wrote:
> > UFS3.0 allows using the ufs device as a temperature sensor. The
> > purpose of this feature is to provide notification to the host of the
> > UFS device case temperature. It allows reading of a rough estimate
> > (+-10 degrees centigrade) of the current case temperature, And setting
> > a lower and upper temperature bounds, in which the device will trigger
> > an applicable exception event.
> >
> > We added the capability of responding to such notifications, while
> > notifying the kernel's thermal core, which further exposes the thermal
> > zone attributes to user space. UFS temperature attributes are all
> > read-only, so only thermal read ops (.get_xxx) can be implemented.
> >
>=20
> Can you add an explanation why this can't be added to the just-introduced
> 'drivetemp' driver in the hwmon subsystem, and why it make sense to have
> proprietary attributes for temperature and temperature limits ?
>=20
> Thanks,
> Guenter
>=20
Hi Guenter

Thank you for your comment

The ufs device is not a temperature sensor per-se.  It is, first and foremo=
st, a storage device.
Reporting the device case temperature is a feature added in a recently rele=
ased UFS spec (UFS3.0).
Therefore, adding a thermal-core module, in opposed to hwmon module, seemed=
 more appropriate.
Registering a hwmon device look excessive, as no other hw-monitoring attrib=
ute is available - aside temperature.

Using Martin's tree, I wasn't able to locate the 'drivetemp' module, nor an=
y reference to  it in the hwmon documentation.

> > Avi Shchislowski (5):
> >   scsi: ufs: Add ufs thermal support
> >   scsi: ufs: export ufshcd_enable_ee
> >   scsi: ufs: enable thermal exception event
> >   scsi: ufs-thermal: implement thermal file ops
> >   scsi: ufs: temperature atrributes add to ufs_sysfs
>=20
> attributes