Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp3795731ybl; Mon, 3 Feb 2020 06:42:35 -0800 (PST) X-Google-Smtp-Source: APXvYqyNeJZwHuYS1QhfJug9J74Pjtv9W94jDul33a6XlTx3bwQflfdrI+MZpTZ37fVaWOyIVGtp X-Received: by 2002:a9d:d0b:: with SMTP id 11mr18635264oti.287.1580740955359; Mon, 03 Feb 2020 06:42:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580740955; cv=none; d=google.com; s=arc-20160816; b=V0mAHZ/0qkgdkQavswUef+fnXq50ImwM+CnE9ylvD8dQiYfLA8mid/aZp+lEC/ic5V I58wARKwu90f0h3GZuaTrLbFBR6iQChMOiQE0Z9eiN8eDHK8nBdHqwDM3st8tn4A5btC gHnNn3zBCAC09iZ7JR3Lo10kswb9TqjHP33X2L+cJQhdeJYlg8t10V81UUZo4gOcI75u QfVTFAU3AM/WrTclNIYRQmopEQ8lbVY0DSH4aUMEEnHXkmmNs39JGYggbKlJyLmrgUg7 fa+/A1seLrGFFxplRylHaG+47djjs5oA7P3IZmwzOACBZuIALlXsbkZzw6Lz0G6X//L2 rbtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:user-agent:references :in-reply-to:subject:cc:to:from:date:content-transfer-encoding :mime-version:dkim-signature; bh=UUaZsIgfN4rwth55A/e8XsKo48z1Y+WrEE3i3Ao4g9w=; b=lwnGTbrm1IOnxqCdGFO09DNoBClz8nL7Sct4HYym7bDDA+IAwQ6jqpP5GlP26T91ek 94EqXWxqazVfuY9Wk1uASmZwmnPsRLSmBWx0yKayhrLySiKBnUxNyDsEAF/gK5R8REij +HTqvdVrFQ90uLmEvq6WyUWo3CfymKfLKQfIxKvJAGkd7mRV0JoZHrCbSn2NOwoqF5S6 ZjcOR8461TZt0NqYicz4cGCPLhX9pxfOssTa7AEojgfaH+/rRx6qkWQoU/FIV8k0s1B/ n5OWToFX0vnlR+1C0QDStwYHRYuy9ZQ/B4P4BjCD2rd42bb3t/l5iJybJFlK2d/IpWIy eONw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@natalenko.name header.s=dkim-20170712 header.b=w016ND5I; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=natalenko.name Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f3si8325222oia.264.2020.02.03.06.42.22; Mon, 03 Feb 2020 06:42:35 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@natalenko.name header.s=dkim-20170712 header.b=w016ND5I; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=natalenko.name Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727961AbgBCMTA (ORCPT + 99 others); Mon, 3 Feb 2020 07:19:00 -0500 Received: from vulcan.natalenko.name ([104.207.131.136]:48330 "EHLO vulcan.natalenko.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727910AbgBCMS5 (ORCPT ); Mon, 3 Feb 2020 07:18:57 -0500 Received: from mail.natalenko.name (vulcan.natalenko.name [IPv6:fe80::5400:ff:fe0c:dfa0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by vulcan.natalenko.name (Postfix) with ESMTPSA id EF5026B1283; Mon, 3 Feb 2020 13:18:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=natalenko.name; s=dkim-20170712; t=1580732334; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UUaZsIgfN4rwth55A/e8XsKo48z1Y+WrEE3i3Ao4g9w=; b=w016ND5I9cnvobILmyGaNCSqLaAW9XD1rxaN66vCzNauL7CVS2YPNxdXMgXqWalH+KLCbQ fw+D4sfk1KZ9CWCVPPv8x9ZZ0z2BhaVYGQY1sG4WWitOJAumHInm1gKQUAibea+8j2Dz7c njP5IvTdhRsm6qRz8IQ+fAR7HkaAGSQ= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 03 Feb 2020 13:18:53 +0100 From: Oleksandr Natalenko To: Paolo Valente Cc: Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, bfq-iosched@googlegroups.com, patdung100@gmail.com, cevich@redhat.com Subject: Re: [PATCH BUGFIX V2 0/7] block, bfq: series of fixes, and not only, for some recently reported issues In-Reply-To: <20200203104100.16965-1-paolo.valente@linaro.org> References: <20200203104100.16965-1-paolo.valente@linaro.org> User-Agent: Roundcube Webmail/1.4.2 Message-ID: X-Sender: oleksandr@natalenko.name Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03.02.2020 11:40, Paolo Valente wrote: > Hi Jens, > this the V2 of the series. The only change is the removal of ifdefs > from around gets and puts of bfq groups. As I wrote in my previous > cover letter, these patches are mostly fixes for the issues reported > in [1, 2]. All patches have been publicly tested in the dev version of > BFQ. > > Thanks, > Paolo > > [1] https://bugzilla.redhat.com/show_bug.cgi?id=1767539 > [2] https://bugzilla.kernel.org/show_bug.cgi?id=205447 > > Paolo Valente (7): > block, bfq: do not plug I/O for bfq_queues with no proc refs > block, bfq: do not insert oom queue into position tree > block, bfq: get extra ref to prevent a queue from being freed during > a > group move > block, bfq: extend incomplete name of field on_st > block, bfq: remove ifdefs from around gets/puts of bfq groups > block, bfq: get a ref to a group when adding it to a service tree > block, bfq: clarify the goal of bfq_split_bfqq() > > block/bfq-cgroup.c | 16 ++++++++++++++-- > block/bfq-iosched.c | 26 ++++++++++++++++++++------ > block/bfq-iosched.h | 4 +++- > block/bfq-wf2q.c | 23 +++++++++++++++++------ > 4 files changed, 54 insertions(+), 15 deletions(-) > > -- > 2.20.1 Feel free to add: Tested-by: Oleksandr Natalenko since I'm running v5.5 with this series applied for a couple of days already without any visible smoke. -- Oleksandr Natalenko (post-factum)